charlie/protocol-property-check - Branch - astral-sh/ruff

[ty] Fix subtyping/assignability for `@property` protocol members

#23034

Comparing

charlie/protocol-property-check

(

c700e4c

) with

main

(

3e367db

)

Untouched: 57

Skipped: 60

Benchmarks

117 total

tanjun

crates/ruff_benchmark/benches/ty_walltime.rs

+2%

3 s3 s

altair

crates/ruff_benchmark/benches/ty_walltime.rs

+1%

4.7 s4.7 s

ty_micro[many_protocol_members_mismatch]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_protocol_members_mismatch

+1%

371.7 ms368.4 ms

ty_micro[typevar_mapping_accumulation]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_typevar_mapping_large_accumulation

+1%

323.4 ms320.7 ms

pandas

crates/ruff_benchmark/benches/ty_walltime.rs

+1%

61.8 s61.3 s

ty_micro[typeis_narrowing]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_typeis_narrowing

+1%

196 ms194.9 ms

pydantic

crates/ruff_benchmark/benches/ty_walltime.rs

+1%

7.9 s7.8 s

ty_micro[large_isinstance_narrowing]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_large_isinstance_narrowing

+1%

152.3 ms151.5 ms

ty_micro[pandas_tdd]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_pandas_tdd

253.3 ms252.2 ms

ty_micro[many_enum_members_2]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_enum_members_2

170.8 ms170.1 ms

ty_micro[very_large_tuple]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_very_large_tuple

75.1 ms74.9 ms

ty_micro[large_union_narrowing]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_large_union_narrowing

533 ms531.4 ms

ty_micro[gradual_vararg_call]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_gradual_vararg_call

73.5 ms73.3 ms

ty_micro[many_string_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_string_assignments

83.5 ms83.3 ms

attrs

crates/ruff_benchmark/benches/ty.rs::project::attrs::project

486.1 ms485.3 ms

ty_micro[complex_constrained_attributes_3]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_3

79.4 ms79.3 ms

multithreaded

crates/ruff_benchmark/benches/ty_walltime.rs

1.1 s1.1 s

ty_check_file[cold]

crates/ruff_benchmark/benches/ty.rs::check_file::benchmark_cold

154.8 ms154.7 ms

ty_micro[vararg_parameter_type_accumulation]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_vararg_parameter_type_accumulation

69.1 ms69 ms

ty_micro[complex_constrained_attributes_2]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_2

72.8 ms72.8 ms

anyio

crates/ruff_benchmark/benches/ty.rs::project::anyio::project

1.2 s1.2 s

ty_micro[complex_constrained_attributes_2]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_2

15.8 MB15.8 MB

ty_micro[typevar_mapping_accumulation]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_typevar_mapping_large_accumulation

32.7 MB32.7 MB

ty_micro[complex_constrained_attributes_1]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_1

15.8 MB15.8 MB

ty_micro[gradual_vararg_call]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_gradual_vararg_call

15.3 MB15.3 MB

Commits

Click on a commit to change the comparison range

Base

main

3e367db

-5.93%

Fix edge cases in writable protocol property checks

97ffffd

3 hours ago

by charliermarsh

+0.12%

Support writable protocol properties in structural subtyping

2808b57

3 hours ago

by charliermarsh

+5.75%

Fix protocol disjointness and variadic property setters

5532a03

2 hours ago

by charliermarsh

+0.09%

Revert nominal

c700e4c

2 hours ago

by charliermarsh

Home Terms Privacy Docs