fix: error with validation results on invalid manifest after verify after sign
#2147Comparing
ok-nick/verify-after-sign
(21488ba
) withmain
(a48f1cc
)+25%
- Improvement
- 1
- Untouched
- 29
- Skipped
- 64
Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments, which may affect the accuracy of the results. Learn more about regression causes.Benchmarks
94 total
update-manifests/read
sdk/benches/complex_read.rs::benches::update_manifests+25%
5.6 MB4.5 MB
wide-assertions/read
sdk/benches/complex_read.rs::benches::wide_assertions+8%
22.2 ms20.5 ms
small
sdk/benches/read.rs::benches::read_jpeg::read jpeg+2%
24.6 ms24.1 ms
wide-ingredients/read
sdk/benches/complex_read.rs::benches::wide_ingredients+1%
239.1 ms236.4 ms
small
sdk/benches/sign.rs::benches::sign_gif::sign gif0%
22.1 ms22 ms
binary-ingredient-tree/read
sdk/benches/complex_read.rs::benches::binary_ingredient_tree0%
773.7 ms772.3 ms
small
sdk/benches/read.rs::benches::read_png::read png0%
20.6 ms20.6 ms
small
sdk/benches/read.rs::benches::read_mp4::read mp40%
26.1 ms26.1 ms
small
sdk/benches/read.rs::benches::read_wav::read wav0%
20.6 ms20.6 ms
small
sdk/benches/sign.rs::benches::sign_wav::sign wav0%
22.9 ms22.9 ms
small
sdk/benches/sign.rs::benches::sign_jpeg::sign jpeg0%
28.5 ms28.5 ms
small
sdk/benches/sign.rs::benches::sign_svg::sign svg0%
120.6 ms120.6 ms
large-json-assertion/read
sdk/benches/complex_read.rs::benches::large_json_assertion0%
8.1 MB8.1 MB
large-cbor-assertion/read
sdk/benches/complex_read.rs::benches::large_cbor_assertion0%
8.1 MB8.1 MB
wide-ingredients/read
sdk/benches/complex_read.rs::benches::wide_ingredients0%
5.7 MB5.7 MB
deep-ingredients/read
sdk/benches/complex_read.rs::benches::deep_ingredients0%
4.7 MB4.7 MB
wide-assertions/read
sdk/benches/complex_read.rs::benches::wide_assertions0%
353.4 KB353.4 KB
small
sdk/benches/read.rs::benches::read_svg::read svg0%
49.1 ms49.1 ms
small
sdk/benches/read.rs::benches::read_mp3::read mp30%
21.1 ms21.1 ms
large-cbor-assertion/read
sdk/benches/complex_read.rs::benches::large_cbor_assertion0%
69.6 ms69.6 ms
large-json-assertion/read
sdk/benches/complex_read.rs::benches::large_json_assertion0%
65.4 ms65.4 ms
small
sdk/benches/sign.rs::benches::sign_tiff::sign tiff0%
21.9 ms21.9 ms
small
sdk/benches/read.rs::benches::read_tiff::read tiff0%
20.8 ms20.8 ms
small
sdk/benches/sign.rs::benches::sign_mp3::sign mp30%
22.2 ms22.2 ms
small
sdk/benches/sign.rs::benches::sign_mp4::sign mp40%
28.7 ms28.7 ms
Commits
Click on a commit to change the comparison rangeBase
main
a48f1cc
-1.45%
test: fix invalid after sign tests
61e2b0b
9 days ago
by ok-nick-0.18%
Merge branch 'main' into ok-nick/verify-after-sign
70aeb27
9 days ago
by ok-nick+0.27%
feat: `ValidatonFailureSummary` in error and impl Display for ValidationResults
c1fb18e
8 days ago
by ok-nick+31.03%
style: cleanup import
f868966
8 days ago
by ok-nick-0.03%
fix: impl verify after sign for embeddable APIs
85c1973
8 days ago
by ok-nick+0.01%
fix: simplify relationship
a5cd586
8 days ago
by ok-nick-4.2%
fix: move hash validation logic to verify_store and only skip hash validation if c2pa on verify after sign
645f0e4
2 days ago
by ok-nick0%
fix: remove unused variable
ebcd9ba
2 days ago
by ok-nick0%
test: fix new c2pa-c-ffi test
1ddc223
2 days ago
by ok-nick0%
chore: set verify_after_sign to false for now
b63023f
2 days ago
by ok-nick0%
refactor: asset_data optional, make Store::validate_manifest, move embeddable validation logic from builder to store
76f435e
2 days ago
by ok-nick0%
style: cleanup
4ec4dfa
2 days ago
by ok-nick0%
docs: cleanup
21488ba
2 days ago
by ok-nick