vaibhav/alarm-later-chain-fix - Branch - cloudflare/workerd

Prevent unbounded alarm scheduling promise chain in ActorSqlite.

#6383Merged

Comparing

vaibhav/alarm-later-chain-fix

(

2ad6f83

) with

main

(

e6407c3

)

+39%

Improvement: 2

Untouched: 68

Skipped: 129

Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments, which may affect the accuracy of the results. Learn more about regression causes.

Benchmarks

199 total

simpleStringBody[Response]

src/workerd/tests/bench-response.c++

+39%

26.9 µs19.3 µs

Encode_ASCII_32[TextEncoder][0/0/32]

src/workerd/tests/bench-text-encoder.c++

+15%

3.1 ms2.7 ms

request[RegExpBenchmark]

src/workerd/tests/bench-regex.c++

+6%

7.3 ms6.9 ms

jsonResponse[Response]

src/workerd/tests/bench-response.c++

40.6 µs40.5 µs

bodyWithHeaders[Response]

src/workerd/tests/bench-response.c++

30.6 µs30.5 µs

EncodeInto_ASCII_8192[TextEncoder][1/0/8192]

src/workerd/tests/bench-text-encoder.c++

3.6 ms3.6 ms

set_append[ApiHeaders]

src/workerd/tests/bench-api-headers.c++

12.1 ms12.1 ms

Encode_TwoByte_1024[TextEncoder][0/2/1024]

src/workerd/tests/bench-text-encoder.c++

16 ms16 ms

Encode_ASCII_256[TextEncoder][0/0/256]

src/workerd/tests/bench-text-encoder.c++

2.7 ms2.7 ms

Encode_ASCII_1024[TextEncoder][0/0/1024]

src/workerd/tests/bench-text-encoder.c++

3.3 ms3.3 ms

Test_JSON_DEC

src/workerd/tests/bench-json.c++

3.3 s3.3 s

EncodeInto_ASCII_1024[TextEncoder][1/0/1024]

src/workerd/tests/bench-text-encoder.c++

2.5 ms2.5 ms

EncodeInto_TwoByte_256[TextEncoder][1/2/256]

src/workerd/tests/bench-text-encoder.c++

5.3 ms5.3 ms

request[GlobalScopeBenchmark]

src/workerd/tests/bench-global-scope.c++

52.4 ms52.4 ms

bm_Http_ClientWrapper

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

34.9 µs34.9 µs

EncodeInto_ASCII_256[TextEncoder][1/0/256]

src/workerd/tests/bench-text-encoder.c++

2.4 ms2.4 ms

EncodeInto_OneByte_256[TextEncoder][1/1/256]

src/workerd/tests/bench-text-encoder.c++

4.3 ms4.3 ms

EncodeInto_OneByte_1024[TextEncoder][1/1/1024]

src/workerd/tests/bench-text-encoder.c++

10.3 ms10.3 ms

bm_Http_OverCapnpLocalCall

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

126.1 µs126.1 µs

Encode_OneByte_8192[TextEncoder][0/1/8192]

src/workerd/tests/bench-text-encoder.c++

84.3 ms84.3 ms

JsString_Utf8Length_Latin1_NonFlat_8192

src/workerd/tests/bench-jsstring.c++

24.9 µs24.9 µs

JsString_Utf8Length_Latin1_NonFlat_1024

src/workerd/tests/bench-jsstring.c++

10.4 µs10.4 µs

bm_Http_Baseline

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

11.3 µs11.3 µs

JsString_Utf8Length_Utf16_NonFlat_8192

src/workerd/tests/bench-jsstring.c++

24.9 µs24.9 µs

JsString_Utf8Length_Utf16_Flat_256

src/workerd/tests/bench-jsstring.c++

2.1 µs2.1 µs

Commits

Click on a commit to change the comparison range

Base

main

e6407c3

-28.54%

Prevent unbounded alarm scheduling promise chain in ActorSqlite.

b345115

26 days ago

by vaibhavSharma-cf

+68.01%

Merge branch 'main' into vaibhav/alarm-later-chain-fix

2ad6f83

1 day ago

by vaibhavSharma-cf

Home Terms Privacy Docs