unsound-upcast - Branch - astral-sh/ruff

[ty] Only unsoundly upcast `type[]` types to their constructor `Callable` type during assignability checks, not during redundancy/subtyping checks

#23834Merged

Comparing

unsound-upcast

(

4f5471a

) with

main

(

7ec0bca

)

Untouched: 26

Skipped: 30

Benchmarks

56 total

multithreaded

crates/ruff_benchmark/benches/ty_walltime.rs

+1%

1.3 s1.3 s

ty_micro[many_enum_members_2]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_enum_members_2

+1%

175.7 ms174.8 ms

ty_micro[many_tuple_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_tuple_assignments

68.5 ms68.3 ms

ty_check_file[incremental]

crates/ruff_benchmark/benches/ty.rs::check_file::benchmark_incremental

8.2 ms8.2 ms

ty_micro[many_tuple_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_tuple_implicit_instance_attributes

70.8 ms70.6 ms

ty_micro[many_enum_members]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_enum_members

99.9 ms99.8 ms

ty_micro[very_large_tuple]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_very_large_tuple

72.6 ms72.5 ms

ty_check_file[cold]

crates/ruff_benchmark/benches/ty.rs::check_file::benchmark_cold

150.3 ms150.3 ms

tanjun

crates/ruff_benchmark/benches/ty_walltime.rs

2.8 s2.8 s

ty_micro[many_string_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_string_assignments

80.5 ms80.5 ms

attrs

crates/ruff_benchmark/benches/ty.rs::project::attrs::project

479.2 ms479.4 ms

ty_micro[complex_constrained_attributes_2]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_2

70.7 ms70.7 ms

anyio

crates/ruff_benchmark/benches/ty.rs::project::anyio::project

1.2 s1.2 s

hydra-zen

crates/ruff_benchmark/benches/ty.rs::project::hydra::project

1.3 s1.3 s

ty_micro[complex_constrained_attributes_3]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_3

76.7 ms76.8 ms

DateType

crates/ruff_benchmark/benches/ty.rs::project::datetype::project

219.2 ms219.5 ms

ty_micro[complex_constrained_attributes_1]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_1

70.8 ms70.9 ms

ty_micro[large_union_narrowing]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_large_union_narrowing

494.4 ms495.7 ms

ty_micro[large_isinstance_narrowing]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_large_isinstance_narrowing

143.9 ms144.4 ms

altair

crates/ruff_benchmark/benches/ty_walltime.rs

-1%

4.9 s4.9 s

sympy

crates/ruff_benchmark/benches/ty_walltime.rs

-1%

65.6 s66 s

pydantic

crates/ruff_benchmark/benches/ty_walltime.rs

-1%

6.1 s6.1 s

freqtrade

crates/ruff_benchmark/benches/ty_walltime.rs

-1%

8.6 s8.7 s

colour_science

crates/ruff_benchmark/benches/ty_walltime.rs

-1%

111.8 s113.3 s

pandas

crates/ruff_benchmark/benches/ty_walltime.rs

-1%

79.2 s80.3 s

Commits

Click on a commit to change the comparison range

Base

main

7ec0bca

-0.16%

[ty] Only unsoundly upcast `type[]` types to their constructor `Callable` type during assignability checks, not during redundancy/subtyping checks

6c58dfc

8 hours ago

by AlexWaygood

-0.04%

remove older tests

4f5471a

7 hours ago

by AlexWaygood

Home Terms Privacy Docs