mvanhorn:fix/ty-semantic-tokens-property-classification - Branch - astral-sh/ruff

[ty] Fix semantic token classification for properties accessed on instances

#24065Merged

Comparing

mvanhorn:fix/ty-semantic-tokens-property-classification

(

355a235

) with

main

(

a033779

)

Untouched: 47

Skipped: 60

Benchmarks

107 total

pydantic

crates/ruff_benchmark/benches/ty_walltime.rs

+1%

7.5 s7.4 s

multithreaded

crates/ruff_benchmark/benches/ty_walltime.rs

-1%

1.3 s1.3 s

colour_science

crates/ruff_benchmark/benches/ty_walltime.rs

+1%

59 s58.6 s

altair

crates/ruff_benchmark/benches/ty_walltime.rs

-1%

5.1 s5.1 s

tanjun

crates/ruff_benchmark/benches/ty_walltime.rs

+1%

2.9 s2.9 s

pandas

crates/ruff_benchmark/benches/ty_walltime.rs

69.7 s69.4 s

ty_micro[large_isinstance_narrowing]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_large_isinstance_narrowing

147.2 ms146.7 ms

ty_micro[large_union_narrowing]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_large_union_narrowing

502.8 ms501.2 ms

sympy

crates/ruff_benchmark/benches/ty_walltime.rs

63.1 s63.3 s

DateType

crates/ruff_benchmark/benches/ty.rs::project::datetype::project

224.1 ms224.4 ms

ty_micro[typeis_narrowing]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_typeis_narrowing

172.5 ms172.7 ms

hydra-zen

crates/ruff_benchmark/benches/ty.rs::project::hydra::project

1.1 s1.1 s

static_frame

crates/ruff_benchmark/benches/ty_walltime.rs

21.5 s21.5 s

ty_check_file[incremental]

crates/ruff_benchmark/benches/ty.rs::check_file::benchmark_incremental

8.2 ms8.2 ms

freqtrade

crates/ruff_benchmark/benches/ty_walltime.rs

7.9 s7.9 s

ty_micro[very_large_tuple]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_very_large_tuple

73.4 ms73.4 ms

ty_micro[pandas_tdd]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_pandas_tdd

251.9 ms252 ms

ty_micro[many_enum_members]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_enum_members

94.6 ms94.6 ms

ty_micro[many_tuple_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_tuple_assignments

69.3 ms69.3 ms

ty_check_file[cold]

crates/ruff_benchmark/benches/ty.rs::check_file::benchmark_cold

152.2 ms152.2 ms

ty_micro[complex_constrained_attributes_2]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_2

71.3 ms71.4 ms

ty_micro[many_string_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_string_assignments

82 ms82 ms

ty_micro[many_tuple_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_tuple_implicit_instance_attributes

71.4 ms71.4 ms

ty_micro[complex_constrained_attributes_1]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_1

71.5 ms71.5 ms

anyio

crates/ruff_benchmark/benches/ty.rs::project::anyio::project

1.2 s1.2 s

Commits

Click on a commit to change the comparison range

Base

main

a033779

[ty] Fix semantic token classification for properties accessed on instances

df43189

5 months ago

by mvanhorn

-0.02%

[ty] Remove redundant is_property_instance guard, match PropertyInstance variant directly

88b1985

5 months ago

by mvanhorn

-0.03%

[ty] Add readonly modifier for read-only properties, fix cargo fmt

6f01ec3

4 months ago

by mvanhorn

-0.03%

[ty] Set readonly modifier for properties from definition path

469dc6f

4 months ago

by mvanhorn

+0.01%

[ty] Fix failing snapshot tests, add property_readonly_modifier test

cc4a189

4 months ago

+0.07%

Fix more tests

0945862

4 months ago

by MichaReiser

+0.01%

fix: prefer PropertyInstanceType with setter, add union fallback test

d704fbd

4 months ago

by mvanhorn

+0.04%

fix: detect setter via AST decorator, handle union fallback

9a87642

4 months ago

by mvanhorn

+0.02%

fix: scan class AST for setter decorator instead of relying on type

de7c1a4

4 months ago

by mvanhorn

+0.01%

Formatting, snapshots

ed3fdde

4 months ago

by MichaReiser

-0.04%

Simplify

ea2b364

4 months ago

by MichaReiser

-0.02%

Use `static_member`

355a235

4 months ago

by MichaReiser

Home Terms Privacy Docs