mvanhorn:fix/ty-semantic-tokens-property-classification - Branch - astral-sh/ruff

[ty] Fix semantic token classification for properties accessed on instances

#24065

Comparing

mvanhorn:fix/ty-semantic-tokens-property-classification

(

6f01ec3

) with

main

(

690ef81

)

Untouched: 28

Skipped: 30

Benchmarks

58 total

pandas

crates/ruff_benchmark/benches/ty_walltime.rs

70.4 s70.2 s

tanjun

crates/ruff_benchmark/benches/ty_walltime.rs

3 s2.9 s

freqtrade

crates/ruff_benchmark/benches/ty_walltime.rs

7.9 s7.9 s

altair

crates/ruff_benchmark/benches/ty_walltime.rs

5.2 s5.2 s

attrs

crates/ruff_benchmark/benches/ty.rs::project::attrs::project

474.8 ms474.6 ms

anyio

crates/ruff_benchmark/benches/ty.rs::project::anyio::project

1.2 s1.2 s

ty_micro[large_union_narrowing]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_large_union_narrowing

498 ms498 ms

DateType

crates/ruff_benchmark/benches/ty.rs::project::datetype::project

224.5 ms224.5 ms

ty_micro[many_enum_members]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_enum_members

94 ms93.9 ms

ty_micro[very_large_tuple]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_very_large_tuple

72.4 ms72.4 ms

ty_check_file[cold]

crates/ruff_benchmark/benches/ty.rs::check_file::benchmark_cold

151.4 ms151.4 ms

ty_micro[large_isinstance_narrowing]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_large_isinstance_narrowing

144.7 ms144.7 ms

ty_micro[many_enum_members_2]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_enum_members_2

172.7 ms172.7 ms

ty_micro[many_string_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_string_assignments

80.9 ms80.9 ms

ty_micro[many_tuple_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_tuple_assignments

68.3 ms68.3 ms

ty_micro[many_tuple_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_tuple_implicit_instance_attributes

70.5 ms70.5 ms

ty_micro[typeis_narrowing]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_typeis_narrowing

173 ms173 ms

ty_check_file[incremental]

crates/ruff_benchmark/benches/ty.rs::check_file::benchmark_incremental

8.1 ms8.1 ms

ty_micro[complex_constrained_attributes_3]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_3

76.8 ms76.8 ms

ty_micro[complex_constrained_attributes_2]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_2

70.4 ms70.4 ms

ty_micro[complex_constrained_attributes_1]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_1

70.8 ms70.8 ms

hydra-zen

crates/ruff_benchmark/benches/ty.rs::project::hydra::project

1.1 s1.1 s

pydantic

crates/ruff_benchmark/benches/ty_walltime.rs

7.3 s7.3 s

sympy

crates/ruff_benchmark/benches/ty_walltime.rs

63.5 s63.7 s

ty_micro[pandas_tdd]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_pandas_tdd

248.8 ms249.5 ms

Commits

Click on a commit to change the comparison range

Base

main

690ef81

[ty] Fix semantic token classification for properties accessed on instances

df43189

7 days ago

by mvanhorn

-0.02%

[ty] Remove redundant is_property_instance guard, match PropertyInstance variant directly

88b1985

6 days ago

by mvanhorn

-0.03%

[ty] Add readonly modifier for read-only properties, fix cargo fmt

6f01ec3

5 hours ago

by mvanhorn

Home Terms Privacy Docs