claude/fix-typeddict-validation-a0z2F - Branch - astral-sh/ruff

[ty] Ban nested `Required`/`NotRequired`, and ban them both outside of `TypedDict` fields

#23627Merged

Comparing

claude/fix-typeddict-validation-a0z2F

(

44e8572

) with

main

(

f1a9a70

)

Untouched: 26

Skipped: 30

Benchmarks

56 total

ty_micro[large_isinstance_narrowing]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_large_isinstance_narrowing

+1%

146.1 ms144.8 ms

ty_micro[large_union_narrowing]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_large_union_narrowing

+1%

499.7 ms496.6 ms

multithreaded

crates/ruff_benchmark/benches/ty_walltime.rs

1.2 s1.2 s

ty_micro[many_enum_members_2]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_enum_members_2

168.3 ms167.9 ms

DateType

crates/ruff_benchmark/benches/ty.rs::project::datetype::project

219.3 ms218.9 ms

ty_micro[many_enum_members]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_enum_members

131.7 ms131.5 ms

ty_check_file[cold]

crates/ruff_benchmark/benches/ty.rs::check_file::benchmark_cold

150.8 ms150.6 ms

hydra-zen

crates/ruff_benchmark/benches/ty.rs::project::hydra::project

1.3 s1.3 s

ty_micro[complex_constrained_attributes_2]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_2

71 ms71 ms

attrs

crates/ruff_benchmark/benches/ty.rs::project::attrs::project

480.6 ms480.3 ms

ty_micro[very_large_tuple]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_very_large_tuple

72.4 ms72.3 ms

anyio

crates/ruff_benchmark/benches/ty.rs::project::anyio::project

1.2 s1.2 s

ty_micro[many_string_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_string_assignments

80.9 ms80.9 ms

ty_check_file[incremental]

crates/ruff_benchmark/benches/ty.rs::check_file::benchmark_incremental

8.2 ms8.2 ms

ty_micro[many_tuple_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_tuple_implicit_instance_attributes

70.8 ms70.9 ms

ty_micro[complex_constrained_attributes_3]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_3

77 ms77 ms

sympy

crates/ruff_benchmark/benches/ty_walltime.rs

64 s64.1 s

static_frame

crates/ruff_benchmark/benches/ty_walltime.rs

31.2 s31.3 s

ty_micro[complex_constrained_attributes_1]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_1

71.1 ms71.3 ms

colour_science

crates/ruff_benchmark/benches/ty_walltime.rs

127 s127.4 s

ty_micro[many_tuple_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_tuple_assignments

68.4 ms68.6 ms

freqtrade

crates/ruff_benchmark/benches/ty_walltime.rs

9.2 s9.2 s

altair

crates/ruff_benchmark/benches/ty_walltime.rs

4.8 s4.8 s

pandas

crates/ruff_benchmark/benches/ty_walltime.rs

80.1 s80.5 s

pydantic

crates/ruff_benchmark/benches/ty_walltime.rs

-1%

6.1 s6.1 s

Commits

Click on a commit to change the comparison range

Base

main

f1a9a70

-0.75%

Move Required/NotRequired tests into typed_dict.md

0e2ea58

23 days ago

by claude

+0.71%

fix false positives for functional typeddicts

44e8572

23 days ago

by AlexWaygood

Home Terms Privacy Docs