claude/fix-isinstance-issubclass-diagnostics-NT9SK - Branch - astral-sh/ruff

[ty] Recurse into tuples and nested tuples when applying special-cased validation of `isinstance()` and `issubclass()`

#23607Merged

Comparing

claude/fix-isinstance-issubclass-diagnostics-NT9SK

(

06510e5

) with

main

(

e30a40e

)

Untouched: 26

Skipped: 30

Benchmarks

56 total

DateType

crates/ruff_benchmark/benches/ty.rs::project::datetype::project

-1%

212 ms214.3 ms

ty_micro[many_enum_members_2]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_enum_members_2

-1%

163.6 ms165.1 ms

ty_micro[large_union_narrowing]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_large_union_narrowing

-1%

495.6 ms499.9 ms

attrs

crates/ruff_benchmark/benches/ty.rs::project::attrs::project

-1%

469.6 ms473.2 ms

ty_micro[large_isinstance_narrowing]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_large_isinstance_narrowing

-1%

142.2 ms143.2 ms

anyio

crates/ruff_benchmark/benches/ty.rs::project::anyio::project

-1%

1.2 s1.2 s

pydantic

crates/ruff_benchmark/benches/ty_walltime.rs

-1%

6 s6 s

hydra-zen

crates/ruff_benchmark/benches/ty.rs::project::hydra::project

-1%

1.3 s1.3 s

ty_micro[very_large_tuple]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_very_large_tuple

-1%

69.2 ms69.6 ms

ty_micro[many_tuple_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_tuple_assignments

-1%

65.3 ms65.7 ms

ty_micro[many_string_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_string_assignments

-1%

77.5 ms77.9 ms

ty_micro[complex_constrained_attributes_3]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_3

73.6 ms73.9 ms

ty_micro[complex_constrained_attributes_1]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_1

67.9 ms68.2 ms

ty_micro[many_tuple_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_tuple_implicit_instance_attributes

67.5 ms67.8 ms

ty_check_file[incremental]

crates/ruff_benchmark/benches/ty.rs::check_file::benchmark_incremental

8.2 ms8.1 ms

ty_check_file[cold]

crates/ruff_benchmark/benches/ty.rs::check_file::benchmark_cold

146.3 ms146.8 ms

colour_science

crates/ruff_benchmark/benches/ty_walltime.rs

125.6 s126.1 s

altair

crates/ruff_benchmark/benches/ty_walltime.rs

4.7 s4.7 s

tanjun

crates/ruff_benchmark/benches/ty_walltime.rs

2.7 s2.8 s

ty_micro[many_enum_members]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_enum_members

128.2 ms128.5 ms

static_frame

crates/ruff_benchmark/benches/ty_walltime.rs

30.9 s30.9 s

ty_micro[complex_constrained_attributes_2]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_2

67.8 ms67.9 ms

freqtrade

crates/ruff_benchmark/benches/ty_walltime.rs

9.1 s9.1 s

multithreaded

crates/ruff_benchmark/benches/ty_walltime.rs

1.2 s1.2 s

pandas

crates/ruff_benchmark/benches/ty_walltime.rs

79.5 s79.4 s

Commits

Click on a commit to change the comparison range

Base

main

e30a40e

-0.24%

[ty] Add tests for nested tuple arguments in isinstance/issubclass

10c5d16

6 months ago

by claude

-0.18%

[ty] Fix panic on splatted isinstance/issubclass calls

06510e5

6 months ago

by claude

Home Terms Privacy Docs