[flake8-simplify] Make SIM114 fix unsafe when comments between branches would be deleted
#24102Comparing
chinar-amrutkar:fix/sim114-comment-deletion
(eed5d23
) withmain
(39c3636
)0%
- Untouched
- 60
- Skipped
- 47
Benchmarks
107 total
linter/all-rules[numpy/globals.py]
crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules0%
754 µs750.4 µs
linter/all-with-preview-rules[unicode/pypinyin.py]
crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules0%
2.3 ms2.3 ms
linter/all-with-preview-rules[numpy/globals.py]
crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules0%
850.1 µs847.7 µs
linter/all-rules[unicode/pypinyin.py]
crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules0%
2 ms2 ms
linter/all-with-preview-rules[pydantic/types.py]
crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules0%
10.5 ms10.5 ms
linter/all-rules[pydantic/types.py]
crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules0%
8.9 ms8.9 ms
linter/all-rules[numpy/ctypeslib.py]
crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules0%
4.5 ms4.5 ms
linter/all-with-preview-rules[numpy/ctypeslib.py]
crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules0%
5.3 ms5.3 ms
linter/all-rules[large/dataset.py]
crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules0%
19.5 ms19.5 ms
linter/all-with-preview-rules[large/dataset.py]
crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules0%
23.4 ms23.4 ms
parser[numpy/globals.py]
crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser0%
105.5 µs105.4 µs
linter/default-rules[large/dataset.py]
crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules0%
4.3 ms4.3 ms
parser[unicode/pypinyin.py]
crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser0%
314.8 µs314.7 µs
parser[large/dataset.py]
crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser0%
4.9 ms4.9 ms
parser[pydantic/types.py]
crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser0%
1.9 ms1.9 ms
parser[numpy/ctypeslib.py]
crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser0%
902.6 µs902.5 µs
linter/default-rules[unicode/pypinyin.py]
crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules0%
57.5 KB57.5 KB
lexer[numpy/globals.py]
crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer0%
887 B887 B
lexer[pydantic/types.py]
crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer0%
237 B237 B
linter/all-rules[large/dataset.py]
crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules0%
1 MB1 MB
parser[large/dataset.py]
crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser0%
912.2 KB912.2 KB
formatter[numpy/ctypeslib.py]
crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter0%
247.6 KB247.6 KB
formatter[large/dataset.py]
crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter0%
1.1 MB1.1 MB
parser[numpy/ctypeslib.py]
crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser0%
200.5 KB200.5 KB
linter/all-with-preview-rules[numpy/ctypeslib.py]
crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules0%
316.5 KB316.5 KB
Commits
Click on a commit to change the comparison rangeBase
main
39c3636
+0.18%
fix: correct CommentRanges import path and update snapshots
342433c
4 days ago
by chinar-amrutkar-0.17%
Add test case for multi-line compound test with EOL comment on closing paren
8a11d38
1 day ago
by chinar-amrutkar+0.01%
Use Ruff's built-in is_pragma_comment instead of custom implementation
030718d
2 hours ago
by chinar-amrutkar0%
Avoid Vec allocations when comparing comment ranges
0e5dd82
2 hours ago
by chinar-amrutkar0%
Fix test case to actually test comments between branches; mark fix unsafe
ca5874e
2 hours ago
by chinar-amrutkar0%
chore: update SIM114 snapshot to current insta format
eed5d23
16 minutes ago
by chinar-amrutkar