[ty] Fix subtyping/assignability for `@property` protocol members
#25332Comparing
charlie/protocol-property-check-2
(f22f8ad
) withmain
(0df5488
)0%
- Untouched
- 63
- Skipped
- 60
Benchmarks
123 total
ty_micro[large_union_narrowing]
crates/ruff_benchmark/benches/ty.rs::micro::benchmark_large_union_narrowing+1%
536 ms531.3 ms
ty_micro[large_isinstance_narrowing]
crates/ruff_benchmark/benches/ty.rs::micro::benchmark_large_isinstance_narrowing+1%
151.5 ms150.2 ms
ty_micro[many_tuple_assignments]
crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_tuple_assignments+1%
63.1 ms62.8 ms
ty_micro[complex_constrained_attributes_3]
crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_30%
77.7 ms77.4 ms
ty_micro[complex_constrained_attributes_1]
crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_10%
71.5 ms71.3 ms
ty_micro[gradual_vararg_call]
crates/ruff_benchmark/benches/ty.rs::micro::benchmark_gradual_vararg_call0%
71.6 ms71.4 ms
attrs
crates/ruff_benchmark/benches/ty.rs::project::attrs::project0%
512 ms510.6 ms
ty_micro[many_tuple_assignments]
crates/ruff_benchmark/benches/ty.rs::micro::benchmark_tuple_implicit_instance_attributes0%
71 ms70.8 ms
ty_check_file[cold]
crates/ruff_benchmark/benches/ty.rs::check_file::benchmark_cold0%
151.4 ms151.2 ms
anyio
crates/ruff_benchmark/benches/ty.rs::project::anyio::project0%
1.2 s1.2 s
ty_micro[vararg_parameter_type_accumulation]
crates/ruff_benchmark/benches/ty.rs::micro::benchmark_vararg_parameter_type_accumulation0%
61 ms61 ms
ty_micro[very_large_tuple]
crates/ruff_benchmark/benches/ty.rs::micro::benchmark_very_large_tuple0%
15.8 MB15.8 MB
ty_micro[many_enum_members_2]
crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_enum_members_20%
17.2 MB17.2 MB
ty_micro[complex_constrained_attributes_2]
crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_20%
16.1 MB16.1 MB
ty_micro[pandas_tdd]
crates/ruff_benchmark/benches/ty.rs::micro::benchmark_pandas_tdd0%
46.9 MB46.9 MB
ty_micro[many_protocol_members_mismatch]
crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_protocol_members_mismatch0%
22.3 MB22.3 MB
ty_micro[many_tuple_assignments]
crates/ruff_benchmark/benches/ty.rs::micro::benchmark_tuple_implicit_instance_attributes0%
16.2 MB16.2 MB
ty_micro[complex_constrained_attributes_1]
crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_10%
16.1 MB16.1 MB
ty_micro[complex_constrained_attributes_3]
crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_30%
17.6 MB17.6 MB
ty_micro[many_tuple_assignments]
crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_tuple_assignments0%
14.8 MB14.8 MB
ty_micro[typevar_mapping_accumulation]
crates/ruff_benchmark/benches/ty.rs::micro::benchmark_typevar_mapping_large_accumulation0%
33 MB33 MB
ty_micro[typeis_narrowing]
crates/ruff_benchmark/benches/ty.rs::micro::benchmark_typeis_narrowing0%
23.3 MB23.3 MB
ty_micro[gradual_vararg_call]
crates/ruff_benchmark/benches/ty.rs::micro::benchmark_gradual_vararg_call0%
15.6 MB15.6 MB
ty_micro[many_string_assignments]
crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_string_assignments0%
17.1 MB17.1 MB
ty_micro[many_enum_members]
crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_enum_members0%
18.5 MB18.5 MB
Commits
Click on a commit to change the comparison rangeBase
main
0df5488
-0.26%
more variance
749a83f
9 months ago
by AlexWaygood-0.04%
Address protocol property review feedback
56ac33e
8 hours ago
by charliermarsh+0.26%
Simplify shared attribute write resolution
303c5bf
7 hours ago
by charliermarsh-0.13%
Simplify attribute write requirements
df58139
7 hours ago
by charliermarsh-0.09%
Fix property setter accepting Any; custom descriptor whose __set__ returns Never
f22f8ad
7 hours ago
by charliermarsh