brent/plw1510-fix - Branch - astral-sh/ruff - CodSpeed

Blog Docs Changelog

[`pylint`] Demote `PLW1510` fix to display-only

#22318Merged

Comparing

brent/plw1510-fix

(

8cd04df

) with

main

(

15aa742

)

0%

Untouched: 30

Skipped: 22

Benchmarks

Skipped (22)

These benchmarks were skipped, so their baseline results are used instead. If they were deleted in your codebase, archive them to remove them from the performance reports.
Learn more about archiving benchmarks

Uses the Wall Time instrument
to collect wall time performance metrics.

pandas

crates/ruff_benchmark/benches/ty_walltime.rs

Skipped

64.7 s*

Uses the Wall Time instrument
to collect wall time performance metrics.

tanjun

crates/ruff_benchmark/benches/ty_walltime.rs

Skipped

2.5 s*

Uses the Wall Time instrument
to collect wall time performance metrics.

altair

crates/ruff_benchmark/benches/ty_walltime.rs

Skipped

5.1 s*

Uses the Wall Time instrument
to collect wall time performance metrics.

freqtrade

crates/ruff_benchmark/benches/ty_walltime.rs

Skipped

8.1 s*

Uses the Wall Time instrument
to collect wall time performance metrics.

pydantic

crates/ruff_benchmark/benches/ty_walltime.rs

Skipped

10.4 s*

Uses the Wall Time instrument
to collect wall time performance metrics.

multithreaded

crates/ruff_benchmark/benches/ty_walltime.rs

Skipped

1.4 s*

Uses the Wall Time instrument
to collect wall time performance metrics.

colour_science

crates/ruff_benchmark/benches/ty_walltime.rs

Skipped

94.9 s*

Uses the Wall Time instrument
to collect wall time performance metrics.

static_frame

crates/ruff_benchmark/benches/ty_walltime.rs

Skipped

21.8 s*

Uses the Wall Time instrument
to collect wall time performance metrics.

sympy

crates/ruff_benchmark/benches/ty_walltime.rs

Skipped

52.2 s*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

attrs

crates/ruff_benchmark/benches/ty.rs::project::attrs::project

Skipped

436.2 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

DateType

crates/ruff_benchmark/benches/ty.rs::project::datetype::project

Skipped

235.9 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

hydra-zen

crates/ruff_benchmark/benches/ty.rs::project::hydra::project

Skipped

1.2 s*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

ty_micro[many_string_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_string_assignments

Skipped

80.3 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

ty_micro[many_tuple_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_tuple_assignments

Skipped

66 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

ty_check_file[cold]

crates/ruff_benchmark/benches/ty.rs::check_file::benchmark_cold

Skipped

131.8 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

ty_micro[complex_constrained_attributes_2]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_2

Skipped

68.2 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

ty_micro[complex_constrained_attributes_1]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_1

Skipped

68.3 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

ty_check_file[incremental]

crates/ruff_benchmark/benches/ty.rs::check_file::benchmark_incremental

Skipped

6.1 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

ty_micro[many_enum_members]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_enum_members

Skipped

122.5 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

ty_micro[many_tuple_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_tuple_implicit_instance_attributes

Skipped

68.2 ms*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

anyio

crates/ruff_benchmark/benches/ty.rs::project::anyio::project

Skipped

1.2 s*

Uses the CPU Simulation instrument
to collect CPU performance metrics.

ty_micro[complex_constrained_attributes_3]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_3

Skipped

71.4 ms*

Passed

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/default-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

0%

4.2 ms4.2 ms

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/default-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

0%

2.2 ms2.2 ms

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/default-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

0%

208.6 µs208.2 µs

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/default-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

0%

1 ms1 ms

Uses the CPU Simulation instrument
to collect CPU performance metrics.

parser[numpy/globals.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

0%

108.5 µs108.5 µs

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/default-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

0%

404.3 µs404.3 µs

Uses the CPU Simulation instrument
to collect CPU performance metrics.

formatter[numpy/globals.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

0%

247.6 µs247.6 µs

Uses the CPU Simulation instrument
to collect CPU performance metrics.

parser[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

0%

946.4 µs946.2 µs

Uses the CPU Simulation instrument
to collect CPU performance metrics.

parser[unicode/pypinyin.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

0%

328.7 µs328.7 µs

Uses the CPU Simulation instrument
to collect CPU performance metrics.

parser[large/dataset.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

0%

5.1 ms5.1 ms

Uses the CPU Simulation instrument
to collect CPU performance metrics.

formatter[unicode/pypinyin.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

0%

688.8 µs688.8 µs

Uses the CPU Simulation instrument
to collect CPU performance metrics.

parser[pydantic/types.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

0%

2 ms2 ms

Uses the CPU Simulation instrument
to collect CPU performance metrics.

formatter[pydantic/types.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

0%

3.6 ms3.6 ms

Uses the CPU Simulation instrument
to collect CPU performance metrics.

formatter[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

0%

1.9 ms1.9 ms

Uses the CPU Simulation instrument
to collect CPU performance metrics.

lexer[numpy/globals.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

0%

30.2 µs30.2 µs

Uses the CPU Simulation instrument
to collect CPU performance metrics.

lexer[unicode/pypinyin.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

0%

79 µs79 µs

Uses the CPU Simulation instrument
to collect CPU performance metrics.

lexer[large/dataset.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

0%

1.2 ms1.2 ms

Uses the CPU Simulation instrument
to collect CPU performance metrics.

formatter[large/dataset.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

0%

9.4 ms9.4 ms

Uses the CPU Simulation instrument
to collect CPU performance metrics.

lexer[pydantic/types.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

0%

510 µs510 µs

Uses the CPU Simulation instrument
to collect CPU performance metrics.

lexer[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

0%

227.8 µs227.9 µs

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/all-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

0%

8.5 ms8.5 ms

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/all-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

0%

2 ms2 ms

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/all-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

0%

4.3 ms4.3 ms

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/all-with-preview-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

0%

5.2 ms5.2 ms

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/all-with-preview-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

0%

837 µs837.5 µs

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/all-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

0%

733.3 µs733.7 µs

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/all-with-preview-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

0%

10.2 ms10.2 ms

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/all-with-preview-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

0%

2.2 ms2.2 ms

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/all-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

0%

18.4 ms18.4 ms

Uses the CPU Simulation instrument
to collect CPU performance metrics.

linter/all-with-preview-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

0%

22.5 ms22.5 ms

Commits

Click on a commit to change the comparison range

Base

main

15aa742

+0.01%

[`pylint`] Demote `PLW1510` fix to display-only Summary -- Closes #17091. `PLW1510` checks for `subprocess.run` calls without a `check` keyword argument and previously had a safe fix to add `check=False`. That's the default value, so technically it preserved the code's behavior, but as discussed in #17091 and #17087, Ruff can't actually know what the author intended. I don't think it hurts to keep this as a display-only fix instead of removing it entirely, but it definitely shouldn't be safe at the very least. Test Plan -- Existing tests

8cd04df

14 days ago

by ntBre

© 2026 CodSpeed Technology

Home Terms Privacy Docs