Avatar for the GalSim-developers user
GalSim-developers
JAX-GalSim
BlogDocsChangelog

feat: investigate maxk differences and add galsim algorithm for maxk

#224Merged
Comparing
fix-maxk
(
ffcef75
) with
main
(
e3ff71f
)
CodSpeed Performance Gauge
-32%
Improvement
7
Regression
1
Untouched
28

Benchmarks

36 total
test_benchmark_spergel_conv[run]
tests/jax/test_benchmarks.py
CodSpeed Performance Gauge
-32%
156.4 ms230.7 ms
test_benchmarks_lanczos_interp[xval-conserve_dc-run]
tests/jax/test_benchmarks.py
CodSpeed Performance Gauge
+60%
129.5 µs81.2 µs
test_benchmarks_lanczos_interp[xval-no_conserve_dc-run]
tests/jax/test_benchmarks.py
CodSpeed Performance Gauge
+57%
114.1 µs72.8 µs
test_benchmark_moffat_init[run]
tests/jax/test_benchmarks.py
CodSpeed Performance Gauge
+44%
97.3 µs67.7 µs
test_benchmark_invert_ab_noraise[run]
tests/jax/test_benchmarks.py
CodSpeed Performance Gauge
+39%
144.7 µs104.2 µs
test_benchmarks_lanczos_interp[kval-no_conserve_dc-run]
tests/jax/test_benchmarks.py
CodSpeed Performance Gauge
+37%
56.4 µs41.3 µs
test_benchmarks_lanczos_interp[kval-conserve_dc-run]
tests/jax/test_benchmarks.py
CodSpeed Performance Gauge
+36%
55.3 µs40.6 µs
test_benchmark_spergel_calcfluxrad[run]
tests/jax/test_benchmarks.py
CodSpeed Performance Gauge
+30%
215.2 µs165.4 µs
test_benchmark_moffat_conv[run]
tests/jax/test_benchmarks.py
CodSpeed Performance Gauge
-29%
188.2 ms265.7 ms
test_benchmark_moffat_conv_grad[run]
tests/jax/test_benchmarks.py
CodSpeed Performance Gauge
-29%
291.2 ms410.6 ms
test_benchmarks_metacal[run]
tests/jax/test_benchmarks.py
CodSpeed Performance Gauge
-25%
12.5 ms16.8 ms
test_benchmarks_interpolated_image[run]
tests/jax/test_benchmarks.py
CodSpeed Performance Gauge
-22%
3.8 ms4.9 ms
test_benchmark_spergel_xvalue[run]
tests/jax/test_benchmarks.py
CodSpeed Performance Gauge
-21%
1.8 s2.2 s
test_benchmark_interpimage_flux_frac[run]
tests/jax/test_benchmarks.py
CodSpeed Performance Gauge
+18%
434.6 µs369.5 µs
test_benchmark_rng_discard[run]
tests/jax/test_benchmarks.py
CodSpeed Performance Gauge
+16%
114.6 µs98.6 µs
test_benchmark_spergel_kvalue[run]
tests/jax/test_benchmarks.py
CodSpeed Performance Gauge
-13%
11.6 ms13.4 ms
test_benchmark_invert_ab_noraise[run]
tests/jax/test_benchmarks.py
CodSpeed Performance Gauge
-10%
1.2 ms1.4 ms
test_benchmark_gaussian_init[run]
tests/jax/test_benchmarks.py
CodSpeed Performance Gauge
+9%
7 µs6.4 µs
test_benchmark_spergel_init[run]
tests/jax/test_benchmarks.py
CodSpeed Performance Gauge
+5%
6.8 µs6.4 µs
test_benchmark_interpimage_flux_frac[run]
tests/jax/test_benchmarks.py
CodSpeed Performance Gauge
-5%
2.9 ms3 ms
test_benchmarks_interpolated_image[run]
tests/jax/test_benchmarks.py
CodSpeed Performance Gauge
+1%
39.7 ms39.4 ms
test_benchmark_spergel_calcfluxrad[run]
tests/jax/test_benchmarks.py
CodSpeed Performance Gauge
+1%
1.1 ms1.1 ms
test_benchmark_gaussian_init[run]
tests/jax/test_benchmarks.py
CodSpeed Performance Gauge
0%
103.3 µs103.1 µs
test_benchmark_spergel_init[run]
tests/jax/test_benchmarks.py
CodSpeed Performance Gauge
0%
103.3 µs103.5 µs
test_benchmarks_lanczos_interp[xval-no_conserve_dc-run]
tests/jax/test_benchmarks.py
CodSpeed Performance Gauge
0%
1.1 ms1.1 ms

Commits

Click on a commit to change the comparison range
Base
main
e3ff71f
+0.4%
test: remove setting maxk since this now works too?
c9346d8
2 months ago
by beckermr
+33.41%
test: rename test to make purpose clearer
1b8f8f6
2 months ago
by beckermr
+30.3%
test: run new test suite
86d669b
2 months ago
by beckermr
-62.41%
test: tighter tolerance
5a7b1c3
2 months ago
by beckermr
+0.04%
feat: add galsim maxk version
8902ea6
2 months ago
by beckermr
-2.51%
feat: use a scan op to match galsim exactly
d6f7911
2 months ago
by beckermr
-0.59%
fix: adjust indexing a bit
9973dc2
2 months ago
by beckermr
+72.06%
fix: off by one only if we reach the end of the array; galsim is fine
fd7770f
2 months ago
by beckermr
-68.04%
test: simplify tests
1758be5
2 months ago
by beckermr
-34.87%
perf: use faster algorithm
ffcef75
2 months ago
by beckermr
© 2026 CodSpeed Technology
Home Terms Privacy Docs