kevin/gcs-special-chars - Branch - Eventual-Inc/Daft

fix: special characters in GCS urls

#3651Merged

Comparing

kevin/gcs-special-chars

(

bbedc10

) with

main

(

1562569

)

+12%

Improvements: 1

Untouched: 23

Ignored: 4

Benchmarks

Improved

test_tpch_sql[1-in-memory-native-8]

tests/benchmarks/test_local_tpch.py::test_tpch_sql[1-in-memory-native-8]

+12%

220.2 ms197.3 ms

Passed

test_show[1 Small File]

tests/benchmarks/test_interactive_reads.py::test_show[1 Small File]

+4%

12 ms11.5 ms

test_tpch_sql[1-in-memory-native-9]

tests/benchmarks/test_local_tpch.py::test_tpch_sql[1-in-memory-native-9]

+4%

542.2 ms521.3 ms

test_tpch[1-in-memory-native-1]

tests/benchmarks/test_local_tpch.py::test_tpch[1-in-memory-native-1]

+4%

489.3 ms470.5 ms

test_tpch[1-in-memory-native-5]

tests/benchmarks/test_local_tpch.py::test_tpch[1-in-memory-native-5]

+3%

343.2 ms334.4 ms

test_tpch[1-in-memory-native-3]

tests/benchmarks/test_local_tpch.py::test_tpch[1-in-memory-native-3]

+2%

154.7 ms151.1 ms

test_tpch[1-in-memory-native-7]

tests/benchmarks/test_local_tpch.py::test_tpch[1-in-memory-native-7]

+2%

158 ms154.4 ms

test_tpch_sql[1-in-memory-native-5]

tests/benchmarks/test_local_tpch.py::test_tpch_sql[1-in-memory-native-5]

+2%

268.4 ms263.1 ms

test_tpch_sql[1-in-memory-native-3]

tests/benchmarks/test_local_tpch.py::test_tpch_sql[1-in-memory-native-3]

+2%

157 ms154 ms

test_tpch[1-in-memory-native-8]

tests/benchmarks/test_local_tpch.py::test_tpch[1-in-memory-native-8]

+2%

189.1 ms186.1 ms

test_tpch_sql[1-in-memory-native-7]

tests/benchmarks/test_local_tpch.py::test_tpch_sql[1-in-memory-native-7]

+1%

787.4 ms776.1 ms

test_tpch[1-in-memory-native-2]

tests/benchmarks/test_local_tpch.py::test_tpch[1-in-memory-native-2]

+1%

114.4 ms113 ms

test_explain[100 Small Files]

tests/benchmarks/test_interactive_reads.py::test_explain[100 Small Files]

+1%

6 ms5.9 ms

test_tpch_sql[1-in-memory-native-6]

tests/benchmarks/test_local_tpch.py::test_tpch_sql[1-in-memory-native-6]

+1%

30 ms29.8 ms

test_tpch_sql[1-in-memory-native-4]

tests/benchmarks/test_local_tpch.py::test_tpch_sql[1-in-memory-native-4]

158 ms157.6 ms

test_tpch[1-in-memory-native-10]

tests/benchmarks/test_local_tpch.py::test_tpch[1-in-memory-native-10]

228 ms227.8 ms

test_tpch[1-in-memory-native-4]

tests/benchmarks/test_local_tpch.py::test_tpch[1-in-memory-native-4]

154 ms154 ms

test_count[100 Small Files]

tests/benchmarks/test_interactive_reads.py::test_count[100 Small Files]

72.1 ms72.2 ms

test_iter_rows_first_row[1 Small File]

tests/benchmarks/test_interactive_reads.py::test_iter_rows_first_row[1 Small File]

101 ms101.1 ms

test_tpch[1-in-memory-native-6]

tests/benchmarks/test_local_tpch.py::test_tpch[1-in-memory-native-6]

29 ms29.1 ms

test_tpch_sql[1-in-memory-native-1]

tests/benchmarks/test_local_tpch.py::test_tpch_sql[1-in-memory-native-1]

489.4 ms491 ms

test_tpch_sql[1-in-memory-native-2]

tests/benchmarks/test_local_tpch.py::test_tpch_sql[1-in-memory-native-2]

240.5 ms241.5 ms

test_tpch_sql[1-in-memory-native-10]

tests/benchmarks/test_local_tpch.py::test_tpch_sql[1-in-memory-native-10]

-1%

243.5 ms245.7 ms

test_tpch[1-in-memory-native-9]

tests/benchmarks/test_local_tpch.py::test_tpch[1-in-memory-native-9]

-2%

487.3 ms494.8 ms

Ignored

test_explain[1 Small File]

tests/benchmarks/test_interactive_reads.py::test_explain[1 Small File]

Ignored

+1%

1.8 ms1.8 ms

test_show[100 Small Files]

tests/benchmarks/test_interactive_reads.py::test_show[100 Small Files]

Ignored

+1%

15.9 ms15.7 ms

test_count[1 Small File]

tests/benchmarks/test_interactive_reads.py::test_count[1 Small File]

Ignored

+4%

3.7 ms3.5 ms

test_iter_rows_first_row[100 Small Files]

tests/benchmarks/test_interactive_reads.py::test_iter_rows_first_row[100 Small Files]

Ignored

+9%

215.4 ms197.1 ms

Commits

Click on a commit to change the comparison range

Base

main

1562569

+26.56%

fix: special characters in GCS urls

037b27b

8 months ago

by kevinzwang

-60.34%

add test and remove prints

8cb0fb6

8 months ago

by kevinzwang

+59.62%

make key optional

a71cd16

8 months ago

by kevinzwang

-45.88%

update comment a little bit

4bea563

8 months ago

by kevinzwang

+31.66%

fix regex

bbedc10

8 months ago

by kevinzwang

Home Terms Privacy Docs