fix-huggingface-filenotfound-fallback - Branch - Eventual-Inc/Daft

fix: handle FileNotFoundError in read_huggingface fallback

#5831Merged

Comparing

fix-huggingface-filenotfound-fallback

(

aae08ee

) with

main

(

4ea6f25

)

Untouched: 24

Ignored: 4

Benchmarks

Passed

test_iter_rows_first_row[1 Small File]

tests/benchmarks/test_interactive_reads.py

+2%

35.6 ms35 ms

test_show[1 Small File]

tests/benchmarks/test_interactive_reads.py

+1%

12.4 ms12.2 ms

test_tpch_sql[1-in-memory-2]

tests/benchmarks/test_local_tpch.py

+1%

165.3 ms163.3 ms

test_tpch_sql[1-in-memory-1]

tests/benchmarks/test_local_tpch.py

+1%

401.8 ms398.4 ms

test_explain[100 Small Files]

tests/benchmarks/test_interactive_reads.py

+1%

12.2 ms12.1 ms

test_count[100 Small Files]

tests/benchmarks/test_interactive_reads.py

57.5 ms57.4 ms

test_tpch[1-in-memory-6]

tests/benchmarks/test_local_tpch.py

28.4 ms28.4 ms

test_tpch_sql[1-in-memory-3]

tests/benchmarks/test_local_tpch.py

116.3 ms116.3 ms

test_tpch_sql[1-in-memory-10]

tests/benchmarks/test_local_tpch.py

189.1 ms189.2 ms

test_tpch_sql[1-in-memory-5]

tests/benchmarks/test_local_tpch.py

117.4 ms117.6 ms

test_tpch[1-in-memory-9]

tests/benchmarks/test_local_tpch.py

272.7 ms273.1 ms

test_tpch_sql[1-in-memory-8]

tests/benchmarks/test_local_tpch.py

133.8 ms134.2 ms

test_tpch_sql[1-in-memory-6]

tests/benchmarks/test_local_tpch.py

29.1 ms29.3 ms

test_tpch[1-in-memory-3]

tests/benchmarks/test_local_tpch.py

124.2 ms124.6 ms

test_tpch[1-in-memory-8]

tests/benchmarks/test_local_tpch.py

148.3 ms148.9 ms

test_tpch[1-in-memory-1]

tests/benchmarks/test_local_tpch.py

400.2 ms401.9 ms

test_tpch_sql[1-in-memory-4]

tests/benchmarks/test_local_tpch.py

88.6 ms89 ms

test_tpch[1-in-memory-4]

tests/benchmarks/test_local_tpch.py

-1%

87.8 ms88.3 ms

test_tpch_sql[1-in-memory-9]

tests/benchmarks/test_local_tpch.py

-1%

264.5 ms265.9 ms

test_tpch[1-in-memory-10]

tests/benchmarks/test_local_tpch.py

-1%

195.5 ms196.8 ms

test_tpch_sql[1-in-memory-7]

tests/benchmarks/test_local_tpch.py

-1%

117.4 ms118.3 ms

test_tpch[1-in-memory-7]

tests/benchmarks/test_local_tpch.py

-1%

125 ms126.3 ms

test_tpch[1-in-memory-5]

tests/benchmarks/test_local_tpch.py

-1%

129.6 ms131.1 ms

test_tpch[1-in-memory-2]

tests/benchmarks/test_local_tpch.py

-1%

56.3 ms57.1 ms

Ignored

test_explain[1 Small File]

tests/benchmarks/test_interactive_reads.py

Ignored

-6%

2.1 ms2.2 ms

test_show[100 Small Files]

tests/benchmarks/test_interactive_reads.py

Ignored

22.8 ms22.7 ms

test_count[1 Small File]

tests/benchmarks/test_interactive_reads.py

Ignored

+5%

3.6 ms3.5 ms

test_iter_rows_first_row[100 Small Files]

tests/benchmarks/test_interactive_reads.py

Ignored

-23%

158 ms205 ms

Commits

Click on a commit to change the comparison range

Base

main

4ea6f25

-0.1%

fix: handle FileNotFoundError in read_huggingface fallback When HuggingFace's parquet API returns no files (glob returns no matches), read_huggingface now falls back to the datasets library instead of raising FileNotFoundError. This complements the existing fallback for 400 errors and makes read_huggingface more robust against HuggingFace API changes.

aae08ee

13 hours ago

by ykdojo

Home Terms Privacy Docs