colin/fix-s3-lance - Branch - Eventual-Inc/Daft

[BUG] Include storage options in lance write commit

#3451Merged

Comparing

colin/fix-s3-lance

(

ff41687

) with

main

(

f2d4f73

)

+14%

Untouched: 14

Ignored: 4

Benchmarks

Passed

test_show[1 Small File]

tests/benchmarks/test_interactive_reads.py::test_show[1 Small File]

+2%

12.2 ms12 ms

test_tpch[1-in-memory-native-1]

tests/benchmarks/test_local_tpch.py::test_tpch[1-in-memory-native-1]

+2%

454.3 ms446.7 ms

test_tpch[1-in-memory-native-2]

tests/benchmarks/test_local_tpch.py::test_tpch[1-in-memory-native-2]

+2%

101.8 ms100.2 ms

test_explain[100 Small Files]

tests/benchmarks/test_interactive_reads.py::test_explain[100 Small Files]

+1%

8.4 ms8.3 ms

test_iter_rows_first_row[1 Small File]

tests/benchmarks/test_interactive_reads.py::test_iter_rows_first_row[1 Small File]

+1%

102.2 ms100.9 ms

test_tpch[1-in-memory-native-10]

tests/benchmarks/test_local_tpch.py::test_tpch[1-in-memory-native-10]

+1%

200.5 ms198.9 ms

test_tpch[1-in-memory-native-8]

tests/benchmarks/test_local_tpch.py::test_tpch[1-in-memory-native-8]

+1%

158 ms157.1 ms

test_tpch[1-in-memory-native-3]

tests/benchmarks/test_local_tpch.py::test_tpch[1-in-memory-native-3]

138.9 ms138.9 ms

test_count[100 Small Files]

tests/benchmarks/test_interactive_reads.py::test_count[100 Small Files]

71.6 ms71.8 ms

test_tpch[1-in-memory-native-7]

tests/benchmarks/test_local_tpch.py::test_tpch[1-in-memory-native-7]

131.7 ms132.1 ms

test_tpch[1-in-memory-native-4]

tests/benchmarks/test_local_tpch.py::test_tpch[1-in-memory-native-4]

-1%

143.4 ms144.1 ms

test_tpch[1-in-memory-native-6]

tests/benchmarks/test_local_tpch.py::test_tpch[1-in-memory-native-6]

-1%

28.8 ms29 ms

test_tpch[1-in-memory-native-9]

tests/benchmarks/test_local_tpch.py::test_tpch[1-in-memory-native-9]

-1%

446.8 ms450.3 ms

test_tpch[1-in-memory-native-5]

tests/benchmarks/test_local_tpch.py::test_tpch[1-in-memory-native-5]

-1%

314.6 ms318.6 ms

Ignored

test_show[100 Small Files]

tests/benchmarks/test_interactive_reads.py::test_show[100 Small Files]

Ignored

-1%

25 ms25.2 ms

test_iter_rows_first_row[100 Small Files]

tests/benchmarks/test_interactive_reads.py::test_iter_rows_first_row[100 Small Files]

Ignored

+14%

304.2 ms266.7 ms

test_explain[1 Small File]

tests/benchmarks/test_interactive_reads.py::test_explain[1 Small File]

Ignored

2 ms2 ms

test_count[1 Small File]

tests/benchmarks/test_interactive_reads.py::test_count[1 Small File]

Ignored

3.7 ms3.7 ms

Commits

Click on a commit to change the comparison range

Base

main

f2d4f73

+14.06%

storage options in commit

ff41687

10 months ago

Home Terms Privacy Docs