Latest Results
fix(chunk-grids): judge every chunk specification by the chunk normalizer alone (#4376)
* fix: make the chunk normalizer the one judge of a chunk specification
Chunk specifications were parsed by `normalize_chunks_nd`, but a separate
duck-typed classifier, `_is_rectilinear_chunks`, ran on the raw input first
at three sites to decide whether the spec was rectilinear. Two opinions on
the same input is the shape of the bug in #4374, and they could disagree:
a 0-d numpy array counted as rectilinear because it has `__iter__`.
The classifier is gone. Each site normalizes first and asks the resulting
`ChunkGrid` (`is_regular`); stored rectilinear metadata passed as
`chunks=` counts as rectilinear even when its edges are uniform. The shard
resolver sends regular and rectilinear shard specs through the same
normalizer.
Also fixed on the way:
- The legacy v2 branch of `AsyncArray.create` tested `chunks or
chunk_shape`, so `zarr.create(chunks=np.array([...]), zarr_format=2)`
failed with "truth value of an array is ambiguous". It now uses the
`is not None` form the v3 branch already had.
- 0-d numpy arrays unwrap to their scalar in both normalizers instead of
failing with "len() of unsized object".
- A non-integer scalar spec (`2.0`, `np.float64`) raises the normalizer's
own TypeError instead of "object has no len()".
Assisted-by: ClaudeCode:claude-fable-5-1
* docs: add changelog fragment for #4376
Assisted-by: ClaudeCode:claude-fable-5-1
* refactor(chunk_grids): one integer test for chunk input
`_chunk_int` is the normalizer's single integer rule: anything Python's
integer protocol accepts (int, numpy integer scalars, 0-d integer arrays),
except bool. It replaces the repeated numbers.Integral checks and the two
0-d ndarray unwraps in normalize_chunks_1d / normalize_chunks_nd.
Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test: keep numpy chunk tests that cover real bugs; pin legacy v2 rectilinear rejection
The numpy cases that passed before this PR are dropped; the 0-d array and
float cases move into the normalizer's table and error tests. The legacy
zarr.create Zarr format 2 path gets a truthiness test and its rectilinear
rejection is now asserted with a message match.
Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* docs: note legacy v2 chunks=0/[] and bool chunk sizes in the #4376 changelog
Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* refactor(chunk_grids): explicit edge lists stay rectilinear in ChunkGrid.from_sizes
`ChunkGrid.from_sizes` collapsed uniform edge lists to `FixedDimension`
while `normalize_chunks_1d` keeps them as `VaryingDimension`, so
`init_array` needed an `isinstance(chunks, RectilinearChunkGridMetadata)`
guard to keep uniform stored rectilinear grids under the Zarr format 2 and
sharding restrictions. Both now agree that a list declares a rectilinear
dimension, and the guard is gone: the normalized grid is the one judge.
Also: `normalize_chunks_nd` and the shard spec are typed with `ChunksLike`;
a bool chunk size is reported as not a chunk size; an integral float
(`10.0`) is pinned as rejected; `None` reaching the normalizer gets the
generic non-integer `TypeError`.
Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(chunk_grids): reject every spelling of a boolean chunk size with one error
A bool, np.bool_, or boolean array anywhere in a chunk specification now
raises the same TypeError from the normalizer's one integer test, instead
of three different errors depending on spelling. Document that a
RectilinearChunkGridMetadata of bare integers is read as a regular grid.
Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(chunk_grids): keep zarr 3.4.0's reading of bool chunk sizes and falsy v2 chunks (patch release)
Nothing in a patch release may reject a chunk specification that zarr 3.4.0
accepted. The normalizer's integer test reads a Python `bool` as the `int` it
is again, so `chunks=(True, 5)` and a `True` edge are a chunk size of 1;
`chunks=True` and `chunks=None` raise 3.4.0's `ValueError` again. Numpy
booleans stay rejected, as they were. The legacy `zarr.create(...,
zarr_format=2)` again reads a falsy `chunks` (0, [], False) as not given and
chunks automatically; a numpy array is always taken as given, so its truth
value is never tested.
The `TypeError` for every boolean spelling returns in the next minor release.
Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* docs: describe the 4376 changes for a patch release
Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(array): read one-element and empty numpy chunk arrays in legacy v2 create as zarr 3.4.0 did
The legacy `zarr.create(..., zarr_format=2)` took every numpy array as a
given chunk specification, so `np.array(0)`, `np.array(False)` and
`np.array([0])` raised instead of auto-chunking as in zarr 3.4.0. A numpy
array with more than one element has no truth value and is always given; a
shorter one is read by `.any()`, its truth value, which is False when empty,
so `np.array([])` auto-chunks like `[]` (as 3.4.0 did with numpy 2.1).
The two legacy v2 tests become one table.
Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* refactor(chunk_grids): let operator.index be the only integer test in _chunk_int
`operator.index` raises `TypeError` for everything the `SupportsIndex`
check rejected, so the check was redundant (identical results over bool,
numpy bools and integers, 0-d and 1-d arrays, float, str, bytes, None,
list and a custom `__index__` class).
Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test(chunk_grids): read bool chunk sizes as rows of the normalizer table
Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* refactor(array): name the legacy v2 chunks-given test as _v2_chunks_given
Replace the inline conditional expression in `AsyncArray._create` with a
small named predicate. Results are identical on every probed input.
Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test(array): pin 0-d and all-zero numpy chunks in legacy v2 create
Add `np.array(7)` -> `(7, 7)` to `test_legacy_create_v2_chunks` and an
error test for `np.array([0, 0])`, killing the mutants that drop either
half of `_v2_chunks_given`.
Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(chunk-grids): accept sequences that only define __getitem__ and __len__
The chunk normalizer checked `isinstance(chunks, Iterable)` before calling
`list(chunks)`. `Iterable` does not recognize a sequence that implements
only `__getitem__` and `__len__`, which `list` accepts and which zarr 3.4.0
took as a chunk specification. The normalizer now calls `list` and turns
its `TypeError` into the chunk specification error.
Assisted-by: ClaudeCode:claude-opus-5-5
* fix(chunk-grids): reject NumPy booleans as chunk sizes on NumPy before 2.3
NumPy before 2.3 takes a NumPy boolean as an index with a
DeprecationWarning, so `operator.index(np.True_)` returned 1 there, and
the normalizer read `chunks=np.True_` as a chunk size of 1 instead of
rejecting it as zarr 3.4.0 did. The min-deps CI job failed on this. The
integer test now rejects a value whose dtype is NumPy bool before calling
`operator.index`.
Assisted-by: ClaudeCode:claude-opus-5-5
* fix(chunk-grids): declare every accepted chunk form in ShardsLike and zarr.create
ShardsLike is now ChunksLike plus the sharding configuration and "auto", so
numpy integers and arrays are declared for shards as they are for chunks.
zarr.create and AsyncArray._create take ChunksLike for chunks and
chunk_shape, matching what the normalizer reads. Tests drop the Any
annotations and the type: ignore that worked around the narrower types.
Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(array): read only None as an absent chunks argument in legacy zarr.create
The Zarr format 2 path of AsyncArray._create used the truth value of
`chunks` to decide whether it was given, so False, 0, [] and np.array([0])
were silently auto-chunked while Zarr format 3 normalized or rejected them.
Both formats now share the None-only `_raw_chunks` and agree on every input.
Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(sharding): parse the inner chunk shape with the chunk normalizer as a regular grid
ShardingCodec read its inner chunk_shape with parse_shapelike, which
allows 0, so an inner size of 0 was accepted at construction and failed
later with ZeroDivisionError. parse_regular_chunk_shape shares the
normalizer's integer test (_chunk_int/_chunk_list) and requires every
size to be at least 1; with no axis length to resolve against, -1 and
False are rejected, and an explicit edge list (a rectilinear dimension)
is rejected because the inner grid of a shard is regular.
Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(metadata): parse the Zarr format 2 chunk shape as a regular chunk shape
ArrayV2Metadata read `chunks` with parse_shapelike, which accepts 0, while
RegularChunkGridMetadata rejects it. It now uses parse_regular_chunk_shape,
as ShardingCodec does, so a chunk size below 1 raises at construction.
Stored documents are unaffected: from_dict repairs a stored 0 before the
constructor sees it. The shared chunk-shape tests cover both sites again.
Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* docs(api): describe what zarr.create does with chunks=None, False and True
The docstring said True guesses the chunk shape and is the default; None is
the default and True raises. The auto-chunking error now tells
create_array callers to pass "auto" rather than the None they just passed.
Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* revert: keep the strict chunk-size changes in #4431, out of this patch PR
Reverts 47587bc14, baddb31b2 and ad34ae83d, and the error-message part of
e54740185. Rejecting a chunk size of 0 in ArrayV2Metadata and
ShardingCodec, and no longer reading a falsy `chunks` as absent in the
legacy Zarr format 2 zarr.create, reject inputs zarr 3.4.0 accepted; this
PR targets the 3.4.1 patch release, which must not. #4431 makes the same
changes, more strictly, for the next minor release. The widened chunk and
shard annotations and the zarr.create docstring fix stay.
Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> chore: centralize development and CI verbs in just (#4372)
* chore: extract just recipes from hatch replacement proposal
Extracts the Justfile from 98dcde719834bcd6fc010ffc4b07be5ae02fc2e4 (zarr-developers/zarr-python#4096). Environment and CI migration changes are adapted separately.
Assisted-by: Codex:GPT-6
* chore: use just for python helpers
Extracts the Justfile changes from 693f694e50b9ae4cd7c6b0d93238b9ee9f8f6865 (zarr-developers/zarr-python#4096).
Assisted-by: Codex:GPT-6
* chore: centralize development and CI verbs in just
Keep Hatch environment definitions while moving task commands into Justfile. Route root CI, Read the Docs, and contributor workflows through the same recipes, preserve quoted arguments, and ship recipes and helpers in the sdist.
Assisted-by: Codex:GPT-6
* chore: delegate package commands to their justfiles
Expose package recipes from the root while retaining each package’s command definitions and working directory.
Assisted-by: Codex:GPT-6
* fix(ci): harden the just migration's environment, pinning and release path
Review follow-ups to the Justfile centralization:
- `just gpu` read HATCH_ENV, so an exported CPU test environment silently
redirected `pytest -m gpu` into an env built without the gpu feature. It now
reads GPU_HATCH_ENV, which nothing else sets.
- Pin `uvx prek` to 0.5.3 and restore hook-environment caching in the lint
workflow, so lint no longer floats on whatever prek PyPI serves that day.
- Restore the mypy hook's `uv run --frozen mypy` entry: routing it through
`just typecheck` made just a prerequisite for committing in every existing
clone, and expanded to the identical command.
- Run the changelog filename check with `uv run --no-project python` instead of
building the `dev` hatch env (test + remote-tests + docs + mypy) for a script
that imports only sys and pathlib.
- Extend `just just-check` over packages/*/justfile, which the root delegation
recipes depend on and the formatting gate did not cover.
- Set up Python in the codspeed job before pip-installing into it, matching the
other workflows; that runner image was never given one.
- Revert the release and nightly-wheel jobs to `hatch build`, so the publishing
path does not fetch rust-just to run a pure alias.
- Renumber the changelog fragment to this pull request and credit #4096 in the
body, so the rendered note does not link to an unrelated upstream PR.
Assisted-by: ClaudeCode:claude-opus-5
* fix(ci): install prek persistently for git hooks; run setup steps in one just process
`just hooks-install` ran `uvx prek install`, and prek writes a hook shim that
hard-codes the binary it was installed from, falling back to `prek` on PATH.
Under uvx that path is an entry in uv's archive cache, so the first
`uv cache prune` (or a bump of the pinned version) broke every commit with
`prek: not found`, and nothing put `prek` on PATH for the fallback. Install it
as a pinned `uv tool` instead: a changed pin upgrades in place, a repeated run
is a no-op, and the shim points at a path that stays.
`setup` re-invoked `just list-env`, which dropped a `just hatch_env=... setup`
override on the floor because the child process re-read HATCH_ENV. Run it as a
subsequent dependency so both steps see the same value.
Also retire the last two comments naming the removed hatch scripts.
Assisted-by: ClaudeCode:claude-fable-5-1
* chore: renumber the changelog fragment to the upstream pull request
towncrier renders the fragment name as a link into
zarr-developers/zarr-python, so the fork's PR number would have pointed the
released note at an unrelated upstream pull request. #4372 is the PR that
merges this work.
Assisted-by: ClaudeCode:claude-opus-5
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* ci: install just as a binary in the benchmark job
Adding `actions/setup-python` to this job so that `pip install rust-just` had
an interpreter also changed which interpreter hatch built
`test.py3.12-minimal` on: the runner's own Python was replaced by
/opt/hostedtoolcache/Python/3.12.5/arm64. CodSpeed measured the result as a
12.97% degradation across 26 benchmarks, spread -12.76% to -13.99% -- a range
of 1.2 points over slice indexing, sharded Morton indexing, three array shapes
and two store types. Nothing in this branch touches src/, tests/benchmarks/ or
packages/; that uniformity is an interpreter swap, not a regression, and
CodSpeed flagged it as "different runtime environments detected".
Install just with extractions/setup-just instead, matching the three package
workflows. No interpreter is set up, so hatch resolves the same Python the
baseline used, and `just-version` is pinned to satisfy zizmor's unpinned-tools
audit.
The benchmarks need a re-run to produce a comparison against a matching
environment; the numbers on the previous run should not be acknowledged as a
regression.
Assisted-by: ClaudeCode:claude-opus-5
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* ci: install just from official release binaries; lock the docs toolchain
Follow-ups from an adversarial audit of this branch.
Supply chain. `rust-just` is a third-party repackaging of just on PyPI
(Repository: github.com/gnpaone/rust-just) with no attestation on any of its
17 wheels, and this branch had introduced it in ten places including the
self-hosted GPU runner and Read the Docs. All 23 just installs across the repo
now come from casey/just's own release binaries via
extractions/setup-crate@7577c1bd (v2.0.1), a node action whose SHA pins every
line of executed code -- rather than extractions/setup-just, a composite
wrapper that astral-sh/python-build-standalone#771 moved off for that reason.
This also retires the 12 pre-existing setup-just call sites, so the repo has
one mechanism instead of four. setup-crate does not verify checksums
(extractions/setup-just#20 is open); Read the Docs, where no action is
available, fetches the release tarball and verifies it against the SHA256SUMS
casey/just publishes.
Lockfile. docs.yml had stopped resolving from uv.lock: `uv sync --group docs`
became `hatch run docs:`, and hatch never reads the lockfile, so the entire
docs toolchain floated -- including numcodecs[msgpack], which carries no
version constraint. Dependabot's uv ecosystem exists to keep that lock fresh
and no job exercised it any more. The eight docs and changelog recipes now run
`uv run --frozen --group docs`, so single-version tooling comes from the lock
(as mypy already did) while hatch keeps the test environments, which exist per
interpreter and per dependency set and cannot live in one lockfile. The hatch
docs environment is removed as unused, and neither docs.yml nor Read the Docs
installs hatch at all now.
Argument forwarding. The three package justfiles splatted `{{ args }}`
unquoted, so `just zarr-metadata test -k 'a and b'` reached pytest as `-k a`
plus two stray paths, and command substitution in an argument executed. They
now use `set positional-arguments` and `"$@"` like the root, which is what the
contributing guide already claimed.
Also, regressions from my own earlier commits on this branch: `just lint` had
dropped `--show-diff-on-failure --color=always`, which j178/prek-action passed
by default, so a hook that rewrote a file failed with no diff; a four-line
comment above `hooks-install` displaced its `just --list` description, since
just reads only the last comment line; the prek cache key did not cover
prek_version and had a restore-keys fallback that could reuse a store built by
a different prek; `just just-check` ran before `just lint`, so a cosmetic
formatting nit hid every real lint result; and the `packages/*/justfile` glob
lacked nullglob, which breaks in the sdist, where /Justfile ships but
/packages deliberately does not.
Docs: the install instructions used `pip install`, which fails on an
externally-managed interpreter; `just just-check` was an undocumented required
check; two sentences still told contributors to activate an environment that
no longer exists; and the changelog fragment did not mention that the Hatch
script tables were removed. Adds a .gitattributes rule so a Windows checkout
does not get a CRLF Justfile that `just --fmt --check` rejects on every line.
Assisted-by: ClaudeCode:claude-opus-5
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
---------
Co-authored-by: Max Jones <14077947+maxrjones@users.noreply.github.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Latest Branches
+23%
bendichter:bytes-partial-decode +14%
d-v-b:refactor/all-equal-cpu-scan +15%
PursuitOfDataScience:perf/all-equal-write-path © 2026 CodSpeed Technology