fix: run fallback view transition for old page only after dispatching `astro:before-swap` event
#14041MergedComparing
dixslyf:fix-fallback-view-transition-too-early
(22fe095
) withmain
(42562f9
)0%
- Improvements
- 0
- Regressions
- 0
- Untouched
- 6
- New
- 0
- Dropped
- 0
- Ignored
- 0
Benchmarks
Passed
Rendering: streaming [false], .astro file
benchmark/bench/codspeed.bench.js::Bench rendering::Rendering: streaming [false], .astro file+4%
919 ms
887.8 ms
Rendering: streaming [false], .md file
benchmark/bench/codspeed.bench.js::Bench rendering::Rendering: streaming [false], .md file0%
12.9 ms
12.9 ms
Rendering: streaming [false], .mdx file
benchmark/bench/codspeed.bench.js::Bench rendering::Rendering: streaming [false], .mdx file0%
711.4 ms
711.4 ms
Rendering: streaming [true], .md file
benchmark/bench/codspeed.bench.js::Bench rendering::Rendering: streaming [true], .md file0%
12.8 ms
12.8 ms
Rendering: streaming [true], .astro file
benchmark/bench/codspeed.bench.js::Bench rendering::Rendering: streaming [true], .astro file0%
932.6 ms
936.3 ms
Rendering: streaming [true], .mdx file
benchmark/bench/codspeed.bench.js::Bench rendering::Rendering: streaming [true], .mdx file0%
719.1 ms
722 ms
Commits
Click on a commit to change the comparison rangeBase
main
42562f9
0%
chore: add changeset for fallback view transition bug fix
d4b84e2
2 days ago
by dixslyf0%
chore: use more concrete example in fallback view transition bug fix changeset
27d1775
1 day ago
by dixslyf0%
Create skip.astro
9912b29
1 day ago
by martrapp0%
Additional test for skipTransition in fallback mode
d3db395
1 day ago
by martrapp0%
Testing the opposite case: animations run if they are not skipped.
f5467a6
1 day ago
by martrapp0%
Updated expectations
If values turn out to be nondeterministic we should remove them from the string
d38422f
1 day ago
by martrapp0%
chore: simplify fallback view transition bug fix changeset
22fe095
23 hours ago
by dixslyf