Comparing
altano:fonts-fix-fallbacks-type
(00926a2
) withmain
(6ed8360
)0%
- Improvements
- 0
- Regressions
- 0
- Untouched
- 6
- New
- 0
- Dropped
- 0
- Ignored
- 0
Benchmarks
Passed
Rendering: streaming [false], .mdx file
benchmark/bench/codspeed.bench.js::Bench rendering::Rendering: streaming [false], .mdx file0%
715.4 ms
712.7 ms
Rendering: streaming [true], .astro file
benchmark/bench/codspeed.bench.js::Bench rendering::Rendering: streaming [true], .astro file0%
936.3 ms
936 ms
Rendering: streaming [true], .md file
benchmark/bench/codspeed.bench.js::Bench rendering::Rendering: streaming [true], .md file0%
12.8 ms
12.8 ms
Rendering: streaming [false], .md file
benchmark/bench/codspeed.bench.js::Bench rendering::Rendering: streaming [false], .md file0%
12.9 ms
12.9 ms
Rendering: streaming [true], .mdx file
benchmark/bench/codspeed.bench.js::Bench rendering::Rendering: streaming [true], .mdx file0%
720.3 ms
720.8 ms
Rendering: streaming [false], .astro file
benchmark/bench/codspeed.bench.js::Bench rendering::Rendering: streaming [false], .astro file0%
885.5 ms
887.3 ms
Commits
Click on a commit to change the comparison rangeBase
main
6ed8360
0%
Fonts: fix typing for disabled fallbacks (empty array)
Documentation says:
> To disable fallback fonts completely, configure an empty array:
>
> fallbacks: []
But I get a Typescript error if I do that. This is a simple typing issue, not a behavioral one, so in this PR I am:
- fixing the type so an empty array is allowed, to match the doc
- adding a type test that fails before this change and succeeds after:
> test/types/define-config.ts:150:8 - error TS2322: Type '[]' is not assignable to type '[string, ...string[]]'.
> Source has 0 element(s) but target requires 1.
>
> 150 fallbacks: [],
> ~~~~~~~~~
Partially addresses https://github.com/withastro/astro/issues/13659
042ffc1
15 days ago
by altano0%
Merge branch 'main' into fonts-fix-fallbacks-type
00926a2
12 days ago
by florian-lefebvre