ct/fix-lazy-filter-on-write - Branch - vortex-data/vortex

Fix: dont do lazy filters on write

#6194Merged

Comparing

ct/fix-lazy-filter-on-write

(

4d13e23

) with

develop

(

68130ce

)

-30%

Improvement: 7

Regression: 10

Untouched: 1133

Skipped: 1334

No successful run was found on develop ( a8b9c0b) during the generation of this report, so 68130ce was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

2484 total

canonical_into_non_nullable[(10000, 10, 0.0)]

encodings/fastlanes/benches/canonicalize_bench.rs

-30%

195.5 µs278.7 µs

canonical_into_non_nullable[(10000, 1, 0.0)]

encodings/fastlanes/benches/canonicalize_bench.rs

-29%

25.7 µs36.1 µs

into_canonical_non_nullable[(10000, 10, 0.0)]

encodings/fastlanes/benches/canonicalize_bench.rs

-29%

201.6 µs282.3 µs

canonical_into_non_nullable[(10000, 10, 0.01)]

encodings/fastlanes/benches/canonicalize_bench.rs

-27%

222.6 µs305.8 µs

into_canonical_non_nullable[(10000, 10, 0.01)]

encodings/fastlanes/benches/canonicalize_bench.rs

-26%

229.2 µs309.1 µs

canonical_into_non_nullable[(10000, 1, 0.01)]

encodings/fastlanes/benches/canonicalize_bench.rs

-21%

32.2 µs40.9 µs

canonical_into_non_nullable[(10000, 10, 0.1)]

encodings/fastlanes/benches/canonicalize_bench.rs

-19%

382.1 µs471.4 µs

into_canonical_non_nullable[(10000, 10, 0.1)]

encodings/fastlanes/benches/canonicalize_bench.rs

-18%

385.1 µs471.5 µs

canonical_into_non_nullable[(10000, 1, 0.1)]

encodings/fastlanes/benches/canonicalize_bench.rs

-16%

48 µs56.8 µs

into_canonical_nullable[(10000, 10, 0.1)]

encodings/fastlanes/benches/canonicalize_bench.rs

-12%

632 µs719.1 µs

into_canonical_non_nullable[(10000, 1, 0.0)]

encodings/fastlanes/benches/canonicalize_bench.rs

+22%

40.4 µs33.1 µs

into_canonical_nullable[(10000, 10, 0.0)]

encodings/fastlanes/benches/canonicalize_bench.rs

+18%

540.8 µs458.1 µs

into_canonical_non_nullable[(10000, 1, 0.01)]

encodings/fastlanes/benches/canonicalize_bench.rs

+18%

46.3 µs39.2 µs

into_canonical_nullable[(10000, 100, 0.0)]

encodings/fastlanes/benches/canonicalize_bench.rs

+17%

5.1 ms4.3 ms

canonical_into_nullable[(10000, 100, 0.0)]

encodings/fastlanes/benches/canonicalize_bench.rs

+14%

5 ms4.3 ms

into_canonical_nullable[(10000, 100, 0.1)]

encodings/fastlanes/benches/canonicalize_bench.rs

+14%

6.9 ms6.1 ms

into_canonical_non_nullable[(10000, 1, 0.1)]

encodings/fastlanes/benches/canonicalize_bench.rs

+14%

62.8 µs55.3 µs

set_indices_vortex_buffer[128]

vortex-buffer/benches/vortex_bitbuffer.rs

+5%

1.3 µs1.3 µs

binary_search_vortex

vortex-array/benches/search_sorted.rs

+3%

909.7 ns880.6 ns

true_count_vortex_buffer[128]

vortex-buffer/benches/vortex_bitbuffer.rs

+3%

1.1 µs1.1 µs

into_canonical_non_nullable[(10000, 1000, 0.0)]

encodings/fastlanes/benches/canonicalize_bench.rs

+3%

27.7 ms27 ms

take_map[(0.05, 0.5)]

vortex-array/benches/take_patches.rs

+3%

1.7 ms1.7 ms

null_count_run_end[(10000, 256, 0.01)]

encodings/runend/benches/run_end_null_count.rs

+3%

3.5 µs3.5 µs

null_count_run_end[(100000, 1024, 0.01)]

encodings/runend/benches/run_end_null_count.rs

+3%

3.5 µs3.5 µs

null_count_run_end[(10000, 1024, 0.01)]

encodings/runend/benches/run_end_null_count.rs

+3%

3.6 µs3.5 µs

Commits

Click on a commit to change the comparison range

Base

develop

68130ce

-29.85%

dont do lazy filters on write

8c2caa3

7 hours ago

by connortsui20

fix incorrect tests

4d13e23

6 hours ago

by connortsui20

Home Terms Privacy Docs