WIP: Enable needles-pass-by-value lint
#6778Comparing
adamg/needless-pass-by-value
(3ab051c
) withdevelop
(df23c37
)+26%
- Improvement
- 5
- Untouched
- 975
- Skipped
- 1466
Benchmarks
2446 total
decompress_rd[f32, 100000]
encodings/alp/benches/alp_compress.rs+26%
1.9 ms1.5 ms
decompress_rd[f64, 100000]
encodings/alp/benches/alp_compress.rs+21%
2.3 ms1.9 ms
decompress_rd[f64, 10000]
encodings/alp/benches/alp_compress.rs+18%
262.1 µs221.7 µs
decompress_rd[f32, 10000]
encodings/alp/benches/alp_compress.rs+18%
256.1 µs217 µs
alp_rd_decompress_f64
vortex/benches/single_encoding_throughput.rs+17%
27.4 ms23.5 ms
map_each[BufferMut<i32>, 128]
vortex-buffer/benches/vortex_buffer.rs+7%
858.1 ns799.7 ns
bench_many_nulls[0.9]
vortex-array/benches/dict_unreferenced_mask.rs+7%
530 µs497.5 µs
bitwise_not_vortex_buffer_mut[128]
vortex-buffer/benches/vortex_bitbuffer.rs+6%
530.3 ns501.1 ns
bench_many_nulls[0.5]
vortex-array/benches/dict_unreferenced_mask.rs+5%
362 µs344.1 µs
set_indices_vortex_buffer[128]
vortex-buffer/benches/vortex_bitbuffer.rs+5%
1.3 µs1.2 µs
bitwise_not_vortex_buffer_mut[1024]
vortex-buffer/benches/vortex_bitbuffer.rs+4%
681.9 ns652.8 ns
null_count_run_end[(10000, 1024, 0.01)]
encodings/runend/benches/run_end_null_count.rs+4%
3.8 µs3.6 µs
null_count_run_end[(10000, 256, 0.01)]
encodings/runend/benches/run_end_null_count.rs+4%
3.8 µs3.6 µs
null_count_run_end[(100000, 1024, 0.01)]
encodings/runend/benches/run_end_null_count.rs+4%
3.8 µs3.6 µs
decode_primitives[u8, (1000, 2)]
vortex-array/benches/dict_compress.rs+4%
24.8 µs23.9 µs
bitwise_not_vortex_buffer_mut[2048]
vortex-buffer/benches/vortex_bitbuffer.rs+4%
846.9 ns817.8 ns
true_count_vortex_buffer[128]
vortex-buffer/benches/vortex_bitbuffer.rs+3%
1.1 µs1 µs
true_count_vortex_buffer[1024]
vortex-buffer/benches/vortex_bitbuffer.rs+3%
1.2 µs1.1 µs
struct_small
vortex-array/benches/listview_rebuild.rs+2%
79.8 µs77.9 µs
chunked_dict_primitive_into_canonical[f32, (1000, 10, 100)]
vortex-array/benches/chunked_dict_builder.rs+2%
939.8 µs918 µs
i32_small_overlapping
vortex-array/benches/listview_rebuild.rs+2%
69.2 µs67.7 µs
true_count_vortex_buffer[2048]
vortex-buffer/benches/vortex_bitbuffer.rs+2%
1.3 µs1.3 µs
slice_vortex_buffer[1024]
vortex-buffer/benches/vortex_bitbuffer.rs+2%
1.3 µs1.3 µs
slice_vortex_buffer[2048]
vortex-buffer/benches/vortex_bitbuffer.rs+2%
1.3 µs1.3 µs
slice_vortex_buffer[65536]
vortex-buffer/benches/vortex_bitbuffer.rs+2%
1.3 µs1.3 µs
Commits
Click on a commit to change the comparison rangeBase
develop
df23c37
+26.25%
fixes
3ab051c
2 days ago
by AdamGS