andreacorbellini:comm-no-lock - Branch - uutils/coreutils

comm: hold the stdin lock for the whole duration of the program

#9085Merged

Comparing

andreacorbellini:comm-no-lock

(

35360f7

) with

main

(

514291d

)

-4%

Regressions: 1

Untouched: 104

Benchmarks

Failed

du_human_balanced_tree[(5, 4, 10)]

src/uu/du/benches/du_bench.rs

Regression

-4%

10.1 ms10.5 ms

Passed

sort_reverse_locale[500000]

src/uu/sort/benches/sort_bench.rs

+1%

363.1 ms361 ms

sort_ascii_only[500000]

src/uu/sort/benches/sort_bench.rs

354.8 ms353.1 ms

sort_unique_locale[500000]

src/uu/sort/benches/sort_bench.rs

483.4 ms482.4 ms

sort_german_c_locale

src/uu/sort/benches/sort_locale_bench.rs

39 ms39 ms

sort_unique_mixed

src/uu/sort/benches/sort_locale_bench.rs

39.2 ms39.2 ms

cp_preserve_metadata[(5, 4, 10)]

src/uu/cp/benches/cp_bench.rs

74.2 ms74.2 ms

du_all_wide_tree[(5000, 500)]

src/uu/du/benches/du_bench.rs

18.2 ms18.1 ms

b64_encode_synthetic

src/uu/base64/benches/base64_bench.rs

145.6 µs145.6 µs

mv_multiple_to_dir

src/uu/mv/benches/mv_bench.rs

13.1 ms13.1 ms

b64_decode_ignore_garbage_synthetic

src/uu/base64/benches/base64_bench.rs

149.9 µs149.8 µs

b64_decode_synthetic

src/uu/base64/benches/base64_bench.rs

149 µs149 µs

ls_recursive_long_all_deep_tree[(100, 4)]

src/uu/ls/benches/ls_bench.rs

3.2 ms3.2 ms

ls_recursive_long_all_balanced_tree[(6, 4, 15)]

src/uu/ls/benches/ls_bench.rs

139.8 ms139.8 ms

rm_single_file

src/uu/rm/benches/rm_bench.rs

106.9 ms106.9 ms

sort_mixed_utf8_locale

src/uu/sort/benches/sort_locale_bench.rs

38.9 ms38.9 ms

mv_single_file

src/uu/mv/benches/mv_bench.rs

131.3 ms131.3 ms

ls_recursive_long_all_wide_tree[(15000, 1500)]

src/uu/ls/benches/ls_bench.rs

148.7 ms148.7 ms

ls_recursive_deep_tree[(200, 2)]

src/uu/ls/benches/ls_bench.rs

2.1 ms2.1 ms

mv_force_overwrite

src/uu/mv/benches/mv_bench.rs

121.8 ms121.8 ms

ls_recursive_long_all_mixed_tree

src/uu/ls/benches/ls_bench.rs

4 ms4 ms

sort_dictionary_order[500000]

src/uu/sort/benches/sort_bench.rs

1.1 s1.1 s

wc_bytes_synthetic[500]

src/uu/wc/benches/wc_bench.rs

164 µs164 µs

cp_recursive_wide_tree[(6000, 800)]

src/uu/cp/benches/cp_bench.rs

188 ms188 ms

tsort_tree_dag[(10, 3)]

src/uu/tsort/benches/tsort_bench.rs

34.1 ms34.1 ms

sort_mixed_data[500000]

src/uu/sort/benches/sort_bench.rs

327.2 ms327.2 ms

hashsum_sha256

src/uu/hashsum/benches/hashsum_bench.rs

173.6 ms173.6 ms

tsort_linear_chain[1000000]

src/uu/tsort/benches/tsort_bench.rs

1.5 s1.5 s

cut_characters

src/uu/cut/benches/cut_bench.rs

7.5 ms7.5 ms

wc_lines_extreme_line_lengths[(100000, 200)]

src/uu/wc/benches/wc_bench.rs

1.6 ms1.6 ms

numfmt_to_si_precision[10000]

src/uu/numfmt/benches/numfmt_bench.rs

35.4 ms35.4 ms

split_numeric_suffix

src/uu/split/benches/split_bench.rs

6.1 ms6.1 ms

numfmt_to_iec[10000]

src/uu/numfmt/benches/numfmt_bench.rs

34 ms34 ms

mv_directory

src/uu/mv/benches/mv_bench.rs

3.1 ms3.1 ms

cut_bytes

src/uu/cut/benches/cut_bench.rs

8.4 ms8.4 ms

sort_case_insensitive[500000]

src/uu/sort/benches/sort_bench.rs

282.6 ms282.6 ms

expand_custom_tabstops[50000]

src/uu/expand/benches/expand_bench.rs

25.9 ms25.9 ms

hashsum_md5_check

src/uu/hashsum/benches/hashsum_bench.rs

32 ms32 ms

wc_lines_variable_length[(50, 500)]

src/uu/wc/benches/wc_bench.rs

3.4 ms3.4 ms

fold_many_lines[100000]

src/uu/fold/benches/fold_bench.rs

125.4 ms125.4 ms

fold_custom_width[50000]

src/uu/fold/benches/fold_bench.rs

46.6 ms46.6 ms

numfmt_large_numbers_si[10000]

src/uu/numfmt/benches/numfmt_bench.rs

34.5 ms34.5 ms

numfmt_padding[(10000, 50)]

src/uu/numfmt/benches/numfmt_bench.rs

47 ms47 ms

hashsum_md5

src/uu/hashsum/benches/hashsum_bench.rs

32 ms32 ms

numfmt_to_si[10000]

src/uu/numfmt/benches/numfmt_bench.rs

34 ms34 ms

cut_fields_tab

src/uu/cut/benches/cut_bench.rs

33.9 ms33.9 ms

nl_large_file[10]

src/uu/nl/benches/nl_bench.rs

100.8 ms100.8 ms

numfmt_round_modes[("towards-zero", 10000)]

src/uu/numfmt/benches/numfmt_bench.rs

34.5 ms34.5 ms

sort_key_field[500000]

src/uu/sort/benches/sort_bench.rs

716.9 ms716.9 ms

numfmt_round_modes[("up", 10000)]

src/uu/numfmt/benches/numfmt_bench.rs

32.8 ms32.8 ms

wc_words_large_line_count[100000]

src/uu/wc/benches/wc_bench.rs

43.8 ms43.8 ms

hashsum_sha256_check

src/uu/hashsum/benches/hashsum_bench.rs

173.6 ms173.6 ms

cut_fields_custom_delim

src/uu/cut/benches/cut_bench.rs

40.5 ms40.5 ms

hashsum_sha512

src/uu/hashsum/benches/hashsum_bench.rs

111.7 ms111.7 ms

wc_bytes_lines_synthetic[2000]

src/uu/wc/benches/wc_bench.rs

120.2 ms120.2 ms

wc_words_synthetic[2000]

src/uu/wc/benches/wc_bench.rs

10.3 s10.3 s

sort_numeric[500000]

src/uu/sort/benches/sort_bench.rs

1.2 s1.2 s

wc_default_large_line_count[100000]

src/uu/wc/benches/wc_bench.rs

48.9 ms48.9 ms

unexpand_large_file[10]

src/uu/unexpand/benches/unexpand_bench.rs

548 ms548 ms

expand_many_lines[100000]

src/uu/expand/benches/expand_bench.rs

100.9 ms100.9 ms

sort_accented_data[500000]

src/uu/sort/benches/sort_bench.rs

361.9 ms361.9 ms

unexpand_many_lines[100000]

src/uu/unexpand/benches/unexpand_bench.rs

261.4 ms261.4 ms

numfmt_round_modes[("down", 10000)]

src/uu/numfmt/benches/numfmt_bench.rs

34.6 ms34.6 ms

numfmt_from_si[10000]

src/uu/numfmt/benches/numfmt_bench.rs

33.2 ms33.2 ms

nl_many_lines[100000]

src/uu/nl/benches/nl_bench.rs

79.7 ms79.7 ms

sort_case_sensitive[500000]

src/uu/sort/benches/sort_bench.rs

173.7 ms173.7 ms

seq_formatted

src/uu/seq/benches/seq_bench.rs

99.7 ms99.7 ms

rm_recursive_tree

src/uu/rm/benches/rm_bench.rs

13.8 ms13.8 ms

sort_german_locale

src/uu/sort/benches/sort_locale_bench.rs

39 ms39 ms

seq_custom_separator

src/uu/seq/benches/seq_bench.rs

29.2 ms29.2 ms

sort_ascii_c_locale

src/uu/sort/benches/sort_locale_bench.rs

22.5 ms22.5 ms

seq_integers

src/uu/seq/benches/seq_bench.rs

26.7 ms26.7 ms

seq_with_step

src/uu/seq/benches/seq_bench.rs

13.6 ms13.6 ms

sort_mixed_c_locale

src/uu/sort/benches/sort_locale_bench.rs

38.9 ms38.9 ms

ls_recursive_wide_tree[(10000, 1000)]

src/uu/ls/benches/ls_bench.rs

51.4 ms51.4 ms

sort_numeric

src/uu/sort/benches/sort_locale_bench.rs

23 ms23 ms

rm_multiple_files

src/uu/rm/benches/rm_bench.rs

2.2 ms2.2 ms

wc_lines_large_line_count[500000]

src/uu/wc/benches/wc_bench.rs

2.9 ms2.9 ms

split_bytes

src/uu/split/benches/split_bench.rs

500 µs500 µs

sort_ascii_utf8_locale

src/uu/sort/benches/sort_locale_bench.rs

44.3 ms44.3 ms

uniq_heavy_duplicates[10000]

src/uu/uniq/benches/uniq_bench.rs

1.9 ms1.9 ms

uniq_case_insensitive[10000]

src/uu/uniq/benches/uniq_bench.rs

1.7 ms1.7 ms

sort_reverse_mixed

src/uu/sort/benches/sort_locale_bench.rs

38.3 ms38.3 ms

uniq_with_count[10000]

src/uu/uniq/benches/uniq_bench.rs

1.8 ms1.8 ms

rm_force_files

src/uu/rm/benches/rm_bench.rs

2.1 ms2.1 ms

wc_chars_large_line_count[100000]

src/uu/wc/benches/wc_bench.rs

994.2 µs994.2 µs

ls_recursive_mixed_tree

src/uu/ls/benches/ls_bench.rs

1.4 ms1.4 ms

sort_long_line[160000]

src/uu/sort/benches/sort_bench.rs

1.9 ms1.9 ms

hashsum_sha1

src/uu/hashsum/benches/hashsum_bench.rs

72.5 ms72.5 ms

cp_large_file[16]

src/uu/cp/benches/cp_bench.rs

298 µs298 µs

tsort_wide_dag[100000]

src/uu/tsort/benches/tsort_bench.rs

135.5 ms135.5 ms

split_number_chunks

src/uu/split/benches/split_bench.rs

275 µs275 µs

ls_recursive_balanced_tree[(6, 4, 15)]

src/uu/ls/benches/ls_bench.rs

55.8 ms55.8 ms

split_lines

src/uu/split/benches/split_bench.rs

6 ms6 ms

du_deep_tree[(100, 3)]

src/uu/du/benches/du_bench.rs

1.1 ms1.1 ms

cp_recursive_balanced_tree[(5, 4, 10)]

src/uu/cp/benches/cp_bench.rs

71.6 ms71.6 ms

cp_recursive_deep_tree[(120, 4)]

src/uu/cp/benches/cp_bench.rs

13.3 ms13.3 ms

tsort_complex_dag[50000]

src/uu/tsort/benches/tsort_bench.rs

83.7 ms83.7 ms

cp_archive_balanced_tree[(5, 4, 10)]

src/uu/cp/benches/cp_bench.rs

76.9 ms77 ms

du_wide_tree[(5000, 500)]

src/uu/du/benches/du_bench.rs

11.3 ms11.3 ms

du_all_balanced_tree[(4, 3, 10)]

src/uu/du/benches/du_bench.rs

1.6 ms1.6 ms

tsort_input_parsing_heavy[5000]

src/uu/tsort/benches/tsort_bench.rs

121.7 ms122.2 ms

du_summarize_balanced_tree[(5, 4, 10)]

src/uu/du/benches/du_bench.rs

-1%

8.4 ms8.5 ms

du_balanced_tree[(5, 4, 10)]

src/uu/du/benches/du_bench.rs

-2%

9.1 ms9.3 ms

du_max_depth_balanced_tree[(6, 4, 10)]

src/uu/du/benches/du_bench.rs

-2%

32.4 ms33 ms

Commits

Click on a commit to change the comparison range

Base

main

514291d

-3.86%

comm: hold the stdin lock for the whole duration of the program Being a single-threaded program, there's no benefit in having comm obtain a lock every time it needs to read a line. This commit removes the unnecessary overhead by obtaining a lock at the start of the program and keeping it for the whole duration of the program.

35360f7

2 months ago

by andreacorbellini

Home Terms Privacy Docs