fix: accumulated values lost when reused tracked fn skips re-execution
#1099Comparing
SAY-5:fix-accumulator-wrongresult-issue-923
(16ab655
) withmaster
(7e77c49
)+11%
- Improvement
- 1
- Untouched
- 25
Benchmarks
26 total
amortized[InternedInput]
benches/compare.rs::benches::inputs::Mutating Inputs+11%
2.1 µs1.9 µs
amortized[Input]
benches/compare.rs::benches::inputs::Mutating Inputs+4%
2.1 µs2 µs
new[InternedInput]
benches/compare.rs::benches::inputs::Mutating Inputs+4%
4.7 µs4.5 µs
accumulator
benches/accumulator.rs::benches::accumulator0%
3.2 ms3.2 ms
accumulator
benches/accumulator.rs::benches::accumulator0%
658.4 KB658.4 KB
new[SupertypeInput]
benches/compare.rs::benches::inputs::Mutating Inputs0%
165 B165 B
mutating[10]
benches/compare.rs::benches::mutating_inputs::Mutating Inputs0%
710 B710 B
new[InternedInput]
benches/compare.rs::benches::inputs::Mutating Inputs0%
13 B13 B
new[Input]
benches/compare.rs::benches::inputs::Mutating Inputs0%
97 B97 B
mutating[20]
benches/compare.rs::benches::mutating_inputs::Mutating Inputs0%
840 B840 B
mutating[30]
benches/compare.rs::benches::mutating_inputs::Mutating Inputs0%
970 B970 B
converge_diverge
benches/dataflow.rs::benches::dataflow0%
9.8 KB9.8 KB
converge_diverge_nested
benches/dataflow.rs::benches::nested0%
12.7 KB12.7 KB
converge_diverge_nested
benches/dataflow.rs::benches::nested0%
130.5 µs130.8 µs
converge_diverge
benches/dataflow.rs::benches::dataflow0%
166.4 µs167 µs
mutating[30]
benches/compare.rs::benches::mutating_inputs::Mutating Inputs-1%
14.7 µs14.8 µs
mutating[20]
benches/compare.rs::benches::mutating_inputs::Mutating Inputs-1%
14.5 µs14.5 µs
mutating[10]
benches/compare.rs::benches::mutating_inputs::Mutating Inputs-1%
14.6 µs14.7 µs
amortized[SupertypeInput]
benches/compare.rs::benches::inputs::Mutating Inputs-1%
2.7 µs2.7 µs
new[SupertypeInput]
benches/compare.rs::benches::inputs::Mutating Inputs-1%
15.9 µs16.1 µs
new[Input]
benches/compare.rs::benches::inputs::Mutating Inputs-1%
9.7 µs9.8 µs
many_tracked_structs
benches/incremental.rs::benches::many_tracked_structs-3%
8.3 µs8.5 µs
amortized[SupertypeInput]
benches/compare.rs::benches::inputs::Mutating InputsN/A
0 B0 B
amortized[InternedInput]
benches/compare.rs::benches::inputs::Mutating InputsN/A
0 B0 B
many_tracked_structs
benches/incremental.rs::benches::many_tracked_structsN/A
0 B0 B
Commits
Click on a commit to change the comparison rangeBase
master
7e77c49
+10.65%
fix accumulator wrongly skipped when tracked fn reused without re-execute
16ab655
1 day ago
by SAY-5