BlogDocs

chore: Remove unused variables and enable no-unused-vars rule(#18584)

Merged
Merging
fix/no-unused-vars
into
main
-52%
IMPROVEMENTS
1
REGRESSIONS
1
UNTOUCHED
1
NEW
0
DROPPED
0
IGNORED
0

Benchmarks

Failing

typescript compilation ~50 ModelsRegression
packages/client/src/__tests__/benchmarks/huge-schema/huge-schema.bench.ts::typescript::typescript compilation ~50 Models
-52%
14.9 ms
31 ms

Passing

client generation ~50 Models
packages/client/src/__tests__/benchmarks/huge-schema/huge-schema.bench.ts::typescript::client generation ~50 Models
+34%
1.6 s
1.2 s
client generation 100 models with relations
packages/client/src/__tests__/benchmarks/lots-of-relations/lots-of-relations.bench.ts::typescript::client generation 100 models with relations
+1%
11.9 s
11.8 s

Commits

Click on a commit to change the comparison range
base
main
1a0fbfa
+36%
chore: Remove unused variables and enable no-unused-vars rule Enables `@typesctipt-eslint/no-unused-vars` and fixes all violations. There are a couple of exceptions to the rule: 1. Spreads are ignored, making it possible to omit a property with object spread operator, i.e. this code valid: ```ts const { propToOmit, ...rest } = someObject ``` 2. In some cases, we want to have a function argument that won't be used in the function body. Main use-case for this is TS inference tests. In that case, argument may be prefixed with `_` and the rule won't trigger.
82320ac
a year ago by SevInf
+4%
Update snapshots
97ec810
a year ago by SevInf
-128%
Update more snapshots
c7dc5be
a year ago by SevInf
+64%
Add comments
85ecd9a
a year ago by SevInf
-29%
Add comments
a0555b8
a year ago by SevInf
ResourcesHomePricingDocsBlogGitHub
Copyright © 2024 CodSpeed Technology SAS. All rights reserved.