fix(client): request a free port from the engine(#19057)

Merged
Merging
fix/engine-auto-port
into
main
+22%
IMPROVEMENTS
0
REGRESSIONS
0
UNTOUCHED
3
NEW
0
DROPPED
0

Benchmarks

client generation ~50 Models
packages/client/src/__tests__/benchmarks/huge-schema/huge-schema.bench.ts::typescript::client generation ~50 Models
+6%
6.5 s
6.1 s
typescript compilation ~50 Models
packages/client/src/__tests__/benchmarks/huge-schema/huge-schema.bench.ts::typescript::typescript compilation ~50 Models
+22%
74.2 ms
60.7 ms
client generation 100 models with relations
packages/client/src/__tests__/benchmarks/lots-of-relations/lots-of-relations.bench.ts::typescript::client generation 100 models with relations
+12%
46.8 s
41.6 s

Commits

Click on a commit to change the comparison range
refactor: remove unimplemented `all-exist` test from packages/engines (#18453) * refactor: remove unimplemented `all-exist` test from packages/engines The functionality that it was probably attempting to test judging from its name is already tested elsewhere (we have relevant tests in `fetch-engine` and `internals`). * fix: allow no tests
base
bc420dc
7 months ago by aqrln
+22%
fix(client): request a free port from the engine Follow-up to https://github.com/prisma/prisma-engines/pull/3939 Pushing this functionality to the engine side prevents the possibility of some other server grabbing the free port between the time a free port was found on the client side and the server is bound on the engine side. Asking the kernel for a free port and binding the server to that port needs to happen as a single indivisible operation. See the referenced PR description for additional details. An example of a recent failure on CI today due to this issue: https://github.com/prisma/prisma/actions/runs/4871460934/jobs/8688448247
e17e39b
7 months ago by aqrln
ResourcesHomePricingDocsBlogGitHub
Copyright © 2023 CodSpeed Technology SAS. All rights reserved.