Avatar for the prisma user
prisma
prisma
BlogDocs

fix(client): request a free port from the engine

#19057Merged
Comparing
fix/engine-auto-port
(
e17e39b
) with
main
(
bc420dc
)
+21%
Improvements
1
Regressions
0
Untouched
2
New
0
Dropped
0
Ignored
0

Benchmarks

Improved

typescript compilation ~50 Models
packages/client/src/__tests__/benchmarks/huge-schema/huge-schema.bench.ts::typescript::typescript compilation ~50 Models
+21%
15.7 ms
12.9 ms

Passed

client generation 100 models with relations
packages/client/src/__tests__/benchmarks/lots-of-relations/lots-of-relations.bench.ts::typescript::client generation 100 models with relations
+12%
9.3 s
8.3 s
client generation ~50 Models
packages/client/src/__tests__/benchmarks/huge-schema/huge-schema.bench.ts::typescript::client generation ~50 Models
+6%
1.3 s
1.2 s

Commits

Click on a commit to change the comparison range
Base
main
bc420dc
+21%
fix(client): request a free port from the engine Follow-up to https://github.com/prisma/prisma-engines/pull/3939 Pushing this functionality to the engine side prevents the possibility of some other server grabbing the free port between the time a free port was found on the client side and the server is bound on the engine side. Asking the kernel for a free port and binding the server to that port needs to happen as a single indivisible operation. See the referenced PR description for additional details. An example of a recent failure on CI today due to this issue: https://github.com/prisma/prisma/actions/runs/4871460934/jobs/8688448247
e17e39b
2 years ago
by aqrln
Home Terms PrivacyDocs