larseggert:fix-rejected_extended_connect - Branch - mozilla/neqo

fix: Reject invalid extended CONNECT requests

#3385

Comparing

larseggert:fix-rejected_extended_connect

(

bb45ecf

) with

main

(

1c30ced

)

Untouched: 38

Skipped: 8

Benchmarks

46 total

coalesce_acked_from_zero 1000+1 entries

neqo-transport/benches/range_tracker.rs::benches::benchmark_coalesce

+2%

2.7 µs2.6 µs

walltime/1000-streams/each-1-bytes

neqo-http3/benches/streams_walltime.rs::benches::benchmark::streams

+1%

30 ms29.5 ms

1-conn/1-100mb-req (aka. Upload)

neqo-bin/benches/main.rs::benches::transfer::transfer

+1%

564.3 ms558.8 ms

walltime/1000-streams/each-1000-bytes

neqo-http3/benches/streams_walltime.rs::benches::benchmark::streams

+1%

141.3 ms140.2 ms

walltime/1000-streams/each-1000-bytes

neqo-http3/benches/streams_walltime.rs::benches::benchmark::streams

+1%

874.8 KB869.6 KB

walltime/1-streams/each-1000-bytes

neqo-http3/benches/streams_walltime.rs::benches::benchmark::streams

1.4 ms1.4 ms

1-conn/1-100mb-resp (aka. Download)

neqo-bin/benches/main.rs::benches::transfer::transfer

422.1 ms421.3 ms

decode 4096 bytes, mask 3f

neqo-common/benches/decoder.rs::benches::benchmark_decoder

45.4 µs45.4 µs

walltime/1-streams/each-1000-bytes

neqo-http3/benches/streams_walltime.rs::benches::benchmark::streams

24.6 KB24.6 KB

inbound_frame()

neqo-transport/benches/rx_stream_orderer.rs::benches::criterion_benchmark::RxStreamOrderer

124.3 ms124.3 ms

decode 1048576 bytes, mask 3f

neqo-common/benches/decoder.rs::benches::benchmark_decoder

11.5 ms11.5 ms

coalesce_acked_from_zero 1+1 entries

neqo-transport/benches/range_tracker.rs::benches::benchmark_coalesce

2.9 µs2.9 µs

inbound_frame()

neqo-transport/benches/rx_stream_orderer.rs::benches::criterion_benchmark::RxStreamOrderer

160.9 MB160.9 MB

decode 4096 bytes, mask ff

neqo-common/benches/decoder.rs::benches::benchmark_decoder

26.4 µs26.4 µs

decode 1048576 bytes, mask 7f

neqo-common/benches/decoder.rs::benches::benchmark_decoder

9.6 ms9.6 ms

decode 1048576 bytes, mask ff

neqo-common/benches/decoder.rs::benches::benchmark_decoder

6.7 ms6.7 ms

decode 4096 bytes, mask 7f

neqo-common/benches/decoder.rs::benches::benchmark_decoder

37.8 µs37.8 µs

take_ranges

neqo-transport/benches/sent_packets.rs::benches::take_ranges::sent::Packets

12.5 KB12.5 KB

take_ranges

neqo-transport/benches/sent_packets.rs::benches::take_ranges::sent::Packets

29.6 µs29.7 µs

coalesce_acked_from_zero 10+1 entries

neqo-transport/benches/range_tracker.rs::benches::benchmark_coalesce

-1%

3.1 µs3.1 µs

coalesce_acked_from_zero 3+1 entries

neqo-transport/benches/range_tracker.rs::benches::benchmark_coalesce

-1%

3.1 µs3.1 µs

walltime/1000-streams/each-1-bytes

neqo-http3/benches/streams_walltime.rs::benches::benchmark::streams

-1%

705.3 KB712.9 KB

1-conn/10_000-parallel-1b-resp (aka. RPS)

neqo-bin/benches/main.rs::benches::transfer::transfer

-1%

576.8 ms583 ms

1-conn/1-1b-resp (aka. HPS)

neqo-bin/benches/main.rs::benches::transfer::transfer

-2%

55.7 ms56.8 ms

walltime/pacing-false/varying-seeds

neqo-transport/benches/transfer_walltime.rs::transfer::benchmark::transfer

-2%

95.5 ms97.6 ms

Commits

Click on a commit to change the comparison range

Base

main

378c365

-4.61%

fix: Reject invalid extended CONNECT requests

6a661eb

12 days ago

by larseggert

+1.59%

Merge branch 'main' into fix-rejected_extended_connect

2f4fd3b

6 days ago

by larseggert

-0.33%

Address review comments

fb83495

6 days ago

by larseggert

-1.66%

Revamp

4a3a724

6 days ago

by larseggert

+5.06%

Merge branch 'main' into fix-rejected_extended_connect

1f1998f

4 days ago

by larseggert

-0.37%

Suggestions from @martinthomson

bb45ecf

3 days ago

by larseggert

-6.64%

Merge branch 'main' into fix-rejected_extended_connect

95e4fe8

2 days ago

by larseggert

Home Terms Privacy Docs