qizwiz:fix-chatprompttemplate-save - Branch - langchain-ai/langchain

fix(core): Enable save method for `ChatPromptTemplate` by removing `NotImplementedError` override

#32997Closed

Comparing

qizwiz:fix-chatprompttemplate-save

(

d1cdb00

) with

master

(

cc9a97a

)

-5%

Untouched: 13

Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data. For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

No successful run was found on master ( d5ba5d3) during the generation of this report, so cc9a97a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Passed

test_import_time[InMemoryRateLimiter]

libs/core/tests/benchmarks/test_imports.py

-3%

161.5 ms167.3 ms

test_import_time[LangChainTracer]

libs/core/tests/benchmarks/test_imports.py

-4%

415.6 ms431 ms

test_import_time[CallbackManager]

libs/core/tests/benchmarks/test_imports.py

-4%

433.4 ms450.7 ms

test_import_time[BaseChatModel]

libs/core/tests/benchmarks/test_imports.py

-4%

508.5 ms529 ms

test_import_time[Runnable]

libs/core/tests/benchmarks/test_imports.py

-4%

463.9 ms484.2 ms

test_async_callbacks_in_sync

libs/core/tests/benchmarks/test_async_callbacks.py

-4%

23.5 ms24.5 ms

test_import_time[RunnableLambda]

libs/core/tests/benchmarks/test_imports.py

-5%

464.1 ms486.4 ms

test_import_time[tool]

libs/core/tests/benchmarks/test_imports.py

-5%

492.9 ms516.7 ms

test_import_time[Document]

libs/core/tests/benchmarks/test_imports.py

-5%

204 ms214.2 ms

test_import_time[PydanticOutputParser]

libs/core/tests/benchmarks/test_imports.py

-5%

525.7 ms553.8 ms

test_import_time[ChatPromptTemplate]

libs/core/tests/benchmarks/test_imports.py

-5%

587.1 ms620.6 ms

test_import_time[HumanMessage]

libs/core/tests/benchmarks/test_imports.py

-5%

205.6 ms217.5 ms

test_import_time[InMemoryVectorStore]

libs/core/tests/benchmarks/test_imports.py

-6%

587.8 ms625.5 ms

Commits

Click on a commit to change the comparison range

Base

master

cc9a97a

-4.56%

fix: Enable save method for ChatPromptTemplate by removing NotImplementedError override This PR fixes Issue #32637 where ChatPromptTemplate's save method was raising NotImplementedError instead of inheriting the working implementation from BasePromptTemplate. The fix removes the override that was preventing inheritance of the parent class's functional save method, allowing ChatPromptTemplate instances to be saved to JSON/YAML files as expected. Fixes #32637

d1cdb00

2 months ago

by qizwiz

Home Terms Privacy Docs