nathannewyen:fix/34168-tool-call-id-callback - Branch - langchain-ai/langchain

fix(core): pass `tool_call_id` to `on_tool_start` callback

#34235Merged

Comparing

nathannewyen:fix/34168-tool-call-id-callback

(

3c2c8d0

) with

master

(

a64aee3

)

-4%

Untouched: 13

Skipped: 21

Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data. For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Benchmarks

Skipped (21)

Passed

test_import_time[CallbackManager]

libs/core/tests/benchmarks/test_imports.py

-3%

457.1 ms469.2 ms

test_async_callbacks_in_sync

libs/core/tests/benchmarks/test_async_callbacks.py

-3%

23.7 ms24.4 ms

test_import_time[PydanticOutputParser]

libs/core/tests/benchmarks/test_imports.py

-3%

529.2 ms546.5 ms

test_import_time[InMemoryVectorStore]

libs/core/tests/benchmarks/test_imports.py

-3%

608.7 ms629.8 ms

test_import_time[HumanMessage]

libs/core/tests/benchmarks/test_imports.py

-4%

261.4 ms271.9 ms

test_import_time[Document]

libs/core/tests/benchmarks/test_imports.py

-4%

184.1 ms191.6 ms

test_import_time[LangChainTracer]

libs/core/tests/benchmarks/test_imports.py

-4%

430.6 ms448.6 ms

test_import_time[tool]

libs/core/tests/benchmarks/test_imports.py

-4%

509.9 ms531.9 ms

test_import_time[InMemoryRateLimiter]

libs/core/tests/benchmarks/test_imports.py

-5%

172 ms180.3 ms

test_import_time[Runnable]

libs/core/tests/benchmarks/test_imports.py

-5%

487.3 ms510.9 ms

test_import_time[RunnableLambda]

libs/core/tests/benchmarks/test_imports.py

-5%

484.2 ms509.9 ms

test_import_time[BaseChatModel]

libs/core/tests/benchmarks/test_imports.py

-6%

522.3 ms552.9 ms

test_import_time[ChatPromptTemplate]

libs/core/tests/benchmarks/test_imports.py

-6%

592.7 ms627.7 ms

Commits

Click on a commit to change the comparison range

Base

master

a64aee3

-2.03%

fix(core): pass tool_call_id to on_tool_start callback When invoking a tool with a ToolCall, the tool_call_id was extracted but not forwarded to callback handlers in on_tool_start. This made it impossible for callback handlers to correlate tool executions with the original LLM tool calls. This fix adds tool_call_id parameter to both sync run() and async arun() methods' on_tool_start calls. Fixes #34168

5a5a8c0

4 days ago

by nathannewyen

+1.04%

Merge branch 'master' into fix/34168-tool-call-id-callback

75fff35

2 days ago

by mdrxy

-3.1%

Merge branch 'fix/34168-tool-call-id-callback' of github.com:nathannewyen/langchain into pr/nathannewyen/34235

3c2c8d0

2 days ago

by mdrxy

Home Terms Privacy Docs