cwarre33:fix-chat-prompt-template-save-32637 - Branch - langchain-ai/langchain

fix(core): implement ChatPromptTemplate.save() method (#32637)

#33631

Comparing

cwarre33:fix-chat-prompt-template-save-32637

(

e00f3ff

) with

master

(

5acd34a

)

+11%

Improvements: 1

Untouched: 12

Skipped: 21

Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data. For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

No successful run was found on master ( f8adbbc) during the generation of this report, so 5acd34a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Skipped (21)

Improved

test_import_time[BaseChatModel]

libs/core/tests/benchmarks/test_imports.py

+11%

562.3 ms*506.3 ms

Passed

test_import_time[tool]

libs/core/tests/benchmarks/test_imports.py

+10%

548.2 ms*498.6 ms

test_import_time[Document]

libs/core/tests/benchmarks/test_imports.py

+8%

198.4 ms*183.5 ms

test_import_time[CallbackManager]

libs/core/tests/benchmarks/test_imports.py

+7%

474.5 ms*442 ms

test_import_time[Runnable]

libs/core/tests/benchmarks/test_imports.py

+7%

509.6 ms*476 ms

test_import_time[ChatPromptTemplate]

libs/core/tests/benchmarks/test_imports.py

+7%

611 ms*572.1 ms

test_import_time[PydanticOutputParser]

libs/core/tests/benchmarks/test_imports.py

+5%

534.4 ms*510.3 ms

test_async_callbacks_in_sync

libs/core/tests/benchmarks/test_async_callbacks.py

+4%

24.7 ms*23.7 ms

test_import_time[InMemoryRateLimiter]

libs/core/tests/benchmarks/test_imports.py

+4%

177.9 ms*171.2 ms

test_import_time[HumanMessage]

libs/core/tests/benchmarks/test_imports.py

+4%

270.1 ms*260 ms

test_import_time[LangChainTracer]

libs/core/tests/benchmarks/test_imports.py

+3%

438.4 ms*424.2 ms

test_import_time[InMemoryVectorStore]

libs/core/tests/benchmarks/test_imports.py

+3%

608.5 ms*590.4 ms

test_import_time[RunnableLambda]

libs/core/tests/benchmarks/test_imports.py

+3%

486.7 ms*474.2 ms

Commits

Click on a commit to change the comparison range

Base

master

5acd34a

+11.07%

fix(core): implement ChatPromptTemplate.save() method (#32637) Remove NotImplementedError override in ChatPromptTemplate.save() to allow the parent BasePromptTemplate implementation to handle serialization. ChatPromptTemplate already has the required _prompt_type property ('chat') for proper serialization. This enables users to save and load ChatPromptTemplate instances to/from YAML and JSON files, matching the functionality of PromptTemplate and FewShotPromptTemplate. Changes: - Remove NotImplementedError override from ChatPromptTemplate.save() - Add comprehensive test for save/load roundtrip with both YAML and JSON formats Fixes #32637

e00f3ff

2 days ago

Home Terms Privacy Docs