Mr-Neutr0n:fix/url-encode-mermaid-bgcolor - Branch - langchain-ai/langchain

fix(core): URL-encode bgColor parameter in mermaid.ink API calls

#34466

Comparing

Mr-Neutr0n:fix/url-encode-mermaid-bgcolor

(

7541251

) with

master

(

75b07b3

)

Untouched: 13

Skipped: 21

Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data. For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Benchmarks

Skipped (21)

Passed

test_import_time[LangChainTracer]

libs/core/tests/benchmarks/test_imports.py

+3%

480 ms467 ms

test_import_time[tool]

libs/core/tests/benchmarks/test_imports.py

+2%

555.8 ms545.1 ms

test_import_time[HumanMessage]

libs/core/tests/benchmarks/test_imports.py

+1%

273.9 ms270.5 ms

test_import_time[InMemoryRateLimiter]

libs/core/tests/benchmarks/test_imports.py

+1%

186 ms183.7 ms

test_import_time[ChatPromptTemplate]

libs/core/tests/benchmarks/test_imports.py

646.1 ms644.5 ms

test_import_time[PydanticOutputParser]

libs/core/tests/benchmarks/test_imports.py

582.7 ms581.7 ms

test_import_time[RunnableLambda]

libs/core/tests/benchmarks/test_imports.py

540.6 ms541.5 ms

test_import_time[BaseChatModel]

libs/core/tests/benchmarks/test_imports.py

-1%

574.2 ms579.7 ms

test_import_time[CallbackManager]

libs/core/tests/benchmarks/test_imports.py

-1%

482 ms488.1 ms

test_async_callbacks_in_sync

libs/core/tests/benchmarks/test_async_callbacks.py

-2%

24.4 ms24.8 ms

test_import_time[Document]

libs/core/tests/benchmarks/test_imports.py

-2%

196.2 ms199.9 ms

test_import_time[Runnable]

libs/core/tests/benchmarks/test_imports.py

-2%

533.9 ms545.1 ms

test_import_time[InMemoryVectorStore]

libs/core/tests/benchmarks/test_imports.py

-4%

660.5 ms684.7 ms

Commits

Click on a commit to change the comparison range

Base

master

75b07b3

-0.29%

fix(core): URL-encode bgColor parameter in mermaid.ink API calls (#34444) The background_color parameter was not being URL-encoded when building the mermaid.ink API URL. Named colors like 'white' get prefixed with '!' which is a special character that must be URL-encoded as '%21' to avoid HTTP 400 errors from the mermaid.ink API. Changes: - Import urllib.parse for URL encoding - URL-encode the background_color value using urllib.parse.quote() - Add unit tests for both named colors and hex colors Fixes #34444

7541251

3 hours ago

by MrNeutron

Home Terms Privacy Docs