Peter-The-Great:fix/markusershellpath - Branch - fox-it/dissect.target

Fix UnixUserRecord shell field type from string to path

#1260

Comparing

Peter-The-Great:fix/markusershellpath

(

9484751

) with

main

(

34557ac

)

Untouched: 8

No successful run was found on main ( b4473a6) during the generation of this report, so 34557ac was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Passed

test_benchmark_journal

tests/plugins/os/unix/log/test_journal.py

+1%

4.7 ms4.7 ms

test_benchmark[_data/loaders/acquire/test-windows-fs-c.zip-ZipLoader]

tests/loaders/test_acquire.py

1.9 ms1.9 ms

test_benchmark_find_needles

tests/helpers/test_scrape.py

59.5 µs59.6 µs

test_benchmark[_data/loaders/acquire/test-windows-fs-c-relative.tar-TarLoader]

tests/loaders/test_acquire.py

1.7 ms1.7 ms

test_benchmark[_data/loaders/uac/uac-2e44ea6da71d-linux-20250717143106.zip-ZipLoader]

tests/loaders/test_uac.py

17.9 ms17.9 ms

test_benchmark[_data/loaders/uac/uac-2e44ea6da71d-linux-20250717143111.tar.gz-TarLoader]

tests/loaders/test_uac.py

45.5 ms45.6 ms

test_benchmark_functions_compatible_check

tests/test_plugin.py

86.8 ms87.2 ms

test_benchmark_walkfs

tests/plugins/filesystem/test_walkfs.py

484.2 µs486.2 µs

Commits

Click on a commit to change the comparison range

Base

main

34557ac

+0.33%

Fix UnixUserRecord shell field type from string to path. #900 Made sure to change the field type of shell in UnixUserRecord from string to path. I also added a unit test, with a sanity check to make sure that the operation goes correctly as stated.

f95eecb

5 months ago

by Peter-The-Great

-0.39%

Remove redundant Unit Test mentioned in #900 #1260 Remove redundant UnixUserRecord shell type test and added a type assertion test to check if shell variable in user is a valid posix_path.

9484751

5 months ago

by Peter-The-Great

Home Terms Privacy Docs