yagiz/fix-byob-stream-handler - Branch - cloudflare/workerd

fix streams byob request handling after close for spec compliance

#5769

Comparing

yagiz/fix-byob-stream-handler

(

e60c1c6

) with

main

(

2e1cccc

)

Untouched: 68

Skipped: 38

Benchmarks

Skipped (38)

Passed

bodyWithHeaders[Response]

src/workerd/tests/bench-response.c++

+4%

25.4 µs24.5 µs

bm_Coro_Immediate

external/+http+capnp-cpp/src/kj/async-bench.c++

+1%

4.7 µs4.7 µs

bm_Http_FullProtocol

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

79.1 µs79 µs

bm_Http_OverCapnpFullRPC

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

237 µs236.6 µs

set_append[ApiHeaders]

src/workerd/tests/bench-api-headers.c++

11.7 ms11.7 ms

Encode_OneByte_1024[TextEncoder][0/1/1024]

src/workerd/tests/bench-text-encoder.c++

12 ms12 ms

bm_Http_ClientWrapper

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

35.9 µs35.8 µs

request[GlobalScopeBenchmark]

src/workerd/tests/bench-global-scope.c++

52.7 ms52.7 ms

EncodeInto_ASCII_1024[TextEncoder][1/0/1024]

src/workerd/tests/bench-text-encoder.c++

2.6 ms2.6 ms

Encode_ASCII_32[TextEncoder][0/0/32]

src/workerd/tests/bench-text-encoder.c++

3 ms3 ms

ParseAndSerialize

src/workerd/tests/bench-mimetype.c++::Mimetype

75 ms74.9 ms

EncodeInto_TwoByte_8192[TextEncoder][1/2/8192]

src/workerd/tests/bench-text-encoder.c++

96.7 ms96.7 ms

EncodeInto_ASCII_256[TextEncoder][1/0/256]

src/workerd/tests/bench-text-encoder.c++

2.6 ms2.6 ms

Test_JSON_ENC

src/workerd/tests/bench-json.c++

207 ms207 ms

constructor[ApiHeaders]

src/workerd/tests/bench-api-headers.c++

67.6 ms67.6 ms

Util_RecursivelyFreeze

src/workerd/tests/bench-util.c++

10.8 ms10.8 ms

EncodeInto_TwoByte_256[TextEncoder][1/2/256]

src/workerd/tests/bench-text-encoder.c++

5.4 ms5.4 ms

JsString_Utf8Length_Utf16_NonFlat_1024

src/workerd/tests/bench-jsstring.c++

16.1 µs16.1 µs

JsString_Utf8Length_Utf16_Invalid_NonFlat_8192

src/workerd/tests/bench-jsstring.c++

73.7 µs73.7 µs

JsString_Utf8Length_Utf16_NonFlat_256

src/workerd/tests/bench-jsstring.c++

8.8 µs8.8 µs

bm_Coro_CoAwait_ImmediateCoroutine

external/+http+capnp-cpp/src/kj/async-bench.c++

6.5 µs6.5 µs

Parse[KjHeaders]

src/workerd/tests/bench-kj-headers.c++

44.3 µs44.3 µs

JsString_Utf8Length_Utf16_NonFlat_8192

src/workerd/tests/bench-jsstring.c++

73.7 µs73.7 µs

bm_Promise_ReadyNow

external/+http+capnp-cpp/src/kj/async-bench.c++

2.1 µs2.1 µs

bm_Promise_Shift_20

external/+http+capnp-cpp/src/kj/async-bench.c++

10.8 µs10.8 µs

bm_Coro_CoAwait_ImmediatePromise

external/+http+capnp-cpp/src/kj/async-bench.c++

6.3 µs6.3 µs

JsString_Utf8Length_Latin1_Flat_1024

src/workerd/tests/bench-jsstring.c++

4.6 µs4.6 µs

JsString_Utf8Length_Utf16_Flat_1024

src/workerd/tests/bench-jsstring.c++

8.6 µs8.6 µs

JsString_Utf8Length_Latin1_Flat_256

src/workerd/tests/bench-jsstring.c++

1.7 µs1.7 µs

bm_Promise_Immediate

external/+http+capnp-cpp/src/kj/async-bench.c++

3.7 µs3.7 µs

JsString_Utf8Length_Latin1_NonFlat_256

src/workerd/tests/bench-jsstring.c++

7.9 µs7.9 µs

JsString_Utf8Length_Latin1_Flat_8192

src/workerd/tests/bench-jsstring.c++

31 µs31 µs

JsString_Utf8Length_Latin1_Flat_32

src/workerd/tests/bench-jsstring.c++

920.3 ns920.3 ns

JsString_Utf8Length_Latin1_NonFlat_1024

src/workerd/tests/bench-jsstring.c++

12.1 µs12.1 µs

JsString_Utf8Length_Latin1_NonFlat_8192

src/workerd/tests/bench-jsstring.c++

42 µs42 µs

JsString_Utf8Length_Utf16_Flat_256

src/workerd/tests/bench-jsstring.c++

2.7 µs2.7 µs

JsString_Utf8Length_Utf16_Flat_8192

src/workerd/tests/bench-jsstring.c++

62.9 µs62.9 µs

JsString_Utf8Length_Utf16_Invalid_NonFlat_1024

src/workerd/tests/bench-jsstring.c++

16.1 µs16.1 µs

JsString_Utf8Length_Utf16_Invalid_Flat_256

src/workerd/tests/bench-jsstring.c++

2.7 µs2.7 µs

JsString_Utf8Length_Utf16_Invalid_Flat_1024

src/workerd/tests/bench-jsstring.c++

8.6 µs8.6 µs

JsString_Utf8Length_Utf16_Invalid_Flat_8192

src/workerd/tests/bench-jsstring.c++

62.9 µs62.9 µs

JsString_Utf8Length_Utf16_Invalid_NonFlat_256

src/workerd/tests/bench-jsstring.c++

8.8 µs8.8 µs

EncodeInto_TwoByte_1024[TextEncoder][1/2/1024]

src/workerd/tests/bench-text-encoder.c++

14.2 ms14.2 ms

EncodeInto_OneByte_1024[TextEncoder][1/1/1024]

src/workerd/tests/bench-text-encoder.c++

10.5 ms10.5 ms

Serialize

src/workerd/tests/bench-mimetype.c++::Mimetype

74.6 ms74.6 ms

Encode_TwoByte_8192[TextEncoder][0/2/8192]

src/workerd/tests/bench-text-encoder.c++

146.1 ms146.1 ms

bm_Coro_Pow2_20

external/+http+capnp-cpp/src/kj/async-bench.c++

21.2 µs21.2 µs

Encode_OneByte_8192[TextEncoder][0/1/8192]

src/workerd/tests/bench-text-encoder.c++

84.7 ms84.7 ms

Test_JSON_DEC

src/workerd/tests/bench-json.c++

3.2 s3.2 s

Encode_TwoByte_1024[TextEncoder][0/2/1024]

src/workerd/tests/bench-text-encoder.c++

19.5 ms19.5 ms

Encode_OneByte_256[TextEncoder][0/1/256]

src/workerd/tests/bench-text-encoder.c++

5.2 ms5.2 ms

EncodeInto_OneByte_8192[TextEncoder][1/1/8192]

src/workerd/tests/bench-text-encoder.c++

66.7 ms66.7 ms

Encode_ASCII_8192[TextEncoder][0/0/8192]

src/workerd/tests/bench-text-encoder.c++

13.1 ms13.1 ms

bm_Coro_Shift_20

external/+http+capnp-cpp/src/kj/async-bench.c++

23.9 µs23.9 µs

jsonResponse[Response]

src/workerd/tests/bench-response.c++

34.9 µs35 µs

request[RegExpBenchmark]

src/workerd/tests/bench-regex.c++

7.3 ms7.3 ms

EncodeInto_OneByte_256[TextEncoder][1/1/256]

src/workerd/tests/bench-text-encoder.c++

4.5 ms4.5 ms

bm_Http_Baseline

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

11.6 µs11.6 µs

simpleStringBody[Response]

src/workerd/tests/bench-response.c++

21.7 µs21.7 µs

Encode_ASCII_256[TextEncoder][0/0/256]

src/workerd/tests/bench-text-encoder.c++

3.1 ms3.1 ms

Encode_TwoByte_256[TextEncoder][0/2/256]

src/workerd/tests/bench-text-encoder.c++

7 ms7 ms

nullBodyWithStatus[Response]

src/workerd/tests/bench-response.c++

10.2 µs10.2 µs

bm_Promise_Pow2_20

external/+http+capnp-cpp/src/kj/async-bench.c++

9.9 µs9.9 µs

bm_Http_OverCapnpLocalCall

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

127.9 µs128.3 µs

arrayBufferBody[Response]

src/workerd/tests/bench-response.c++

17.5 µs17.6 µs

EncodeInto_ASCII_8192[TextEncoder][1/0/8192]

src/workerd/tests/bench-text-encoder.c++

3.4 ms3.4 ms

Encode_ASCII_1024[TextEncoder][0/0/1024]

src/workerd/tests/bench-text-encoder.c++

-1%

3.7 ms3.7 ms

bm_Promise_ImmediatePromise_Then

external/+http+capnp-cpp/src/kj/async-bench.c++

-1%

4.6 µs4.6 µs

Commits

Click on a commit to change the comparison range

Base

main

2e1cccc

fix streams byob request handling after close for spec compliance

e60c1c6

14 days ago

by anonrig

Home Terms Privacy Docs