xortive:fix/connect-handler-remote-address - Branch - cloudflare/workerd

fix: populate `localAddress` on the connect handler's Socket

#6647Closed

Comparing

xortive:fix/connect-handler-remote-address

(

4a3822b

) with

main

(

39b2fc7

)

+39%

Improvement: 1

Untouched: 71

Skipped: 129

Benchmarks

201 total

simpleStringBody[Response]

src/workerd/tests/bench-response.c++

+39%

27.1 µs19.6 µs

EncodeInto_ASCII_8192[TextEncoder][1/0/8192]

src/workerd/tests/bench-text-encoder.c++

3.6 ms3.6 ms

jsonResponse[Response]

src/workerd/tests/bench-response.c++

40.9 µs40.9 µs

bodyWithHeaders[Response]

src/workerd/tests/bench-response.c++

30.9 µs30.9 µs

EncodeInto_OneByte_8192[TextEncoder][1/1/8192]

src/workerd/tests/bench-text-encoder.c++

66.5 ms66.5 ms

request[RegExpBenchmark]

src/workerd/tests/bench-regex.c++

6.9 ms6.9 ms

Encode_ASCII_32[TextEncoder][0/0/32]

src/workerd/tests/bench-text-encoder.c++

2.7 ms2.7 ms

Encode_ASCII_1024[TextEncoder][0/0/1024]

src/workerd/tests/bench-text-encoder.c++

3.3 ms3.3 ms

EncodeInto_TwoByte_256[TextEncoder][1/2/256]

src/workerd/tests/bench-text-encoder.c++

5.3 ms5.3 ms

EncodeInto_OneByte_256[TextEncoder][1/1/256]

src/workerd/tests/bench-text-encoder.c++

4.3 ms4.3 ms

Encode_OneByte_8192[TextEncoder][0/1/8192]

src/workerd/tests/bench-text-encoder.c++

84.3 ms84.3 ms

EncodeInto_OneByte_1024[TextEncoder][1/1/1024]

src/workerd/tests/bench-text-encoder.c++

10.3 ms10.3 ms

bm_Http_FullProtocol

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

74.1 µs74.1 µs

EncodeInto_TwoByte_1024[TextEncoder][1/2/1024]

src/workerd/tests/bench-text-encoder.c++

14 ms14 ms

EncodeInto_ASCII_256[TextEncoder][1/0/256]

src/workerd/tests/bench-text-encoder.c++

2.4 ms2.4 ms

EncodeInto_ASCII_1024[TextEncoder][1/0/1024]

src/workerd/tests/bench-text-encoder.c++

2.5 ms2.5 ms

Util_RecursivelyFreeze

src/workerd/tests/bench-util.c++

9.9 ms9.9 ms

EncodeInto_TwoByte_8192[TextEncoder][1/2/8192]

src/workerd/tests/bench-text-encoder.c++

96.6 ms96.6 ms

Encode_TwoByte_256[TextEncoder][0/2/256]

src/workerd/tests/bench-text-encoder.c++

6 ms6 ms

Encode_OneByte_1024[TextEncoder][0/1/1024]

src/workerd/tests/bench-text-encoder.c++

11.5 ms11.5 ms

Parse[KjHeaders]

src/workerd/tests/bench-kj-headers.c++

53.7 µs53.7 µs

JsString_Utf8Length_Utf16_NonFlat_1024

src/workerd/tests/bench-jsstring.c++

10.4 µs10.4 µs

bm_Http_Baseline

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

11.2 µs11.2 µs

JsString_Utf8Length_Latin1_NonFlat_1024

src/workerd/tests/bench-jsstring.c++

10.3 µs10.3 µs

JsString_Utf8Length_Latin1_Flat_32

src/workerd/tests/bench-jsstring.c++

1.5 µs1.5 µs

Commits

Click on a commit to change the comparison range

Base

main

39b2fc7

+38.55%

fix: populate localAddress on connect handler Socket

4a3822b

12 days ago

by xortive

Home Terms Privacy Docs