pbacondarwin/readline-interface-no-throw - Branch - cloudflare/workerd

fix(node): make readline Interface and Readline classes no-op stubs

#6016Merged

Comparing

pbacondarwin/readline-interface-no-throw

(

1bcc795

) with

main

(

e94c96d

)

-18%

Untouched: 70

Skipped: 129

Benchmarks

199 total

JsString_Utf8Length_Latin1_Flat_1024

src/workerd/tests/bench-jsstring.c++

3.1 µs3.1 µs

JsString_Utf8Length_Utf16_Flat_8192

src/workerd/tests/bench-jsstring.c++

14.1 µs14.1 µs

JsString_Utf8Length_Utf16_Invalid_NonFlat_8192

src/workerd/tests/bench-jsstring.c++

74.3 µs74.3 µs

Util_RecursivelyFreeze

src/workerd/tests/bench-util.c++

10.1 ms10.1 ms

EncodeInto_OneByte_1024[TextEncoder][1/1/1024]

src/workerd/tests/bench-text-encoder.c++

10.3 ms10.3 ms

EncodeInto_TwoByte_1024[TextEncoder][1/2/1024]

src/workerd/tests/bench-text-encoder.c++

14 ms14 ms

set_append[ApiHeaders]

src/workerd/tests/bench-api-headers.c++

11.7 ms11.7 ms

Encode_ASCII_1024[TextEncoder][0/0/1024]

src/workerd/tests/bench-text-encoder.c++

3.6 ms3.6 ms

EncodeInto_OneByte_256[TextEncoder][1/1/256]

src/workerd/tests/bench-text-encoder.c++

4.4 ms4.4 ms

Encode_OneByte_8192[TextEncoder][0/1/8192]

src/workerd/tests/bench-text-encoder.c++

84.6 ms84.6 ms

bm_Http_FullProtocol

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

76.1 µs76.1 µs

Encode_ASCII_256[TextEncoder][0/0/256]

src/workerd/tests/bench-text-encoder.c++

3.1 ms3.1 ms

Encode_TwoByte_8192[TextEncoder][0/2/8192]

src/workerd/tests/bench-text-encoder.c++

119.4 ms119.4 ms

Encode_TwoByte_1024[TextEncoder][0/2/1024]

src/workerd/tests/bench-text-encoder.c++

16.4 ms16.4 ms

EncodeInto_OneByte_8192[TextEncoder][1/1/8192]

src/workerd/tests/bench-text-encoder.c++

66.5 ms66.5 ms

request[GlobalScopeBenchmark]

src/workerd/tests/bench-global-scope.c++

51.6 ms51.6 ms

request[RegExpBenchmark]

src/workerd/tests/bench-regex.c++

8.2 ms8.2 ms

EncodeInto_ASCII_8192[TextEncoder][1/0/8192]

src/workerd/tests/bench-text-encoder.c++

3.6 ms3.6 ms

Test_JSON_ENC

src/workerd/tests/bench-json.c++

-1%

206.4 ms207.7 ms

jsonResponse[Response]

src/workerd/tests/bench-response.c++

-18%

39.6 µs48.2 µs

The benchmarks below were skipped, so their baseline results are used instead. If they were deleted in your codebase, archive them to remove them from the performance reports.
Learn more about archiving benchmarks

Encode_ASCII_8192[TextEncoderBenchmark]

src/workerd/tests/bench-text-encoder.c++

Skipped

584.5 µs*

Encode_ASCII_256[TextEncoderBenchmark]

src/workerd/tests/bench-text-encoder.c++

Skipped

530.7 µs*

Encode_TwoByte_256[TextEncoderBenchmark]

src/workerd/tests/bench-text-encoder.c++

Skipped

531.7 µs*

Encode_ASCII_32[TextEncoderBenchmark]

src/workerd/tests/bench-text-encoder.c++

Skipped

527.6 µs*

Encode_ASCII_1024[TextEncoderBenchmark]

src/workerd/tests/bench-text-encoder.c++

Skipped

535 µs*

Commits

Click on a commit to change the comparison range

Base

main

e94c96d

-0.04%

address PR feedback: improve types and add comments

24f6a6d

27 days ago

by petebacondarwin

-17.73%

fix: add eslint-disable for asyncIterator and fix repl test expectation

1bcc795

15 days ago

by petebacondarwin

Home Terms Privacy Docs