pbacondarwin/readline-interface-no-throw - Branch - cloudflare/workerd

fix(node): make readline Interface and Readline classes no-op stubs

#6016Merged

Comparing

pbacondarwin/readline-interface-no-throw

(

1bcc795

) with

main

(

e94c96d

)

-18%

Untouched: 70

Skipped: 129

Benchmarks

199 total

jsonResponse[Response]

src/workerd/tests/bench-response.c++

-18%

39.6 µs48.2 µs

Test_JSON_ENC

src/workerd/tests/bench-json.c++

-1%

206.4 ms207.7 ms

EncodeInto_ASCII_8192[TextEncoder][1/0/8192]

src/workerd/tests/bench-text-encoder.c++

3.6 ms3.6 ms

bodyWithHeaders[Response]

src/workerd/tests/bench-response.c++

29.8 µs29.8 µs

request[RegExpBenchmark]

src/workerd/tests/bench-regex.c++

8.2 ms8.2 ms

Test_JSON_DEC

src/workerd/tests/bench-json.c++

3.2 s3.2 s

request[GlobalScopeBenchmark]

src/workerd/tests/bench-global-scope.c++

51.6 ms51.6 ms

EncodeInto_ASCII_256[TextEncoder][1/0/256]

src/workerd/tests/bench-text-encoder.c++

2.4 ms2.4 ms

EncodeInto_OneByte_8192[TextEncoder][1/1/8192]

src/workerd/tests/bench-text-encoder.c++

66.5 ms66.5 ms

Encode_OneByte_1024[TextEncoder][0/1/1024]

src/workerd/tests/bench-text-encoder.c++

11.9 ms11.9 ms

Encode_TwoByte_1024[TextEncoder][0/2/1024]

src/workerd/tests/bench-text-encoder.c++

16.4 ms16.4 ms

Encode_TwoByte_256[TextEncoder][0/2/256]

src/workerd/tests/bench-text-encoder.c++

6.4 ms6.4 ms

Encode_OneByte_256[TextEncoder][0/1/256]

src/workerd/tests/bench-text-encoder.c++

5.1 ms5.1 ms

JsString_Utf8Length_Utf16_NonFlat_8192

src/workerd/tests/bench-jsstring.c++

25 µs25 µs

bm_Http_OverCapnpLocalCall

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

128.4 µs128.4 µs

Encode_TwoByte_8192[TextEncoder][0/2/8192]

src/workerd/tests/bench-text-encoder.c++

119.4 ms119.4 ms

Encode_ASCII_256[TextEncoder][0/0/256]

src/workerd/tests/bench-text-encoder.c++

3.1 ms3.1 ms

bm_Http_FullProtocol

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

76.1 µs76.1 µs

EncodeInto_ASCII_1024[TextEncoder][1/0/1024]

src/workerd/tests/bench-text-encoder.c++

2.5 ms2.5 ms

EncodeInto_TwoByte_256[TextEncoder][1/2/256]

src/workerd/tests/bench-text-encoder.c++

5.3 ms5.3 ms

Encode_ASCII_8192[TextEncoder][0/0/8192]

src/workerd/tests/bench-text-encoder.c++

13.4 ms13.4 ms

Encode_OneByte_8192[TextEncoder][0/1/8192]

src/workerd/tests/bench-text-encoder.c++

84.6 ms84.6 ms

bm_Http_OverCapnpFullRPC

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

235.6 µs235.6 µs

EncodeInto_OneByte_256[TextEncoder][1/1/256]

src/workerd/tests/bench-text-encoder.c++

4.4 ms4.4 ms

Encode_ASCII_1024[TextEncoder][0/0/1024]

src/workerd/tests/bench-text-encoder.c++

3.6 ms3.6 ms

Commits

Click on a commit to change the comparison range

Base

main

e94c96d

-0.04%

address PR feedback: improve types and add comments

24f6a6d

4 months ago

by petebacondarwin

-17.73%

fix: add eslint-disable for asyncIterator and fix repl test expectation

1bcc795

4 months ago

by petebacondarwin

Home Terms Privacy Docs