pbacondarwin/readline-interface-no-throw - Branch - cloudflare/workerd

fix(node): make readline Interface and Readline classes no-op stubs

#6016Merged

Comparing

pbacondarwin/readline-interface-no-throw

(

1bcc795

) with

main

(

e94c96d

)

-18%

Untouched: 70

Skipped: 129

Benchmarks

199 total

bodyWithHeaders[Response]

src/workerd/tests/bench-response.c++

29.8 µs29.8 µs

Test_JSON_DEC

src/workerd/tests/bench-json.c++

3.2 s3.2 s

EncodeInto_ASCII_256[TextEncoder][1/0/256]

src/workerd/tests/bench-text-encoder.c++

2.4 ms2.4 ms

Encode_OneByte_1024[TextEncoder][0/1/1024]

src/workerd/tests/bench-text-encoder.c++

11.9 ms11.9 ms

Encode_TwoByte_256[TextEncoder][0/2/256]

src/workerd/tests/bench-text-encoder.c++

6.4 ms6.4 ms

Encode_OneByte_256[TextEncoder][0/1/256]

src/workerd/tests/bench-text-encoder.c++

5.1 ms5.1 ms

JsString_Utf8Length_Utf16_NonFlat_8192

src/workerd/tests/bench-jsstring.c++

25 µs25 µs

bm_Http_OverCapnpLocalCall

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

128.4 µs128.4 µs

EncodeInto_ASCII_1024[TextEncoder][1/0/1024]

src/workerd/tests/bench-text-encoder.c++

2.5 ms2.5 ms

EncodeInto_TwoByte_256[TextEncoder][1/2/256]

src/workerd/tests/bench-text-encoder.c++

5.3 ms5.3 ms

Encode_ASCII_8192[TextEncoder][0/0/8192]

src/workerd/tests/bench-text-encoder.c++

13.4 ms13.4 ms

bm_Http_OverCapnpFullRPC

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

235.6 µs235.6 µs

Encode_ASCII_32[TextEncoder][0/0/32]

src/workerd/tests/bench-text-encoder.c++

3.1 ms3.1 ms

EncodeInto_TwoByte_8192[TextEncoder][1/2/8192]

src/workerd/tests/bench-text-encoder.c++

96.6 ms96.6 ms

constructor[ApiHeaders]

src/workerd/tests/bench-api-headers.c++

67.6 ms67.6 ms

bm_Promise_Immediate

external/+http+capnp-cpp/src/kj/async-bench.c++

3.7 µs3.7 µs

bm_Coro_Fib10

external/+http+capnp-cpp/src/kj/async-bench.c++

14.8 µs14.8 µs

bm_Http_ClientWrapper

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

35.7 µs35.7 µs

bm_Promise_Fib10

external/+http+capnp-cpp/src/kj/async-bench.c++

19.4 µs19.4 µs

bm_Coro_Pow2_20

external/+http+capnp-cpp/src/kj/async-bench.c++

18.7 µs18.7 µs

bm_Coro_Immediate

external/+http+capnp-cpp/src/kj/async-bench.c++

4.3 µs4.3 µs

bm_Coro_Shift_20

external/+http+capnp-cpp/src/kj/async-bench.c++

21.4 µs21.4 µs

bm_Coro_CoAwait_ImmediateCoroutine

external/+http+capnp-cpp/src/kj/async-bench.c++

6.1 µs6.1 µs

arrayBufferBody[Response]

src/workerd/tests/bench-response.c++

17.4 µs17.4 µs

bm_Http_Baseline

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

11.2 µs11.2 µs

Commits

Click on a commit to change the comparison range

Base

main

e94c96d

-0.04%

address PR feedback: improve types and add comments

24f6a6d

3 months ago

by petebacondarwin

-17.73%

fix: add eslint-disable for asyncIterator and fix repl test expectation

1bcc795

2 months ago

by petebacondarwin

Home Terms Privacy Docs