pbacondarwin/readline-interface-no-throw - Branch - cloudflare/workerd

fix(node): make readline Interface and Readline classes no-op stubs

#6016

Comparing

pbacondarwin/readline-interface-no-throw

(

f67d3a0

) with

main

(

7bc05ef

)

Untouched: 70

Skipped: 129

Benchmarks

199 total

Encode_ASCII_256[TextEncoder][0/0/256]

src/workerd/tests/bench-text-encoder.c++

3 ms3 ms

request[RegExpBenchmark]

src/workerd/tests/bench-regex.c++

8.2 ms8.2 ms

Encode_OneByte_256[TextEncoder][0/1/256]

src/workerd/tests/bench-text-encoder.c++

5.1 ms5.1 ms

Encode_ASCII_8192[TextEncoder][0/0/8192]

src/workerd/tests/bench-text-encoder.c++

13.4 ms13.4 ms

Encode_ASCII_1024[TextEncoder][0/0/1024]

src/workerd/tests/bench-text-encoder.c++

3.6 ms3.6 ms

bm_Http_FullProtocol

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

76.1 µs76.1 µs

EncodeInto_TwoByte_8192[TextEncoder][1/2/8192]

src/workerd/tests/bench-text-encoder.c++

96.6 ms96.6 ms

Encode_TwoByte_256[TextEncoder][0/2/256]

src/workerd/tests/bench-text-encoder.c++

6.4 ms6.4 ms

Encode_OneByte_1024[TextEncoder][0/1/1024]

src/workerd/tests/bench-text-encoder.c++

11.9 ms11.9 ms

EncodeInto_TwoByte_256[TextEncoder][1/2/256]

src/workerd/tests/bench-text-encoder.c++

5.3 ms5.3 ms

bm_Http_OverCapnpFullRPC

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

235.6 µs235.6 µs

set_append[ApiHeaders]

src/workerd/tests/bench-api-headers.c++

11.7 ms11.7 ms

Test_JSON_DEC

src/workerd/tests/bench-json.c++

3.2 s3.2 s

EncodeInto_OneByte_256[TextEncoder][1/1/256]

src/workerd/tests/bench-text-encoder.c++

4.4 ms4.4 ms

Encode_TwoByte_8192[TextEncoder][0/2/8192]

src/workerd/tests/bench-text-encoder.c++

119.4 ms119.4 ms

Encode_ASCII_32[TextEncoder][0/0/32]

src/workerd/tests/bench-text-encoder.c++

3 ms3 ms

bm_Http_ClientWrapper

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

35.7 µs35.7 µs

bm_Http_Baseline

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

11.2 µs11.2 µs

JsString_Utf8Length_Utf16_NonFlat_8192

src/workerd/tests/bench-jsstring.c++

25 µs25 µs

bm_Coro_Fib10

external/+http+capnp-cpp/src/kj/async-bench.c++

14.8 µs14.8 µs

bm_Coro_CoAwait_ImmediatePromise

external/+http+capnp-cpp/src/kj/async-bench.c++

5.9 µs5.9 µs

bm_Coro_CoAwait_ImmediateCoroutine

external/+http+capnp-cpp/src/kj/async-bench.c++

6.1 µs6.1 µs

bm_Promise_ImmediatePromise_Then

external/+http+capnp-cpp/src/kj/async-bench.c++

4.5 µs4.5 µs

JsString_Utf8Length_Utf16_NonFlat_256

src/workerd/tests/bench-jsstring.c++

8.2 µs8.2 µs

bm_Coro_Pow2_20

external/+http+capnp-cpp/src/kj/async-bench.c++

18.7 µs18.7 µs

Commits

Click on a commit to change the comparison range

Base

main

7bc05ef

+0.03%

fix(node): make readline Interface and Readline classes no-op stubs

87c332e

8 days ago

by petebacondarwin

-0.08%

address PR feedback: improve types and add comments

f67d3a0

8 days ago

by petebacondarwin

Home Terms Privacy Docs