milan/STOR-5008 - Branch - cloudflare/workerd

Fix IoContext::run() crash when incomingRequests is empty

#6230

Comparing

milan/STOR-5008

(

d311cb5

) with

main

(

8682d24

)

+14%

Improvement: 1

Untouched: 69

Skipped: 129

Benchmarks

199 total

Encode_ASCII_32[TextEncoder][0/0/32]

src/workerd/tests/bench-text-encoder.c++

+14%

3.5 ms3 ms

JsString_Utf8Length_Latin1_Flat_32

src/workerd/tests/bench-jsstring.c++

+6%

1.5 µs1.5 µs

Encode_ASCII_256[TextEncoder][0/0/256]

src/workerd/tests/bench-text-encoder.c++

+1%

3.1 ms3 ms

EncodeInto_ASCII_256[TextEncoder][1/0/256]

src/workerd/tests/bench-text-encoder.c++

+1%

2.4 ms2.4 ms

Encode_ASCII_1024[TextEncoder][0/0/1024]

src/workerd/tests/bench-text-encoder.c++

+1%

3.6 ms3.6 ms

Encode_OneByte_256[TextEncoder][0/1/256]

src/workerd/tests/bench-text-encoder.c++

+1%

5.1 ms5.1 ms

EncodeInto_ASCII_8192[TextEncoder][1/0/8192]

src/workerd/tests/bench-text-encoder.c++

+1%

3.6 ms3.6 ms

EncodeInto_ASCII_1024[TextEncoder][1/0/1024]

src/workerd/tests/bench-text-encoder.c++

+1%

2.5 ms2.5 ms

EncodeInto_OneByte_256[TextEncoder][1/1/256]

src/workerd/tests/bench-text-encoder.c++

+1%

4.4 ms4.4 ms

EncodeInto_TwoByte_256[TextEncoder][1/2/256]

src/workerd/tests/bench-text-encoder.c++

5.3 ms5.3 ms

JsString_Utf8Length_Latin1_NonFlat_256

src/workerd/tests/bench-jsstring.c++

8.2 µs8.1 µs

Encode_OneByte_1024[TextEncoder][0/1/1024]

src/workerd/tests/bench-text-encoder.c++

11.9 ms11.9 ms

EncodeInto_TwoByte_1024[TextEncoder][1/2/1024]

src/workerd/tests/bench-text-encoder.c++

14.1 ms14 ms

EncodeInto_OneByte_1024[TextEncoder][1/1/1024]

src/workerd/tests/bench-text-encoder.c++

10.4 ms10.3 ms

constructor[ApiHeaders]

src/workerd/tests/bench-api-headers.c++

67.7 ms67.6 ms

request[RegExpBenchmark]

src/workerd/tests/bench-regex.c++

8.2 ms8.2 ms

Encode_ASCII_8192[TextEncoder][0/0/8192]

src/workerd/tests/bench-text-encoder.c++

13.4 ms13.4 ms

EncodeInto_TwoByte_8192[TextEncoder][1/2/8192]

src/workerd/tests/bench-text-encoder.c++

96.6 ms96.6 ms

bm_Http_Baseline

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

11.1 µs11.1 µs

Parse[KjHeaders]

src/workerd/tests/bench-kj-headers.c++

44.2 µs44.2 µs

bm_Http_OverCapnpFullRPC

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

234.9 µs234.9 µs

ParseAndSerialize

src/workerd/tests/bench-mimetype.c++::Mimetype

74.8 ms74.8 ms

Serialize

src/workerd/tests/bench-mimetype.c++::Mimetype

74.6 ms74.6 ms

nullBodyWithStatus[Response]

src/workerd/tests/bench-response.c++

10.4 µs10.4 µs

bm_Http_FullProtocol

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

76.1 µs76.1 µs

Commits

Click on a commit to change the comparison range

Base

main

8682d24

+14.14%

STOR-5008: fix IoContext::run() crash when incomingRequests is empty

d311cb5

8 days ago

by MellowYarker

Home Terms Privacy Docs