milan/STOR-4832 - Branch - cloudflare/workerd

Run alarm without syncing alarm manager if currentTime past local time

#5764Merged

Comparing

milan/STOR-4832

(

e1f666d

) with

main

(

02cf171

)

Untouched: 68

Skipped: 129

Benchmarks

Skipped (129)

Passed

Encode_ASCII_256[TextEncoder][0/0/256]

src/workerd/tests/bench-text-encoder.c++

3.2 ms3.2 ms

Encode_ASCII_8192[TextEncoder][0/0/8192]

src/workerd/tests/bench-text-encoder.c++

13.2 ms13.2 ms

Encode_OneByte_256[TextEncoder][0/1/256]

src/workerd/tests/bench-text-encoder.c++

5.2 ms5.2 ms

ParseAndSerialize

src/workerd/tests/bench-mimetype.c++::Mimetype

74.9 ms74.9 ms

EncodeInto_ASCII_256[TextEncoder][1/0/256]

src/workerd/tests/bench-text-encoder.c++

2.6 ms2.6 ms

Test_JSON_ENC

src/workerd/tests/bench-json.c++

207.2 ms207.2 ms

Encode_TwoByte_8192[TextEncoder][0/2/8192]

src/workerd/tests/bench-text-encoder.c++

146.2 ms146.2 ms

Test_JSON_DEC

src/workerd/tests/bench-json.c++

3.2 s3.2 s

bm_Http_FullProtocol

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

77.9 µs77.9 µs

bm_Http_ClientWrapper

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

36 µs36 µs

Util_RecursivelyFreeze

src/workerd/tests/bench-util.c++

10.9 ms10.9 ms

JsString_Utf8Length_Utf16_Flat_1024

src/workerd/tests/bench-jsstring.c++

8.6 µs8.6 µs

bm_Http_Baseline

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

11.8 µs11.8 µs

JsString_Utf8Length_Utf16_Invalid_Flat_1024

src/workerd/tests/bench-jsstring.c++

8.6 µs8.6 µs

bm_Coro_CoAwait_ImmediateCoroutine

external/+http+capnp-cpp/src/kj/async-bench.c++

6.5 µs6.5 µs

bm_Coro_CoAwait_ImmediatePromise

external/+http+capnp-cpp/src/kj/async-bench.c++

6.3 µs6.3 µs

JsString_Utf8Length_Utf16_Invalid_Flat_256

src/workerd/tests/bench-jsstring.c++

2.8 µs2.8 µs

JsString_Utf8Length_Utf16_Flat_8192

src/workerd/tests/bench-jsstring.c++

62.9 µs62.9 µs

JsString_Utf8Length_Utf16_Flat_256

src/workerd/tests/bench-jsstring.c++

2.8 µs2.8 µs

bm_Coro_Immediate

external/+http+capnp-cpp/src/kj/async-bench.c++

4.3 µs4.3 µs

JsString_Utf8Length_Utf16_Invalid_Flat_8192

src/workerd/tests/bench-jsstring.c++

62.9 µs62.9 µs

bm_Coro_Shift_20

external/+http+capnp-cpp/src/kj/async-bench.c++

23.1 µs23.1 µs

JsString_Utf8Length_Utf16_Invalid_NonFlat_256

src/workerd/tests/bench-jsstring.c++

9 µs9 µs

JsString_Utf8Length_Utf16_Invalid_NonFlat_1024

src/workerd/tests/bench-jsstring.c++

16.3 µs16.3 µs

bm_Promise_Immediate

external/+http+capnp-cpp/src/kj/async-bench.c++

3.6 µs3.6 µs

bm_Coro_Pow2_20

external/+http+capnp-cpp/src/kj/async-bench.c++

20.4 µs20.4 µs

bm_Promise_Pow2_20

external/+http+capnp-cpp/src/kj/async-bench.c++

9.9 µs9.9 µs

JsString_Utf8Length_Utf16_Invalid_NonFlat_8192

src/workerd/tests/bench-jsstring.c++

73.9 µs73.9 µs

bm_Promise_ImmediatePromise_Then

external/+http+capnp-cpp/src/kj/async-bench.c++

4.5 µs4.5 µs

bm_Promise_ReadyNow

external/+http+capnp-cpp/src/kj/async-bench.c++

2.2 µs2.2 µs

bm_Promise_Shift_20

external/+http+capnp-cpp/src/kj/async-bench.c++

10.8 µs10.8 µs

JsString_Utf8Length_Utf16_NonFlat_8192

src/workerd/tests/bench-jsstring.c++

73.9 µs73.9 µs

JsString_Utf8Length_Utf16_NonFlat_256

src/workerd/tests/bench-jsstring.c++

9 µs9 µs

JsString_Utf8Length_Latin1_NonFlat_1024

src/workerd/tests/bench-jsstring.c++

12.3 µs12.3 µs

JsString_Utf8Length_Utf16_NonFlat_1024

src/workerd/tests/bench-jsstring.c++

16.3 µs16.3 µs

Parse[KjHeaders]

src/workerd/tests/bench-kj-headers.c++

44.4 µs44.4 µs

JsString_Utf8Length_Latin1_Flat_1024

src/workerd/tests/bench-jsstring.c++

4.6 µs4.6 µs

JsString_Utf8Length_Latin1_NonFlat_256

src/workerd/tests/bench-jsstring.c++

8 µs8 µs

JsString_Utf8Length_Latin1_NonFlat_8192

src/workerd/tests/bench-jsstring.c++

42.1 µs42.1 µs

JsString_Utf8Length_Latin1_Flat_256

src/workerd/tests/bench-jsstring.c++

1.7 µs1.7 µs

JsString_Utf8Length_Latin1_Flat_8192

src/workerd/tests/bench-jsstring.c++

31 µs31 µs

JsString_Utf8Length_Latin1_Flat_32

src/workerd/tests/bench-jsstring.c++

949.4 ns949.4 ns

EncodeInto_TwoByte_8192[TextEncoder][1/2/8192]

src/workerd/tests/bench-text-encoder.c++

96.7 ms96.7 ms

Encode_OneByte_8192[TextEncoder][0/1/8192]

src/workerd/tests/bench-text-encoder.c++

84.8 ms84.8 ms

Serialize

src/workerd/tests/bench-mimetype.c++::Mimetype

74.6 ms74.6 ms

bm_Http_OverCapnpFullRPC

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

238.1 µs238.1 µs

EncodeInto_OneByte_1024[TextEncoder][1/1/1024]

src/workerd/tests/bench-text-encoder.c++

10.5 ms10.5 ms

bm_Http_OverCapnpLocalCall

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

128.1 µs128.1 µs

EncodeInto_TwoByte_1024[TextEncoder][1/2/1024]

src/workerd/tests/bench-text-encoder.c++

14.2 ms14.2 ms

EncodeInto_TwoByte_256[TextEncoder][1/2/256]

src/workerd/tests/bench-text-encoder.c++

5.4 ms5.4 ms

EncodeInto_OneByte_256[TextEncoder][1/1/256]

src/workerd/tests/bench-text-encoder.c++

4.5 ms4.5 ms

EncodeInto_ASCII_1024[TextEncoder][1/0/1024]

src/workerd/tests/bench-text-encoder.c++

2.7 ms2.7 ms

Encode_ASCII_32[TextEncoder][0/0/32]

src/workerd/tests/bench-text-encoder.c++

3 ms3 ms

Encode_OneByte_1024[TextEncoder][0/1/1024]

src/workerd/tests/bench-text-encoder.c++

12 ms12 ms

Encode_TwoByte_1024[TextEncoder][0/2/1024]

src/workerd/tests/bench-text-encoder.c++

19.6 ms19.6 ms

Encode_TwoByte_256[TextEncoder][0/2/256]

src/workerd/tests/bench-text-encoder.c++

7.1 ms7.1 ms

Encode_ASCII_1024[TextEncoder][0/0/1024]

src/workerd/tests/bench-text-encoder.c++

3.7 ms3.7 ms

EncodeInto_OneByte_8192[TextEncoder][1/1/8192]

src/workerd/tests/bench-text-encoder.c++

66.7 ms66.7 ms

request[GlobalScopeBenchmark]

src/workerd/tests/bench-global-scope.c++

52.5 ms52.5 ms

set_append[ApiHeaders]

src/workerd/tests/bench-api-headers.c++

11.7 ms11.7 ms

constructor[ApiHeaders]

src/workerd/tests/bench-api-headers.c++

67.6 ms67.7 ms

EncodeInto_ASCII_8192[TextEncoder][1/0/8192]

src/workerd/tests/bench-text-encoder.c++

3.4 ms3.4 ms

jsonResponse[Response]

src/workerd/tests/bench-response.c++

34.8 µs35 µs

simpleStringBody[Response]

src/workerd/tests/bench-response.c++

-1%

19.1 µs19.4 µs

arrayBufferBody[Response]

src/workerd/tests/bench-response.c++

-1%

17.4 µs17.7 µs

nullBodyWithStatus[Response]

src/workerd/tests/bench-response.c++

-2%

10.2 µs10.4 µs

bodyWithHeaders[Response]

src/workerd/tests/bench-response.c++

-3%

24.4 µs25.2 µs

request[RegExpBenchmark]

src/workerd/tests/bench-regex.c++

-5%

7.3 ms7.7 ms

Commits

Click on a commit to change the comparison range

Base

main

02cf171

-0.19%

Run alarm without syncing alarm manager if currentTime past local time Historically, if a SQLite DOs local alarm time in SQLite didn't match the AlarmManager's alarm time, we would reschedule the alarm and try to run the alarm again later. However, if the time we are attempting to sync to is already before the current real system time, there is no point in rescheduling to run later, since we might as well run now. This commit runs the alarm immediately if the current system time is already past the time we are trying to sync the alarm manager to, since it's better to run an alarm a little late rather than very late.

e1f666d

28 days ago

by MellowYarker

Home Terms Privacy Docs