milan/STOR-4832 - Branch - cloudflare/workerd

Run alarm without syncing alarm manager if currentTime past local time

#5764

Comparing

milan/STOR-4832

(

7f13363

) with

main

(

03ac4ad

)

Untouched: 57

Skipped: 34

Benchmarks

Skipped (34)

Passed

nullBodyWithStatus[Response]

src/workerd/tests/bench-response.c++

+1%

10.3 µs10.1 µs

Encode_OneByte_256[TextEncoder][0/1/256]

src/workerd/tests/bench-text-encoder.c++

5.2 ms5.1 ms

request[GlobalScopeBenchmark]

src/workerd/tests/bench-global-scope.c++

52.7 ms52.6 ms

Encode_TwoByte_1024[TextEncoder][0/2/1024]

src/workerd/tests/bench-text-encoder.c++

19.5 ms19.5 ms

Encode_OneByte_8192[TextEncoder][0/1/8192]

src/workerd/tests/bench-text-encoder.c++

84.8 ms84.7 ms

Encode_ASCII_1024[TextEncoder][0/0/1024]

src/workerd/tests/bench-text-encoder.c++

3.7 ms3.7 ms

Encode_ASCII_32[TextEncoder][0/0/32]

src/workerd/tests/bench-text-encoder.c++

2.9 ms2.9 ms

ParseAndSerialize

src/workerd/tests/bench-mimetype.c++::Mimetype

74.9 ms74.9 ms

Util_RecursivelyFreeze

src/workerd/tests/bench-util.c++

10.8 ms10.8 ms

Encode_OneByte_1024[TextEncoder][0/1/1024]

src/workerd/tests/bench-text-encoder.c++

12 ms12 ms

EncodeInto_TwoByte_256[TextEncoder][1/2/256]

src/workerd/tests/bench-text-encoder.c++

5.4 ms5.4 ms

Encode_ASCII_8192[TextEncoder][0/0/8192]

src/workerd/tests/bench-text-encoder.c++

13.2 ms13.2 ms

EncodeInto_OneByte_8192[TextEncoder][1/1/8192]

src/workerd/tests/bench-text-encoder.c++

66.7 ms66.7 ms

Encode_ASCII_256[TextEncoder][0/0/256]

src/workerd/tests/bench-text-encoder.c++

3.1 ms3.1 ms

Serialize

src/workerd/tests/bench-mimetype.c++::Mimetype

74.6 ms74.6 ms

bm_Immediate

external/+http+capnp-cpp/src/kj/async-bench.c++

3.6 µs3.6 µs

bm_ReadyNow

external/+http+capnp-cpp/src/kj/async-bench.c++

2.1 µs2.1 µs

JsString_Utf8Length_Utf16_NonFlat_256

src/workerd/tests/bench-jsstring.c++

8.9 µs8.9 µs

JsString_Utf8Length_Latin1_Flat_256

src/workerd/tests/bench-jsstring.c++

1.7 µs1.7 µs

bm_coroCoReturn

external/+http+capnp-cpp/src/kj/async-bench.c++

4.6 µs4.6 µs

bm_coroCoAwaitImmediate

external/+http+capnp-cpp/src/kj/async-bench.c++

6.2 µs6.2 µs

Parse[KjHeaders]

src/workerd/tests/bench-kj-headers.c++

44.3 µs44.3 µs

JsString_Utf8Length_Utf16_NonFlat_8192

src/workerd/tests/bench-jsstring.c++

73.8 µs73.8 µs

JsString_Utf8Length_Latin1_Flat_1024

src/workerd/tests/bench-jsstring.c++

4.6 µs4.6 µs

JsString_Utf8Length_Latin1_Flat_32

src/workerd/tests/bench-jsstring.c++

861.9 ns861.9 ns

JsString_Utf8Length_Latin1_NonFlat_1024

src/workerd/tests/bench-jsstring.c++

12.1 µs12.1 µs

JsString_Utf8Length_Latin1_Flat_8192

src/workerd/tests/bench-jsstring.c++

31 µs31 µs

JsString_Utf8Length_Utf16_Invalid_Flat_1024

src/workerd/tests/bench-jsstring.c++

8.5 µs8.5 µs

JsString_Utf8Length_Latin1_NonFlat_256

src/workerd/tests/bench-jsstring.c++

7.9 µs7.9 µs

JsString_Utf8Length_Utf16_Flat_1024

src/workerd/tests/bench-jsstring.c++

8.5 µs8.5 µs

JsString_Utf8Length_Latin1_NonFlat_8192

src/workerd/tests/bench-jsstring.c++

42 µs42 µs

JsString_Utf8Length_Utf16_Invalid_NonFlat_256

src/workerd/tests/bench-jsstring.c++

8.9 µs8.9 µs

JsString_Utf8Length_Utf16_Flat_256

src/workerd/tests/bench-jsstring.c++

2.7 µs2.7 µs

JsString_Utf8Length_Utf16_Flat_8192

src/workerd/tests/bench-jsstring.c++

62.8 µs62.8 µs

JsString_Utf8Length_Utf16_Invalid_Flat_256

src/workerd/tests/bench-jsstring.c++

2.7 µs2.7 µs

JsString_Utf8Length_Utf16_Invalid_NonFlat_8192

src/workerd/tests/bench-jsstring.c++

73.8 µs73.8 µs

JsString_Utf8Length_Utf16_Invalid_NonFlat_1024

src/workerd/tests/bench-jsstring.c++

16.2 µs16.2 µs

JsString_Utf8Length_Utf16_NonFlat_1024

src/workerd/tests/bench-jsstring.c++

16.1 µs16.1 µs

JsString_Utf8Length_Utf16_Invalid_Flat_8192

src/workerd/tests/bench-jsstring.c++

62.8 µs62.8 µs

Encode_TwoByte_8192[TextEncoder][0/2/8192]

src/workerd/tests/bench-text-encoder.c++

146.1 ms146.1 ms

EncodeInto_TwoByte_1024[TextEncoder][1/2/1024]

src/workerd/tests/bench-text-encoder.c++

14.2 ms14.2 ms

EncodeInto_OneByte_1024[TextEncoder][1/1/1024]

src/workerd/tests/bench-text-encoder.c++

10.5 ms10.5 ms

EncodeInto_ASCII_256[TextEncoder][1/0/256]

src/workerd/tests/bench-text-encoder.c++

2.6 ms2.6 ms

EncodeInto_ASCII_1024[TextEncoder][1/0/1024]

src/workerd/tests/bench-text-encoder.c++

2.7 ms2.7 ms

EncodeInto_OneByte_256[TextEncoder][1/1/256]

src/workerd/tests/bench-text-encoder.c++

4.5 ms4.5 ms

constructor[ApiHeaders]

src/workerd/tests/bench-api-headers.c++

67.6 ms67.6 ms

request[RegExpBenchmark]

src/workerd/tests/bench-regex.c++

7.3 ms7.3 ms

Test_JSON_ENC

src/workerd/tests/bench-json.c++

205.9 ms205.9 ms

set_append[ApiHeaders]

src/workerd/tests/bench-api-headers.c++

11.7 ms11.7 ms

EncodeInto_TwoByte_8192[TextEncoder][1/2/8192]

src/workerd/tests/bench-text-encoder.c++

96.7 ms96.7 ms

Test_JSON_DEC

src/workerd/tests/bench-json.c++

3.2 s3.2 s

Encode_TwoByte_256[TextEncoder][0/2/256]

src/workerd/tests/bench-text-encoder.c++

7 ms7 ms

EncodeInto_ASCII_8192[TextEncoder][1/0/8192]

src/workerd/tests/bench-text-encoder.c++

3.4 ms3.4 ms

simpleStringBody[Response]

src/workerd/tests/bench-response.c++

21.5 µs21.6 µs

bodyWithHeaders[Response]

src/workerd/tests/bench-response.c++

24 µs24.1 µs

jsonResponse[Response]

src/workerd/tests/bench-response.c++

34.6 µs34.8 µs

arrayBufferBody[Response]

src/workerd/tests/bench-response.c++

17.4 µs17.5 µs

Commits

Click on a commit to change the comparison range

Base

main

03ac4ad

-0.01%

Run alarm without syncing alarm manager if currentTime past local time Historically, if a SQLite DOs local alarm time in SQLite didn't match the AlarmManager's alarm time, we would reschedule the alarm and try to run the alarm again later. However, if the time we are attempting to sync to is already before the current real system time, there is no point in rescheduling to run later, since we might as well run now. This commit runs the alarm immediately if the current system time is already past the time we are trying to sync the alarm manager to, since it's better to run an alarm a little late rather than very late.

7f13363

13 hours ago

by MellowYarker

Home Terms Privacy Docs