hoodmane/fix-function-serialization - Branch - cloudflare/workerd

Fix serialization of functions from import_js_module

#6632Merged

Comparing

hoodmane/fix-function-serialization

(

5eb82f3

) with

main

(

d9d8fa6

)

+38%

Improvement: 1

Untouched: 71

Skipped: 129

Benchmarks

201 total

simpleStringBody[Response]

src/workerd/tests/bench-response.c++

+38%

26.7 µs19.3 µs

bodyWithHeaders[Response]

src/workerd/tests/bench-response.c++

30.6 µs30.5 µs

jsonResponse[Response]

src/workerd/tests/bench-response.c++

40.8 µs40.7 µs

Encode_ASCII_256[TextEncoder][0/0/256]

src/workerd/tests/bench-text-encoder.c++

2.7 ms2.7 ms

Encode_ASCII_8192[TextEncoder][0/0/8192]

src/workerd/tests/bench-text-encoder.c++

13 ms13 ms

EncodeInto_ASCII_8192[TextEncoder][1/0/8192]

src/workerd/tests/bench-text-encoder.c++

3.6 ms3.6 ms

EncodeInto_TwoByte_256[TextEncoder][1/2/256]

src/workerd/tests/bench-text-encoder.c++

5.3 ms5.3 ms

EncodeInto_OneByte_8192[TextEncoder][1/1/8192]

src/workerd/tests/bench-text-encoder.c++

66.5 ms66.5 ms

request[GlobalScopeBenchmark]

src/workerd/tests/bench-global-scope.c++

52.6 ms52.6 ms

Test_JSON_DEC

src/workerd/tests/bench-json.c++

3.3 s3.3 s

Encode_TwoByte_256[TextEncoder][0/2/256]

src/workerd/tests/bench-text-encoder.c++

6 ms6 ms

EncodeInto_OneByte_1024[TextEncoder][1/1/1024]

src/workerd/tests/bench-text-encoder.c++

10.3 ms10.3 ms

Encode_TwoByte_8192[TextEncoder][0/2/8192]

src/workerd/tests/bench-text-encoder.c++

119 ms119 ms

Encode_OneByte_1024[TextEncoder][0/1/1024]

src/workerd/tests/bench-text-encoder.c++

11.5 ms11.5 ms

EncodeInto_ASCII_1024[TextEncoder][1/0/1024]

src/workerd/tests/bench-text-encoder.c++

2.5 ms2.5 ms

bm_Http_FullProtocol

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

74.1 µs74.1 µs

bm_Http_OverCapnpFullRPC

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

234.8 µs234.8 µs

EncodeInto_ASCII_256[TextEncoder][1/0/256]

src/workerd/tests/bench-text-encoder.c++

2.4 ms2.4 ms

constructor[ApiHeaders]

src/workerd/tests/bench-api-headers.c++

69.5 ms69.5 ms

JsString_Utf8Length_Utf16_NonFlat_8192

src/workerd/tests/bench-jsstring.c++

24.9 µs24.9 µs

JsString_Utf8Length_Latin1_Flat_32

src/workerd/tests/bench-jsstring.c++

1.5 µs1.5 µs

JsString_Utf8Length_Latin1_Flat_8192

src/workerd/tests/bench-jsstring.c++

14.1 µs14.1 µs

bm_Http_ClientWrapper

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

34.7 µs34.7 µs

JsString_Utf8Length_Latin1_NonFlat_256

src/workerd/tests/bench-jsstring.c++

8.2 µs8.2 µs

bm_Http_Baseline

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

11.2 µs11.2 µs

Commits

Click on a commit to change the comparison range

Base

main

d9d8fa6

+38.42%

Fix serialization of functions from import_js_module

5eb82f3

14 hours ago

by hoodmane

Home Terms Privacy Docs