Comparing
harris/2025-07-15-clang-tidy-multiple-bool-args
(1929408
) withmain
(b0818f9
)-1%
- Improvements
- 0
- Regressions
- 0
- Untouched
- 9
- New
- 0
- Dropped
- 0
- Ignored
- 0
Benchmarks
Passed
constructor[ApiHeaders]
src/workerd/tests/bench-api-headers.c++::constructor[ApiHeaders]0%
70.9 ms
70.9 ms
request[GlobalScopeBenchmark]
src/workerd/tests/bench-global-scope.c++::request[GlobalScopeBenchmark]0%
57.2 ms
57.2 ms
ParseAndSerialize
Mimetype::ParseAndSerialize0%
78.6 ms
78.5 ms
Serialize
Mimetype::Serialize0%
96.9 ms
96.9 ms
Util_RecursivelyFreeze
src/workerd/tests/bench-util.c++::Util_RecursivelyFreeze0%
10.9 ms
10.9 ms
Parse[KjHeaders]
src/workerd/tests/bench-kj-headers.c++::Parse[KjHeaders]0%
44.3 µs
44.3 µs
Test_JSON_ENC
src/workerd/tests/bench-json.c++::Test_JSON_ENC0%
196 ms
196.1 ms
Test_JSON_DEC
src/workerd/tests/bench-json.c++::Test_JSON_DEC0%
3.2 s
3.2 s
request[RegExpBenchmark]
src/workerd/tests/bench-regex.c++::request[RegExpBenchmark]-6%
7.4 ms
7.9 ms
Commits
Click on a commit to change the comparison rangeBase
main
b0818f9
-1%
Get rid of multiple bool parameters to takeHeapSnapshot()
This resolves a new downstream lint.
This is not marked [nfc] because there are two bugfixes in this commit:
- The reportProgress flag is now being respected. Previously we were
alwyas reporting progress.
- The exposeInternals flag is now being properly interpreted. Previously
we were passing it, un-negated, to a parameter named hide_internals.
I switched to the options struct version of the V8 TakeHeapSnapshot()
function for greater clarity.
1929408
21 hours ago
by harrishancock