harris/2025-07-14-strong-bool-to-bool - Branch - cloudflare/workerd

[nfc] Add StrongBool::toBool()

#4522Merged

Comparing

harris/2025-07-14-strong-bool-to-bool

(

5a484c5

) with

main

(

487fd1e

)

+19%

Improvements: 1

Untouched: 10

Benchmarks

Improved

SlowAPIWithLock[FastMethodFixture]

src/workerd/tests/bench-fast-api.c++::SlowAPIWithLock[FastMethodFixture]

+19%

34.7 ms29.2 ms

Passed

request[RegExpBenchmark]

src/workerd/tests/bench-regex.c++::request[RegExpBenchmark]

7.4 ms7.4 ms

Test_JSON_ENC

src/workerd/tests/bench-json.c++::Test_JSON_ENC

196 ms196 ms

ParseAndSerialize

Mimetype::ParseAndSerialize

78.6 ms78.6 ms

SlowAPI[FastMethodFixture]

src/workerd/tests/bench-fast-api.c++::SlowAPI[FastMethodFixture]

37.3 ms37.3 ms

Parse[KjHeaders]

src/workerd/tests/bench-kj-headers.c++::Parse[KjHeaders]

44.3 µs44.3 µs

Util_RecursivelyFreeze

src/workerd/tests/bench-util.c++::Util_RecursivelyFreeze

10.8 ms10.8 ms

Serialize

Mimetype::Serialize

96.9 ms96.9 ms

constructor[ApiHeaders]

src/workerd/tests/bench-api-headers.c++::constructor[ApiHeaders]

71 ms71 ms

request[GlobalScopeBenchmark]

src/workerd/tests/bench-global-scope.c++::request[GlobalScopeBenchmark]

56.8 ms56.8 ms

Test_JSON_DEC

src/workerd/tests/bench-json.c++::Test_JSON_DEC

3.2 s3.2 s

Commits

Click on a commit to change the comparison range

Base

main

487fd1e

+18.9%

[nfc] Add StrongBool::toBool() I belatedly recalled that I shouldn't be using functional-style casts, since they implicitly perform a const_cast. In this case, it's not a big risk, but in theory someone could change a strong bool type to some other type with a non-const `operator bool()`, causing a safety issue. The type already supports static_cast, of course, but no one's going to want to use that.

5a484c5

2 months ago

by harrishancock

Home Terms Privacy Docs