gyeongjae/html-rewriter-posion-after-exception - Branch - cloudflare/workerd

Do not propagate exception inside HTMLRewriter parser

#5976

Comparing

gyeongjae/html-rewriter-posion-after-exception

(

ccb8ecd

) with

main

(

a89ad60

)

+13%

Improvement: 1

Untouched: 69

Skipped: 129

Benchmarks

199 total

simpleStringBody[Response]

src/workerd/tests/bench-response.c++

+13%

21.6 µs19.1 µs

request[RegExpBenchmark]

src/workerd/tests/bench-regex.c++

+6%

7.7 ms7.3 ms

jsonResponse[Response]

src/workerd/tests/bench-response.c++

34.8 µs34.7 µs

EncodeInto_ASCII_8192[TextEncoder][1/0/8192]

src/workerd/tests/bench-text-encoder.c++

3.3 ms3.2 ms

bm_Http_FullProtocol

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

76.1 µs76.1 µs

request[GlobalScopeBenchmark]

src/workerd/tests/bench-global-scope.c++

51.3 ms51.3 ms

EncodeInto_ASCII_256[TextEncoder][1/0/256]

src/workerd/tests/bench-text-encoder.c++

2.4 ms2.4 ms

bm_Http_OverCapnpFullRPC

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

235.6 µs235.6 µs

Test_JSON_DEC

src/workerd/tests/bench-json.c++

3.2 s3.2 s

EncodeInto_TwoByte_1024[TextEncoder][1/2/1024]

src/workerd/tests/bench-text-encoder.c++

14.1 ms14.1 ms

Encode_OneByte_8192[TextEncoder][0/1/8192]

src/workerd/tests/bench-text-encoder.c++

84.7 ms84.7 ms

JsString_Utf8Length_Utf16_NonFlat_256

src/workerd/tests/bench-jsstring.c++

8.8 µs8.8 µs

bm_Http_ClientWrapper

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

35.7 µs35.7 µs

JsString_Utf8Length_Utf16_NonFlat_1024

src/workerd/tests/bench-jsstring.c++

16.1 µs16.1 µs

JsString_Utf8Length_Utf16_Invalid_NonFlat_8192

src/workerd/tests/bench-jsstring.c++

73.7 µs73.7 µs

JsString_Utf8Length_Utf16_Invalid_NonFlat_256

src/workerd/tests/bench-jsstring.c++

8.8 µs8.8 µs

bm_Http_Baseline

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

11.2 µs11.2 µs

bm_Coro_Fib10

external/+http+capnp-cpp/src/kj/async-bench.c++

14.8 µs14.8 µs

arrayBufferBody[Response]

src/workerd/tests/bench-response.c++

17.5 µs17.5 µs

ParseAndSerialize

src/workerd/tests/bench-mimetype.c++::Mimetype

74.9 ms74.9 ms

bm_Coro_CoAwait_ImmediateCoroutine

external/+http+capnp-cpp/src/kj/async-bench.c++

6.1 µs6.1 µs

JsString_Utf8Length_Utf16_NonFlat_8192

src/workerd/tests/bench-jsstring.c++

73.7 µs73.7 µs

Parse[KjHeaders]

src/workerd/tests/bench-kj-headers.c++

44.3 µs44.3 µs

bm_Coro_CoAwait_ImmediatePromise

external/+http+capnp-cpp/src/kj/async-bench.c++

5.9 µs5.9 µs

Serialize

src/workerd/tests/bench-mimetype.c++::Mimetype

74.6 ms74.6 ms

Commits

Click on a commit to change the comparison range

Base

main

a89ad60

+13.08%

Do not propagate exception inside HTMLRewriter parser

ccb8ecd

6 days ago

by ryanking13

Home Terms Privacy Docs