cloudflare
workerd
BlogDocsChangelog

[o11y] Fix unused WorkerTracer warnings in R2

#5756
Comparing
felix/122325-stw-unused-tracer
(
346bcd3
) with
main
(
7a5c452
)
CodSpeed Performance Gauge
-12%
Regressions
1
Untouched
56
Skipped
34

Benchmarks

Skipped (34)

Encode_ASCII_8192[TextEncoderBenchmark]
src/workerd/tests/bench-text-encoder.c++
Skipped
584.5 µs*
Encode_ASCII_256[TextEncoderBenchmark]
src/workerd/tests/bench-text-encoder.c++
Skipped
530.7 µs*
Encode_TwoByte_256[TextEncoderBenchmark]
src/workerd/tests/bench-text-encoder.c++
Skipped
531.7 µs*
Encode_ASCII_32[TextEncoderBenchmark]
src/workerd/tests/bench-text-encoder.c++
Skipped
527.6 µs*
Encode_ASCII_1024[TextEncoderBenchmark]
src/workerd/tests/bench-text-encoder.c++
Skipped
535 µs*
Encode_OneByte_256[TextEncoderBenchmark]
src/workerd/tests/bench-text-encoder.c++
Skipped
529.3 µs*
EncodeInto_OneByte_256[TextEncoderBenchmark]
src/workerd/tests/bench-text-encoder.c++
Skipped
541.3 µs*
EncodeInto_ASCII_256[TextEncoderBenchmark]
src/workerd/tests/bench-text-encoder.c++
Skipped
538.3 µs*
EncodeInto_TwoByte_256[TextEncoderBenchmark]
src/workerd/tests/bench-text-encoder.c++
Skipped
541 µs*
Encode_ASCII_1024[0/0/1024]
unknown_file
Skipped
3.7 ms*
EncodeInto_ASCII_1024[1/0/1024]
unknown_file
Skipped
2.6 ms*
Encode_TwoByte_256[0/2/256]
unknown_file
Skipped
7.1 ms*
ParseAndSerialize
Mimetype
Skipped
74.9 ms*
Encode_ASCII_256[0/0/256]
unknown_file
Skipped
3.2 ms*
Encode_ASCII_8192[0/0/8192]
unknown_file
Skipped
13.1 ms*
EncodeInto_ASCII_8192[1/0/8192]
unknown_file
Skipped
3.3 ms*
Encode_OneByte_256[0/1/256]
unknown_file
Skipped
5.3 ms*
Encode_ASCII_32[0/0/32]
unknown_file
Skipped
3 ms*
Encode_OneByte_1024[0/1/1024]
unknown_file
Skipped
12.1 ms*
Encode_OneByte_8192[0/1/8192]
unknown_file
Skipped
85.2 ms*
EncodeInto_OneByte_256[1/1/256]
unknown_file
Skipped
4.5 ms*
EncodeInto_OneByte_1024[1/1/1024]
unknown_file
Skipped
10.5 ms*
EncodeInto_OneByte_8192[1/1/8192]
unknown_file
Skipped
66.9 ms*
EncodeInto_ASCII_256[1/0/256]
unknown_file
Skipped
2.6 ms*
EncodeInto_TwoByte_8192[1/2/8192]
unknown_file
Skipped
96.7 ms*
EncodeInto_TwoByte_256[1/2/256]
unknown_file
Skipped
5.4 ms*
Serialize
Mimetype
Skipped
74.6 ms*
EncodeInto_TwoByte_1024[1/2/1024]
unknown_file
Skipped
14.2 ms*
Encode_TwoByte_1024[0/2/1024]
unknown_file
Skipped
19.6 ms*
Encode_TwoByte_8192[0/2/8192]
unknown_file
Skipped
146.2 ms*
bm_ReadyNow
external/capnp-cpp/src/kj/async-bench.c++
Skipped
2.1 µs*
bm_Immediate
external/capnp-cpp/src/kj/async-bench.c++
Skipped
3.6 µs*
bm_coroCoAwaitImmediate
external/capnp-cpp/src/kj/async-bench.c++
Skipped
6.2 µs*
bm_coroCoReturn
external/capnp-cpp/src/kj/async-bench.c++
Skipped
4.6 µs*

Failed

Encode_ASCII_32[TextEncoder][0/0/32]
src/workerd/tests/bench-text-encoder.c++
Regression
CodSpeed Performance Gauge
-12%
2.9 ms3.3 ms

Passed

simpleStringBody[Response]
src/workerd/tests/bench-response.c++
CodSpeed Performance Gauge
+1%
21.8 µs21.6 µs
nullBodyWithStatus[Response]
src/workerd/tests/bench-response.c++
CodSpeed Performance Gauge
+1%
10.3 µs10.2 µs
EncodeInto_ASCII_256[TextEncoder][1/0/256]
src/workerd/tests/bench-text-encoder.c++
CodSpeed Performance Gauge
+1%
2.6 ms2.6 ms
arrayBufferBody[Response]
src/workerd/tests/bench-response.c++
CodSpeed Performance Gauge
+1%
17.6 µs17.5 µs
EncodeInto_ASCII_8192[TextEncoder][1/0/8192]
src/workerd/tests/bench-text-encoder.c++
CodSpeed Performance Gauge
0%
3.4 ms3.4 ms
set_append[ApiHeaders]
src/workerd/tests/bench-api-headers.c++
CodSpeed Performance Gauge
0%
11.7 ms11.7 ms
Encode_OneByte_256[TextEncoder][0/1/256]
src/workerd/tests/bench-text-encoder.c++
CodSpeed Performance Gauge
0%
5.2 ms5.1 ms
Encode_TwoByte_256[TextEncoder][0/2/256]
src/workerd/tests/bench-text-encoder.c++
CodSpeed Performance Gauge
0%
7 ms7 ms
request[RegExpBenchmark]
src/workerd/tests/bench-regex.c++
CodSpeed Performance Gauge
0%
7.3 ms7.3 ms
Encode_OneByte_1024[TextEncoder][0/1/1024]
src/workerd/tests/bench-text-encoder.c++
CodSpeed Performance Gauge
0%
12 ms12 ms
jsonResponse[Response]
src/workerd/tests/bench-response.c++
CodSpeed Performance Gauge
0%
34.9 µs34.9 µs
EncodeInto_OneByte_1024[TextEncoder][1/1/1024]
src/workerd/tests/bench-text-encoder.c++
CodSpeed Performance Gauge
0%
10.5 ms10.5 ms
Encode_OneByte_8192[TextEncoder][0/1/8192]
src/workerd/tests/bench-text-encoder.c++
CodSpeed Performance Gauge
0%
84.7 ms84.7 ms
EncodeInto_OneByte_8192[TextEncoder][1/1/8192]
src/workerd/tests/bench-text-encoder.c++
CodSpeed Performance Gauge
0%
66.7 ms66.7 ms
Encode_ASCII_8192[TextEncoder][0/0/8192]
src/workerd/tests/bench-text-encoder.c++
CodSpeed Performance Gauge
0%
13.2 ms13.2 ms
EncodeInto_TwoByte_256[TextEncoder][1/2/256]
src/workerd/tests/bench-text-encoder.c++
CodSpeed Performance Gauge
0%
5.4 ms5.4 ms
Util_RecursivelyFreeze
src/workerd/tests/bench-util.c++
CodSpeed Performance Gauge
0%
10.8 ms10.8 ms
bm_ReadyNow
external/+http+capnp-cpp/src/kj/async-bench.c++
CodSpeed Performance Gauge
0%
2.1 µs2.1 µs
bm_coroCoAwaitImmediate
external/+http+capnp-cpp/src/kj/async-bench.c++
CodSpeed Performance Gauge
0%
6.2 µs6.2 µs
bm_Immediate
external/+http+capnp-cpp/src/kj/async-bench.c++
CodSpeed Performance Gauge
0%
3.6 µs3.6 µs
bm_coroCoReturn
external/+http+capnp-cpp/src/kj/async-bench.c++
CodSpeed Performance Gauge
0%
4.6 µs4.6 µs
JsString_Utf8Length_Latin1_Flat_32
src/workerd/tests/bench-jsstring.c++
CodSpeed Performance Gauge
0%
861.9 ns861.9 ns
JsString_Utf8Length_Latin1_Flat_256
src/workerd/tests/bench-jsstring.c++
CodSpeed Performance Gauge
0%
1.7 µs1.7 µs
JsString_Utf8Length_Latin1_Flat_8192
src/workerd/tests/bench-jsstring.c++
CodSpeed Performance Gauge
0%
31 µs31 µs
JsString_Utf8Length_Latin1_Flat_1024
src/workerd/tests/bench-jsstring.c++
CodSpeed Performance Gauge
0%
4.6 µs4.6 µs
JsString_Utf8Length_Utf16_Flat_8192
src/workerd/tests/bench-jsstring.c++
CodSpeed Performance Gauge
0%
62.8 µs62.8 µs
JsString_Utf8Length_Latin1_NonFlat_256
src/workerd/tests/bench-jsstring.c++
CodSpeed Performance Gauge
0%
7.9 µs7.9 µs
JsString_Utf8Length_Latin1_NonFlat_8192
src/workerd/tests/bench-jsstring.c++
CodSpeed Performance Gauge
0%
42 µs42 µs
JsString_Utf8Length_Latin1_NonFlat_1024
src/workerd/tests/bench-jsstring.c++
CodSpeed Performance Gauge
0%
12.1 µs12.1 µs
JsString_Utf8Length_Utf16_Flat_1024
src/workerd/tests/bench-jsstring.c++
CodSpeed Performance Gauge
0%
8.5 µs8.5 µs
JsString_Utf8Length_Utf16_Flat_256
src/workerd/tests/bench-jsstring.c++
CodSpeed Performance Gauge
0%
2.7 µs2.7 µs
JsString_Utf8Length_Utf16_Invalid_Flat_256
src/workerd/tests/bench-jsstring.c++
CodSpeed Performance Gauge
0%
2.7 µs2.7 µs
JsString_Utf8Length_Utf16_Invalid_Flat_1024
src/workerd/tests/bench-jsstring.c++
CodSpeed Performance Gauge
0%
8.5 µs8.5 µs
JsString_Utf8Length_Utf16_Invalid_Flat_8192
src/workerd/tests/bench-jsstring.c++
CodSpeed Performance Gauge
0%
62.8 µs62.8 µs
JsString_Utf8Length_Utf16_Invalid_NonFlat_1024
src/workerd/tests/bench-jsstring.c++
CodSpeed Performance Gauge
0%
16.2 µs16.2 µs
JsString_Utf8Length_Utf16_Invalid_NonFlat_256
src/workerd/tests/bench-jsstring.c++
CodSpeed Performance Gauge
0%
8.9 µs8.9 µs
Parse[KjHeaders]
src/workerd/tests/bench-kj-headers.c++
CodSpeed Performance Gauge
0%
44.3 µs44.3 µs
JsString_Utf8Length_Utf16_NonFlat_256
src/workerd/tests/bench-jsstring.c++
CodSpeed Performance Gauge
0%
8.9 µs8.9 µs
JsString_Utf8Length_Utf16_NonFlat_8192
src/workerd/tests/bench-jsstring.c++
CodSpeed Performance Gauge
0%
73.8 µs73.8 µs
JsString_Utf8Length_Utf16_Invalid_NonFlat_8192
src/workerd/tests/bench-jsstring.c++
CodSpeed Performance Gauge
0%
73.8 µs73.8 µs
JsString_Utf8Length_Utf16_NonFlat_1024
src/workerd/tests/bench-jsstring.c++
CodSpeed Performance Gauge
0%
16.1 µs16.1 µs
Test_JSON_ENC
src/workerd/tests/bench-json.c++
CodSpeed Performance Gauge
0%
206 ms206 ms
request[GlobalScopeBenchmark]
src/workerd/tests/bench-global-scope.c++
CodSpeed Performance Gauge
0%
52.6 ms52.6 ms
bodyWithHeaders[Response]
src/workerd/tests/bench-response.c++
CodSpeed Performance Gauge
0%
24.4 µs24.4 µs
Encode_ASCII_256[TextEncoder][0/0/256]
src/workerd/tests/bench-text-encoder.c++
CodSpeed Performance Gauge
0%
3.1 ms3.1 ms
Encode_TwoByte_8192[TextEncoder][0/2/8192]
src/workerd/tests/bench-text-encoder.c++
CodSpeed Performance Gauge
0%
146.1 ms146.1 ms
EncodeInto_TwoByte_8192[TextEncoder][1/2/8192]
src/workerd/tests/bench-text-encoder.c++
CodSpeed Performance Gauge
0%
96.7 ms96.7 ms
Serialize
src/workerd/tests/bench-mimetype.c++::Mimetype
CodSpeed Performance Gauge
0%
74.6 ms74.6 ms
ParseAndSerialize
src/workerd/tests/bench-mimetype.c++::Mimetype
CodSpeed Performance Gauge
0%
74.9 ms74.9 ms
EncodeInto_OneByte_256[TextEncoder][1/1/256]
src/workerd/tests/bench-text-encoder.c++
CodSpeed Performance Gauge
0%
4.5 ms4.5 ms
constructor[ApiHeaders]
src/workerd/tests/bench-api-headers.c++
CodSpeed Performance Gauge
0%
67.6 ms67.6 ms
EncodeInto_ASCII_1024[TextEncoder][1/0/1024]
src/workerd/tests/bench-text-encoder.c++
CodSpeed Performance Gauge
0%
2.7 ms2.7 ms
Test_JSON_DEC
src/workerd/tests/bench-json.c++
CodSpeed Performance Gauge
0%
3.2 s3.2 s
Encode_TwoByte_1024[TextEncoder][0/2/1024]
src/workerd/tests/bench-text-encoder.c++
CodSpeed Performance Gauge
0%
19.5 ms19.5 ms
EncodeInto_TwoByte_1024[TextEncoder][1/2/1024]
src/workerd/tests/bench-text-encoder.c++
CodSpeed Performance Gauge
0%
14.2 ms14.2 ms
Encode_ASCII_1024[TextEncoder][0/0/1024]
src/workerd/tests/bench-text-encoder.c++
CodSpeed Performance Gauge
0%
3.7 ms3.7 ms

Commits

Click on a commit to change the comparison range
Base
main
7a5c452
-11.71%
[o11y] Fix unused WorkerTracer warnings in R2 With #5685, we managed to reduce the volume of "destructed WorkerTracer" warnings by >80% by eliminating it in the case of duplicate alarm events. Another case where this happens are R2 API calls where we create a new WorkerInterface for the R2 call before completing error checking, as seen in the r2-test itself. We can easily avoid this by moving getHttpClient() calls behind error checks. While this PR is not aiming for completion I also cleaned up a call in web-socket.c++ that may be susceptible to the same issue.
346bcd3
20 hours ago
by fhanau
© 2025 CodSpeed Technology
Home Terms Privacy Docs