[o11y] Assorted Streaming Tail Worker bug fixes
#4637Comparing
felix/072925-STW-bug-fixes
(4a0c367
) withmain
(cb14582
)0%
- Improvements
- 0
- Regressions
- 0
- Untouched
- 9
- New
- 0
- Dropped
- 0
- Ignored
- 0
Benchmarks
Passed
request[RegExpBenchmark]
src/workerd/tests/bench-regex.c++::request[RegExpBenchmark]0%
7.5 ms
7.4 ms
request[GlobalScopeBenchmark]
src/workerd/tests/bench-global-scope.c++::request[GlobalScopeBenchmark]0%
57.2 ms
57.1 ms
constructor[ApiHeaders]
src/workerd/tests/bench-api-headers.c++::constructor[ApiHeaders]0%
70.9 ms
70.9 ms
Test_JSON_ENC
src/workerd/tests/bench-json.c++::Test_JSON_ENC0%
196.1 ms
196 ms
Serialize
Mimetype::Serialize0%
96.9 ms
96.9 ms
Parse[KjHeaders]
src/workerd/tests/bench-kj-headers.c++::Parse[KjHeaders]0%
44.3 µs
44.3 µs
Util_RecursivelyFreeze
src/workerd/tests/bench-util.c++::Util_RecursivelyFreeze0%
10.9 ms
10.9 ms
ParseAndSerialize
Mimetype::ParseAndSerialize0%
78.6 ms
78.6 ms
Test_JSON_DEC
src/workerd/tests/bench-json.c++::Test_JSON_DEC0%
3.2 s
3.2 s
Commits
Click on a commit to change the comparison rangeBase
main
cb14582
0%
[o11y] Assorted Streaming Tail Worker bug fixes
This may address two bugs seen in testing (which have not been reproduced yet).
- Do not provide outcome event for pipelineLogLevel == PipelineLogLevel::NONE,
we already don't provide the other event types there (matching the legacy tail
worker).
- Do not assert that a handler context is available
- Do not try to accept more events if we failed to get a JS-level handler. This
may fix "Expected only a single onset event" errors under a race condition
where the client sends an event right after the onset, before the server can
indicate that no additional events should be sent based on the invalid
handler.
4a0c367
2 days ago
by fhanau