felix/041026-fix-empty-handler-error - Branch - cloudflare/workerd

[o11y] Avoid tail stream cancellation warning with empty handler

#6560Merged

Comparing

felix/041026-fix-empty-handler-error

(

d8dfd8d

) with

main

(

50c021a

)

-13%

Regression: 1

Untouched: 69

Skipped: 129

Benchmarks

199 total

Encode_ASCII_32[TextEncoder][0/0/32]

src/workerd/tests/bench-text-encoder.c++

-13%

2.7 ms3.1 ms

arrayBufferBody[Response]

src/workerd/tests/bench-response.c++

17 µs17 µs

nullBodyWithStatus[Response]

src/workerd/tests/bench-response.c++

10.4 µs10.4 µs

jsonResponse[Response]

src/workerd/tests/bench-response.c++

40.6 µs40.5 µs

bodyWithHeaders[Response]

src/workerd/tests/bench-response.c++

30.6 µs30.5 µs

simpleStringBody[Response]

src/workerd/tests/bench-response.c++

19.3 µs19.3 µs

EncodeInto_ASCII_8192[TextEncoder][1/0/8192]

src/workerd/tests/bench-text-encoder.c++

3.6 ms3.6 ms

request[GlobalScopeBenchmark]

src/workerd/tests/bench-global-scope.c++

52.4 ms52.4 ms

Encode_TwoByte_256[TextEncoder][0/2/256]

src/workerd/tests/bench-text-encoder.c++

6 ms6 ms

Encode_ASCII_8192[TextEncoder][0/0/8192]

src/workerd/tests/bench-text-encoder.c++

13.1 ms13.1 ms

EncodeInto_ASCII_256[TextEncoder][1/0/256]

src/workerd/tests/bench-text-encoder.c++

2.4 ms2.4 ms

Encode_TwoByte_1024[TextEncoder][0/2/1024]

src/workerd/tests/bench-text-encoder.c++

16 ms16 ms

request[RegExpBenchmark]

src/workerd/tests/bench-regex.c++

6.9 ms6.9 ms

Test_JSON_DEC

src/workerd/tests/bench-json.c++

3.3 s3.3 s

EncodeInto_TwoByte_256[TextEncoder][1/2/256]

src/workerd/tests/bench-text-encoder.c++

5.3 ms5.3 ms

constructor[ApiHeaders]

src/workerd/tests/bench-api-headers.c++

69.5 ms69.5 ms

bm_Http_FullProtocol

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

74.2 µs74.2 µs

Encode_ASCII_1024[TextEncoder][0/0/1024]

src/workerd/tests/bench-text-encoder.c++

3.3 ms3.3 ms

set_append[ApiHeaders]

src/workerd/tests/bench-api-headers.c++

12.1 ms12.1 ms

Encode_ASCII_256[TextEncoder][0/0/256]

src/workerd/tests/bench-text-encoder.c++

2.7 ms2.7 ms

Encode_OneByte_1024[TextEncoder][0/1/1024]

src/workerd/tests/bench-text-encoder.c++

11.5 ms11.5 ms

EncodeInto_OneByte_8192[TextEncoder][1/1/8192]

src/workerd/tests/bench-text-encoder.c++

66.5 ms66.5 ms

bm_Http_ClientWrapper

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

34.9 µs34.9 µs

EncodeInto_ASCII_1024[TextEncoder][1/0/1024]

src/workerd/tests/bench-text-encoder.c++

2.5 ms2.5 ms

Encode_TwoByte_8192[TextEncoder][0/2/8192]

src/workerd/tests/bench-text-encoder.c++

119 ms119 ms

Commits

Click on a commit to change the comparison range

Base

main

50c021a

-12.83%

[o11y] Avoid tail stream cancellation warning with empty handler

d8dfd8d

5 months ago

by fhanau

Home Terms Privacy Docs