edmundhung/fix-formdata-union-overloads - Branch - cloudflare/workerd

Add missing union overloads to FormData type definitions

#5946

Comparing

edmundhung/fix-formdata-union-overloads

(

bf83ba3

) with

main

(

2752663

)

-12%

Regression: 2

Untouched: 68

Skipped: 129

Benchmarks

199 total

Encode_ASCII_32[TextEncoder][0/0/32]

src/workerd/tests/bench-text-encoder.c++

-12%

3 ms3.4 ms

simpleStringBody[Response]

src/workerd/tests/bench-response.c++

-11%

19.1 µs21.6 µs

request[RegExpBenchmark]

src/workerd/tests/bench-regex.c++

7.3 ms7.3 ms

request[GlobalScopeBenchmark]

src/workerd/tests/bench-global-scope.c++

51.8 ms51.7 ms

EncodeInto_OneByte_8192[TextEncoder][1/1/8192]

src/workerd/tests/bench-text-encoder.c++

66.6 ms66.6 ms

Encode_OneByte_256[TextEncoder][0/1/256]

src/workerd/tests/bench-text-encoder.c++

5.2 ms5.2 ms

Encode_TwoByte_256[TextEncoder][0/2/256]

src/workerd/tests/bench-text-encoder.c++

7 ms7 ms

EncodeInto_ASCII_256[TextEncoder][1/0/256]

src/workerd/tests/bench-text-encoder.c++

2.5 ms2.5 ms

EncodeInto_OneByte_256[TextEncoder][1/1/256]

src/workerd/tests/bench-text-encoder.c++

4.5 ms4.5 ms

Encode_ASCII_256[TextEncoder][0/0/256]

src/workerd/tests/bench-text-encoder.c++

3.2 ms3.2 ms

EncodeInto_OneByte_1024[TextEncoder][1/1/1024]

src/workerd/tests/bench-text-encoder.c++

10.4 ms10.4 ms

bm_Http_OverCapnpFullRPC

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

238.1 µs238.1 µs

EncodeInto_TwoByte_256[TextEncoder][1/2/256]

src/workerd/tests/bench-text-encoder.c++

5.4 ms5.4 ms

Encode_TwoByte_8192[TextEncoder][0/2/8192]

src/workerd/tests/bench-text-encoder.c++

146.1 ms146.1 ms

bm_Http_ClientWrapper

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

35.8 µs35.8 µs

JsString_Utf8Length_Utf16_Invalid_NonFlat_256

src/workerd/tests/bench-jsstring.c++

8.9 µs8.9 µs

bm_Http_Baseline

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

11.5 µs11.5 µs

Parse[KjHeaders]

src/workerd/tests/bench-kj-headers.c++

44.2 µs44.2 µs

JsString_Utf8Length_Utf16_NonFlat_256

src/workerd/tests/bench-jsstring.c++

8.9 µs8.9 µs

JsString_Utf8Length_Utf16_NonFlat_1024

src/workerd/tests/bench-jsstring.c++

16.2 µs16.2 µs

Serialize

src/workerd/tests/bench-mimetype.c++::Mimetype

74.6 ms74.6 ms

JsString_Utf8Length_Utf16_Invalid_NonFlat_8192

src/workerd/tests/bench-jsstring.c++

73.8 µs73.8 µs

bm_Coro_Immediate

external/+http+capnp-cpp/src/kj/async-bench.c++

4.2 µs4.2 µs

bm_Coro_CoAwait_ImmediateCoroutine

external/+http+capnp-cpp/src/kj/async-bench.c++

6.4 µs6.4 µs

nullBodyWithStatus[Response]

src/workerd/tests/bench-response.c++

10.2 µs10.2 µs

Commits

Click on a commit to change the comparison range

Base

main

2752663

-11.51%

Add missing union overloads to FormData type definitions

bf83ba3

2 days ago

by edmundhung

Home Terms Privacy Docs