dmmulroy:dmmulroy/fix-serializable-type - Branch - cloudflare/workerd

fix(types): filter symbol keys in Rpc.Serializable mapped type

#5804

Comparing

dmmulroy:dmmulroy/fix-serializable-type

(

4bcf012

) with

main

(

7d0bd27

)

-18%

Improvement: 1

Regression: 1

Untouched: 66

Skipped: 129

Benchmarks

197 total

jsonResponse[Response]

src/workerd/tests/bench-response.c++

-18%

35 µs42.8 µs

Encode_ASCII_32[TextEncoder][0/0/32]

src/workerd/tests/bench-text-encoder.c++

+13%

3.4 ms3 ms

simpleStringBody[Response]

src/workerd/tests/bench-response.c++

+3%

20 µs19.4 µs

bodyWithHeaders[Response]

src/workerd/tests/bench-response.c++

+2%

25.1 µs24.6 µs

Encode_ASCII_1024[TextEncoder][0/0/1024]

src/workerd/tests/bench-text-encoder.c++

3.7 ms3.7 ms

Encode_OneByte_1024[TextEncoder][0/1/1024]

src/workerd/tests/bench-text-encoder.c++

12 ms12 ms

set_append[ApiHeaders]

src/workerd/tests/bench-api-headers.c++

11.7 ms11.7 ms

Test_JSON_DEC

src/workerd/tests/bench-json.c++

3.2 s3.2 s

Encode_TwoByte_256[TextEncoder][0/2/256]

src/workerd/tests/bench-text-encoder.c++

7.1 ms7.1 ms

Test_JSON_ENC

src/workerd/tests/bench-json.c++

207.2 ms207.2 ms

constructor[ApiHeaders]

src/workerd/tests/bench-api-headers.c++

67.6 ms67.6 ms

ParseAndSerialize

src/workerd/tests/bench-mimetype.c++::Mimetype

74.9 ms74.9 ms

EncodeInto_ASCII_8192[TextEncoder][1/0/8192]

src/workerd/tests/bench-text-encoder.c++

3.4 ms3.4 ms

bm_Http_FullProtocol

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

77.9 µs77.9 µs

Serialize

src/workerd/tests/bench-mimetype.c++::Mimetype

74.6 ms74.6 ms

bm_Http_ClientWrapper

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

36 µs36 µs

EncodeInto_TwoByte_256[TextEncoder][1/2/256]

src/workerd/tests/bench-text-encoder.c++

5.4 ms5.4 ms

Encode_OneByte_256[TextEncoder][0/1/256]

src/workerd/tests/bench-text-encoder.c++

5.2 ms5.2 ms

EncodeInto_OneByte_1024[TextEncoder][1/1/1024]

src/workerd/tests/bench-text-encoder.c++

10.5 ms10.5 ms

Encode_TwoByte_8192[TextEncoder][0/2/8192]

src/workerd/tests/bench-text-encoder.c++

146.2 ms146.2 ms

EncodeInto_TwoByte_8192[TextEncoder][1/2/8192]

src/workerd/tests/bench-text-encoder.c++

96.7 ms96.7 ms

JsString_Utf8Length_Utf16_NonFlat_256

src/workerd/tests/bench-jsstring.c++

9 µs9 µs

bm_Http_Baseline

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

11.8 µs11.8 µs

JsString_Utf8Length_Utf16_Invalid_NonFlat_8192

src/workerd/tests/bench-jsstring.c++

73.9 µs73.9 µs

JsString_Utf8Length_Utf16_NonFlat_8192

src/workerd/tests/bench-jsstring.c++

73.9 µs73.9 µs

Commits

Click on a commit to change the comparison range

Base

main

7d0bd27

fix(types): filter symbol keys in Rpc.Serializable mapped type

9cb7813

22 days ago

by dmmulroy

-18.18%

Merge branch 'main' into dmmulroy/fix-serializable-type

4bcf012

6 days ago

by dmmulroy

Home Terms Privacy Docs