dmmulroy:dmmulroy/fix-serializable-type - Branch - cloudflare/workerd

fix(types): filter symbol keys in Rpc.Serializable mapped type

#5804

Comparing

dmmulroy:dmmulroy/fix-serializable-type

(

161303e

) with

main

(

08419cb

)

-19%

Improvement: 1

Untouched: 69

Skipped: 129

Benchmarks

199 total

Encode_ASCII_32[TextEncoder][0/0/32]

src/workerd/tests/bench-text-encoder.c++

+13%

3.3 ms2.9 ms

jsonResponse[Response]

src/workerd/tests/bench-response.c++

-19%

34.7 µs42.6 µs

bodyWithHeaders[Response]

src/workerd/tests/bench-response.c++

24.9 µs24.8 µs

simpleStringBody[Response]

src/workerd/tests/bench-response.c++

19.1 µs19.1 µs

EncodeInto_ASCII_8192[TextEncoder][1/0/8192]

src/workerd/tests/bench-text-encoder.c++

3.3 ms3.2 ms

request[GlobalScopeBenchmark]

src/workerd/tests/bench-global-scope.c++

51.4 ms51.4 ms

Encode_ASCII_8192[TextEncoder][0/0/8192]

src/workerd/tests/bench-text-encoder.c++

13.3 ms13.3 ms

Encode_ASCII_256[TextEncoder][0/0/256]

src/workerd/tests/bench-text-encoder.c++

3.1 ms3.1 ms

bm_Http_FullProtocol

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

76.1 µs76.1 µs

EncodeInto_ASCII_256[TextEncoder][1/0/256]

src/workerd/tests/bench-text-encoder.c++

2.4 ms2.4 ms

EncodeInto_TwoByte_8192[TextEncoder][1/2/8192]

src/workerd/tests/bench-text-encoder.c++

96.6 ms96.6 ms

Encode_ASCII_1024[TextEncoder][0/0/1024]

src/workerd/tests/bench-text-encoder.c++

3.6 ms3.6 ms

Encode_OneByte_1024[TextEncoder][0/1/1024]

src/workerd/tests/bench-text-encoder.c++

11.9 ms11.9 ms

set_append[ApiHeaders]

src/workerd/tests/bench-api-headers.c++

11.7 ms11.7 ms

Encode_OneByte_256[TextEncoder][0/1/256]

src/workerd/tests/bench-text-encoder.c++

5.1 ms5.1 ms

EncodeInto_ASCII_1024[TextEncoder][1/0/1024]

src/workerd/tests/bench-text-encoder.c++

2.5 ms2.5 ms

request[RegExpBenchmark]

src/workerd/tests/bench-regex.c++

7.3 ms7.3 ms

EncodeInto_TwoByte_256[TextEncoder][1/2/256]

src/workerd/tests/bench-text-encoder.c++

5.3 ms5.3 ms

bm_Http_OverCapnpFullRPC

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

235.6 µs235.6 µs

EncodeInto_OneByte_256[TextEncoder][1/1/256]

src/workerd/tests/bench-text-encoder.c++

4.4 ms4.4 ms

Encode_TwoByte_1024[TextEncoder][0/2/1024]

src/workerd/tests/bench-text-encoder.c++

19.5 ms19.5 ms

Encode_TwoByte_256[TextEncoder][0/2/256]

src/workerd/tests/bench-text-encoder.c++

7 ms7 ms

EncodeInto_OneByte_8192[TextEncoder][1/1/8192]

src/workerd/tests/bench-text-encoder.c++

66.6 ms66.6 ms

Encode_OneByte_8192[TextEncoder][0/1/8192]

src/workerd/tests/bench-text-encoder.c++

84.8 ms84.8 ms

bm_Http_OverCapnpLocalCall

external/+http+capnp-cpp/src/capnp/compat/http-over-capnp-bench.c++

128.4 µs128.4 µs

Commits

Click on a commit to change the comparison range

Base

main

08419cb

+13.38%

fix: update type tests and snapshots for Serializable change

5eb0216

6 months ago

by petebacondarwin

-31.88%

fixup snapshots

161303e

6 months ago

by petebacondarwin

Home Terms Privacy Docs