Comparing
konsti/update-pubgrub-dp-impl
(9c3c40a
) withmain
(a241f14
)+1%
- Improvements
- 0
- Regressions
- 0
- Untouched
- 13
- New
- 0
- Dropped
- 0
- Ignored
- 0
Benchmarks
Passed
resolve_warm_jupyter
crates/bench/benches/uv.rs::uv::resolve_warm_jupyter::resolve_warm_jupyter+5%
88.9 ms
84.7 ms
wheelname_tag_compatibility[flyte-short-incompatible]
crates/bench/benches/distribution_filename.rs::distribution_filename::benchmark_wheelname_tag_compatibility::wheelname_tag_compatibility[flyte-short-incompatible]+3%
926.7 ns
897.5 ns
wheelname_tag_compatibility[flyte-short-compatible]
crates/bench/benches/distribution_filename.rs::distribution_filename::benchmark_wheelname_tag_compatibility::wheelname_tag_compatibility[flyte-short-compatible]+1%
2.1 µs
2 µs
wheelname_tag_compatibility[flyte-long-compatible]
crates/bench/benches/distribution_filename.rs::distribution_filename::benchmark_wheelname_tag_compatibility::wheelname_tag_compatibility[flyte-long-compatible]+1%
2.1 µs
2.1 µs
wheelname_parsing[flyte-short-compatible]
crates/bench/benches/distribution_filename.rs::distribution_filename::benchmark_wheelname_parsing::wheelname_parsing[flyte-short-compatible]0%
6.4 µs
6.4 µs
wheelname_parsing[flyte-short-incompatible]
crates/bench/benches/distribution_filename.rs::distribution_filename::benchmark_wheelname_parsing::wheelname_parsing[flyte-short-incompatible]0%
6.4 µs
6.4 µs
wheelname_parsing_failure[flyte-long-extension]
crates/bench/benches/distribution_filename.rs::distribution_filename::benchmark_wheelname_parsing_failure::wheelname_parsing_failure[flyte-long-extension]0%
1.9 µs
1.9 µs
wheelname_parsing_failure[flyte-short-extension]
crates/bench/benches/distribution_filename.rs::distribution_filename::benchmark_wheelname_parsing_failure::wheelname_parsing_failure[flyte-short-extension]0%
1.9 µs
1.9 µs
wheelname_tag_compatibility[flyte-long-incompatible]
crates/bench/benches/distribution_filename.rs::distribution_filename::benchmark_wheelname_tag_compatibility::wheelname_tag_compatibility[flyte-long-incompatible]0%
1.5 µs
1.5 µs
wheelname_parsing[flyte-long-incompatible]
crates/bench/benches/distribution_filename.rs::distribution_filename::benchmark_wheelname_parsing::wheelname_parsing[flyte-long-incompatible]0%
12.8 µs
12.8 µs
wheelname_parsing[flyte-long-compatible]
crates/bench/benches/distribution_filename.rs::distribution_filename::benchmark_wheelname_parsing::wheelname_parsing[flyte-long-compatible]0%
9.9 µs
10 µs
resolve_warm_airflow
crates/bench/benches/uv.rs::uv::resolve_warm_airflow::resolve_warm_airflow-1%
1.3 s
1.3 s
Commits
Click on a commit to change the comparison rangeBase
main
a241f14
+1%
Update pubgrub to new `add_incompatibility_from_dependencies`
We had previously changed the signature of `DependencyProvider::get_dependencies` to return an iterator instead of a hashmap to avoid the conversion cost from our dependencies `Vec` to the pubgrub's hashmap. These changes are difficult to make in pubgrub since they complicate the public api. But we don't actually use `DependencyProvider::get_dependencies`, so we rolled those customizations back in https://github.com/pubgrub-rs/pubgrub/pull/226 and instead opted to change only the internal `add_incompatibility_from_dependencies` method that we exposed in our fork. This aligns us closer with upstream, removes the design questions about `DependencyProvider` from our concerns and reduces our diff (not counting the github action) to +36 -12.
9c3c40a
7 months ago
by konstin