RazerM:feature/uv-add-sorted-with-include-group - Branch - astral-sh/uv

astral-sh

Blog Docs Changelog

Fix detection of sorted dependencies when include-group is used

#13354Merged

Comparing

RazerM:feature/uv-add-sorted-with-include-group

(

0188e59

) with

main

(

8d6d616

)

Untouched: 12

Benchmarks

Passed

resolve_warm_jupyter

crates/uv-bench/benches/uv.rs::uv::resolve_warm_jupyter

+2%

60.8 ms59.7 ms

wheelname_parsing[flyte-long-compatible]

crates/uv-bench/benches/distribution_filename.rs::uv_distribution_filename::benchmark_wheelname_parsing

13.4 µs13.4 µs

wheelname_parsing[flyte-long-incompatible]

crates/uv-bench/benches/distribution_filename.rs::uv_distribution_filename::benchmark_wheelname_parsing

15.6 µs15.5 µs

wheelname_tag_compatibility[flyte-long-compatible]

crates/uv-bench/benches/distribution_filename.rs::uv_distribution_filename::benchmark_wheelname_tag_compatibility

1.8 µs1.8 µs

wheelname_tag_compatibility[flyte-long-incompatible]

crates/uv-bench/benches/distribution_filename.rs::uv_distribution_filename::benchmark_wheelname_tag_compatibility

1.3 µs1.3 µs

wheelname_parsing[flyte-short-compatible]

crates/uv-bench/benches/distribution_filename.rs::uv_distribution_filename::benchmark_wheelname_parsing

5.1 µs5.1 µs

wheelname_tag_compatibility[flyte-short-compatible]

crates/uv-bench/benches/distribution_filename.rs::uv_distribution_filename::benchmark_wheelname_tag_compatibility

1.6 µs1.6 µs

build_platform_tags[burntsushi-archlinux]

crates/uv-bench/benches/distribution_filename.rs::uv_distribution_filename::benchmark_build_platform_tags

280.4 µs280.4 µs

resolve_warm_jupyter_universal

crates/uv-bench/benches/uv.rs::uv::resolve_warm_jupyter_universal

-1%

182.4 ms184 ms

resolve_warm_airflow

crates/uv-bench/benches/uv.rs::uv::resolve_warm_airflow

-1%

614.7 ms620.3 ms

wheelname_parsing_failure[flyte-long-extension]

crates/uv-bench/benches/distribution_filename.rs::uv_distribution_filename::benchmark_wheelname_parsing_failure

-2%

1.7 µs1.7 µs

wheelname_parsing_failure[flyte-short-extension]

crates/uv-bench/benches/distribution_filename.rs::uv_distribution_filename::benchmark_wheelname_parsing_failure

-2%

1.7 µs1.7 µs

Commits

Click on a commit to change the comparison range

Base

main

8d6d616

-0.61%

Fix detection of sorted dependencies when include-group is used If a dependency group contained any `{ include-group = "..." }` entries, the sort detection would bail out. The root cause of the problem was `deps.iter().all(Value::is_str)`. A public code search reveals that keeping include-groups at the top is by far the most common, but keeping them at the bottom isn't uncommon. In both of these cases, uv will preserve the convention that is in use.

f15dde6

6 months ago

by RazerM

+0.27%

Avoid unnecessary clone

7e5fb38

6 months ago

by RazerM

+0.1%

Minor tweaks

0188e59

6 months ago

by charliermarsh

Home Terms Privacy Docs