pieterh-oai:pieterh-oai/G004-implicit-concat - Branch - astral-sh/ruff - CodSpeed

Blog Docs Changelog

[`flake8-logging-format`] Avoid dropping implicitly concatenated pieces in the `G004` fix

#20793Merged

Comparing

pieterh-oai:pieterh-oai/G004-implicit-concat

(

f7aab73

) with

main

(

8248193

)

0%

Untouched: 30

Ignored: 1

Skipped: 21

Benchmarks

Skipped (22)

Passed

linter/all-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

0%

720.3 µs718.2 µs

linter/all-with-preview-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

0%

803.2 µs801.6 µs

linter/all-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

0%

1.9 ms1.9 ms

parser[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

0%

927.9 µs927.8 µs

formatter[unicode/pypinyin.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

0%

665.6 µs665.6 µs

linter/all-with-preview-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

0%

2.1 ms2.1 ms

parser[large/dataset.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

0%

5 ms5 ms

parser[pydantic/types.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

0%

2 ms2 ms

formatter[large/dataset.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

0%

9.6 ms9.6 ms

formatter[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

0%

1.9 ms1.9 ms

lexer[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

0%

219.8 µs219.8 µs

lexer[large/dataset.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

0%

1.1 ms1.1 ms

lexer[unicode/pypinyin.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

0%

75.7 µs75.7 µs

lexer[pydantic/types.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

0%

492.3 µs492.3 µs

lexer[numpy/globals.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

0%

29.4 µs29.4 µs

formatter[pydantic/types.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

0%

3.6 ms3.6 ms

formatter[numpy/globals.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

0%

241.5 µs241.5 µs

parser[unicode/pypinyin.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

0%

321.3 µs321.3 µs

parser[numpy/globals.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

0%

106.7 µs106.7 µs

linter/all-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

0%

8.1 ms8.1 ms

linter/all-with-preview-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

0%

4.9 ms4.9 ms

linter/all-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

0%

4.2 ms4.2 ms

linter/all-with-preview-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

0%

9.6 ms9.6 ms

linter/all-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

0%

17.7 ms17.8 ms

linter/all-with-preview-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

0%

21.3 ms21.3 ms

linter/default-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

0%

195.4 µs195.9 µs

linter/default-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

0%

966.3 µs970.3 µs

linter/default-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

0%

2 ms2 ms

linter/default-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

-1%

377.1 µs379.6 µs

linter/default-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

-1%

4 ms4.1 ms

Commits

Click on a commit to change the comparison range

Base

main

8248193

-0.08%

[G004] autofix drops implicit concat pieces in the format string Test: ``` cargo test -p ruff_linter ``` Backtest (run new testcases against previous implementation): ``` git checkout HEAD^ crates/ruff_linter/src/rules/flake8_logging_format/rules/logging_call.rs cargot test -p ruff_linter ```

f7aab73

4 days ago

by pieterh-oai

© 2025 CodSpeed Technology

Home Terms Privacy Docs