gankra/implort3 - Branch - astral-sh/ruff

[ty] Support implicit imports of submodules in `init.pyi`

#20855

Comparing

gankra/implort3

(

1b0fe31

) with

main

(

5e08e54

)

-11%

Regressions: 5

Untouched: 46

Ignored: 1

Benchmarks

Failed

medium[pandas]

crates/ruff_benchmark/benches/ty_walltime.rs

Regression

-10%

33.9 s37.8 s

medium[colour-science]

crates/ruff_benchmark/benches/ty_walltime.rs

Regression

-11%

12 s13.5 s

medium[static-frame]

crates/ruff_benchmark/benches/ty_walltime.rs

Regression

-7%

9.5 s10.2 s

small[freqtrade]

crates/ruff_benchmark/benches/ty_walltime.rs

Regression

-5%

4.9 s5.1 s

small[altair]

crates/ruff_benchmark/benches/ty_walltime.rs

Regression

-6%

2.6 s2.8 s

Passed

ty_micro[many_tuple_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_tuple_assignments

62.7 ms62.5 ms

ty_micro[many_tuple_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_tuple_implicit_instance_attributes

63.9 ms63.8 ms

ty_micro[many_string_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_string_assignments

73 ms72.9 ms

linter/all-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

17.7 ms17.7 ms

parser[numpy/globals.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

106 µs105.9 µs

ty_micro[complex_constrained_attributes_3]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_3

67 ms66.9 ms

linter/all-with-preview-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

21.3 ms21.3 ms

formatter[unicode/pypinyin.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

665.5 µs665 µs

parser[unicode/pypinyin.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

321.2 µs320.9 µs

anyio

crates/ruff_benchmark/benches/ty.rs::project::anyio::project

898.1 ms897.5 ms

linter/default-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

4 ms4 ms

parser[large/dataset.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

5 ms5 ms

ty_check_file[cold]

crates/ruff_benchmark/benches/ty.rs::check_file::benchmark_cold

122.9 ms122.8 ms

linter/all-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

4.2 ms4.2 ms

parser[pydantic/types.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

2 ms2 ms

linter/all-with-preview-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

9.6 ms9.6 ms

linter/all-with-preview-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

4.9 ms4.9 ms

parser[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

930.7 µs930.6 µs

linter/all-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

8.1 ms8.1 ms

formatter[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

1.9 ms1.9 ms

linter/default-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

2 ms2 ms

lexer[unicode/pypinyin.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

76.1 µs76.1 µs

linter/default-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

957 µs957.1 µs

lexer[large/dataset.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

1.1 ms1.1 ms

formatter[large/dataset.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

9.5 ms9.5 ms

lexer[pydantic/types.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

493.7 µs493.9 µs

ty_micro[complex_constrained_attributes_1]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_1

63.9 ms64 ms

linter/default-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

194.2 µs194.3 µs

attrs

crates/ruff_benchmark/benches/ty.rs::project::attrs::project

412.6 ms412.8 ms

formatter[pydantic/types.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

3.6 ms3.6 ms

linter/all-with-preview-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

803.6 µs803.9 µs

linter/all-with-preview-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

2.1 ms2.1 ms

lexer[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

220.6 µs220.7 µs

ty_check_file[incremental]

crates/ruff_benchmark/benches/ty.rs::check_file::benchmark_incremental

5.2 ms5.2 ms

linter/all-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

711.3 µs711.9 µs

linter/all-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

1.8 ms1.8 ms

formatter[numpy/globals.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

240.7 µs240.9 µs

lexer[numpy/globals.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

29.4 µs29.5 µs

linter/default-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

376.5 µs377 µs

hydra-zen

crates/ruff_benchmark/benches/ty.rs::project::hydra::project

936.2 ms937.7 ms

ty_micro[many_enum_members]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_enum_members

92.6 ms92.9 ms

DateType

crates/ruff_benchmark/benches/ty.rs::project::datetype::project

194.5 ms195 ms

ty_micro[complex_constrained_attributes_2]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_complex_constrained_attributes_2

63.9 ms64.1 ms

large[sympy]

crates/ruff_benchmark/benches/ty_walltime.rs

42.5 s42.7 s

small[pydantic]

crates/ruff_benchmark/benches/ty_walltime.rs

-1%

2.6 s2.6 s

small[tanjun]

crates/ruff_benchmark/benches/ty_walltime.rs

-3%

1.7 s1.8 s

Ignored

multithreaded[pydantic]

crates/ruff_benchmark/benches/ty_walltime.rs

Ignored

-4%

302.9 ms314.2 ms

Commits

Click on a commit to change the comparison range

Base

main

5e08e54

-11.02%

Support implicit imports of submodules in `__init__.pyi` This is a second take at the implicit imports approach, allowing `from . import submodule` in an `__init__.pyi` to create the `mypackage.submodule` attribute everyhere. This implementation operates inside of the available_submodule_attributes subsystem instead of as a re-export rule. The upside of this is we are no longer purely syntactic, and absolute from imports that happen to target submodules work (an intentional discussed deviation from pyright which demands a relative from import). Also we don't re-export functions or classes. The downside(?) of this is star imports no longer see these attributes (this may be either good or bad. I believe it's not a huge lift to make it work with star imports but it's some non-trivial reworking). I've also intentionally made `import mypackage.submodule` not trigger this rule although it's trivial to change that. I've tried to cover as many relevant cases as possible for discussion in the new test file I've added (there are some random overlaps with existing tests but trying to add them piecemeal felt confusing and weird, so I just made a dedicated file for this extension to the rules). Fixes #133

1b0fe31

5 days ago

by Gankra

Home Terms Privacy Docs

[ty] Support implicit imports of submodules in `__init__.pyi`

Benchmarks

Passed

Ignored

Commits

[ty] Support implicit imports of submodules in `init.pyi`