dcreager/static-terminal - Branch - astral-sh/ruff

[red-knot] Combine terminal statement support with statically known branches

#15817Merged

Comparing

dcreager/static-terminal

(

7423de2

) with

main

(

d47088c

)

-8%

Regressions: 1
(
1
)

Untouched: 31

Benchmarks

Passed

linter/default-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

193.9 µs193.8 µs

linter/default-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

352.4 µs352.3 µs

linter/all-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

4.2 ms4.2 ms

linter/all-with-preview-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

5.1 ms5.1 ms

linter/default-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

1.8 ms1.8 ms

linter/all-with-preview-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

839.3 µs839.3 µs

linter/all-with-preview-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

20.9 ms20.9 ms

linter/all-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

17 ms17 ms

linter/all-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

8.7 ms8.7 ms

linter/default-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

920.4 µs920.4 µs

linter/all-with-preview-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

10.4 ms10.4 ms

linter/default-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

3.7 ms3.7 ms

formatter[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

1.9 ms1.9 ms

linter/all-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

726.1 µs726.1 µs

formatter[numpy/globals.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

239.4 µs239.4 µs

formatter[large/dataset.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

9.4 ms9.4 ms

linter/all-with-preview-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

2.5 ms2.5 ms

lexer[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

218.1 µs218.1 µs

lexer[pydantic/types.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

486.7 µs486.7 µs

formatter[unicode/pypinyin.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

657.4 µs657.4 µs

formatter[pydantic/types.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

3.5 ms3.5 ms

parser[large/dataset.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

4.8 ms4.8 ms

parser[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

917.7 µs917.8 µs

lexer[large/dataset.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

1.1 ms1.1 ms

parser[pydantic/types.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

1.9 ms1.9 ms

linter/all-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

2.3 ms2.3 ms

lexer[unicode/pypinyin.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

74.9 µs75 µs

parser[unicode/pypinyin.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

307.9 µs308.1 µs

lexer[numpy/globals.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

29.2 µs29.2 µs

parser[numpy/globals.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

102.1 µs102.2 µs

red_knot_check_file[cold]

crates/ruff_benchmark/benches/red_knot.rs::check_file::benchmark_cold

-3%

92 ms95.2 ms

red_knot_check_file[incremental]

crates/ruff_benchmark/benches/red_knot.rs::check_file::benchmark_incremental

Regression

-8%

4.8 ms5.2 ms

Commits

Click on a commit to change the comparison range

Base

main

d47088c

Reachability is now a vis constraint, not a bool

7504fb7

11 months ago

by dcreager

-0.02%

clippy

bb11cf8

11 months ago

by dcreager

-0.03%

Expected test case change

1a80f81

11 months ago

by dcreager

-11.93%

And try via a separate `always_reachable` boolean

0e06012

11 months ago

by dcreager

-2.13%

But that doesn't work either (because OR-ing reachability on merge throws away the AlwaysFalse)

0f278da

11 months ago

by dcreager

+7.69%

And another

c80f27e

11 months ago

by dcreager

-1.7%

New bindings are visible only if control flow is reachable

0d50385

11 months ago

by dcreager

+0.13%

Add xfail for RET503

c42490c

11 months ago

by dcreager

Add TODO to function symbol comment

1d93650

11 months ago

by dcreager

+0.04%

Spelling typo

f13a6a6

11 months ago

by dcreager

Add TODO for unreachable code example

7423de2

11 months ago

by dcreager

Home Terms Privacy Docs