brent/directive-rule - Branch - astral-sh/ruff

Use `Rule` for `FileNoqaDirective`s

#18966Merged

Comparing

brent/directive-rule

(

2bbc37e

) with

brent/string-noqa-code

(

4eab76b

)

Untouched: 37

Dropped: 1

Benchmarks

Failed

ty_micro[many_attribute_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_attribute_assignments

Missing

N/A

56.6 msN/A

Passed

ty_micro[many_string_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_string_assignments

+2%

73.8 ms72.3 ms

linter/all-with-preview-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

+2%

4.9 ms4.8 ms

ty_check_file[cold]

crates/ruff_benchmark/benches/ty.rs::check_file::benchmark_cold

+2%

124.1 ms122 ms

linter/all-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

+1%

17.4 ms17.2 ms

linter/all-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

+1%

4.1 ms4.1 ms

linter/all-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

+1%

701.2 µs691.6 µs

linter/all-with-preview-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

+1%

21.1 ms20.8 ms

ty_micro[many_tuple_assignments]

crates/ruff_benchmark/benches/ty.rs::micro::benchmark_many_tuple_assignments

+1%

129.5 ms128.1 ms

anyio

crates/ruff_benchmark/benches/ty.rs::project::anyio::project

+1%

895.4 ms886.6 ms

attrs

crates/ruff_benchmark/benches/ty.rs::project::attrs::project

+1%

373.6 ms370.9 ms

ty_check_file[incremental]

crates/ruff_benchmark/benches/ty.rs::check_file::benchmark_incremental

+1%

5.7 ms5.6 ms

hydra-zen

crates/ruff_benchmark/benches/ty.rs::project::hydra::project

+1%

757.5 ms752.6 ms

linter/default-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

+1%

195 µs194 µs

linter/all-with-preview-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

+1%

10 ms10 ms

linter/all-with-preview-rules[numpy/globals.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

+1%

789.5 µs785.5 µs

linter/default-rules[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

966.6 µs962.7 µs

linter/default-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

380.9 µs379.5 µs

linter/default-rules[large/dataset.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

4 ms4 ms

linter/all-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

8.5 ms8.4 ms

lexer[numpy/globals.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

29.2 µs29.2 µs

lexer[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

218.4 µs218.3 µs

formatter[numpy/globals.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

241.9 µs241.8 µs

lexer[pydantic/types.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

488.4 µs488.4 µs

linter/all-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::all_rules::benchmark_all_rules

1.9 ms1.9 ms

lexer[large/dataset.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

1.1 ms1.1 ms

formatter[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

1.9 ms1.9 ms

formatter[unicode/pypinyin.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

664.6 µs664.6 µs

formatter[pydantic/types.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

3.6 ms3.6 ms

parser[pydantic/types.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

2 ms2 ms

parser[large/dataset.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

4.9 ms4.9 ms

lexer[unicode/pypinyin.py]

crates/ruff_benchmark/benches/lexer.rs::lexer::benchmark_lexer

75.4 µs75.4 µs

parser[numpy/globals.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

105.9 µs105.9 µs

formatter[large/dataset.py]

crates/ruff_benchmark/benches/formatter.rs::formatter::benchmark_formatter

9.5 ms9.5 ms

parser[numpy/ctypeslib.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

930.7 µs930.7 µs

parser[unicode/pypinyin.py]

crates/ruff_benchmark/benches/parser.rs::parser::benchmark_parser

320.8 µs320.9 µs

linter/default-rules[pydantic/types.py]

crates/ruff_benchmark/benches/linter.rs::default_rules::benchmark_default_rules

2 ms2 ms

linter/all-with-preview-rules[unicode/pypinyin.py]

crates/ruff_benchmark/benches/linter.rs::preview_rules::benchmark_preview_rules

2.1 ms2.1 ms

Commits

Click on a commit to change the comparison range

Base

brent/string-noqa-code

4eab76b

-0.35%

Use `Rule` for `FileNoqaDirective`s Summary -- See https://github.com/astral-sh/ruff/pull/18946#discussion_r2168459251. Test Plan -- Existing tests

dfc2548

5 months ago

by ntBre

+0.84%

return early if there are no noqa directives in the file

2bbc37e

5 months ago

by ntBre

Home Terms Privacy Docs